{"thread":{"id":"38786","subject":"[PATCH] tag: fix some mis-organized options in \"-h\" listing","startedAt":"2015-03-12T18:15:09Z","lastAt":"2015-03-12T19:10:38Z","messageCount":2,"participants":["Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"257594","messageId":"20150312181509.GA20987@peff.net","threadId":"38786","inReplyTo":null,"subject":"[PATCH] tag: fix some mis-organized options in \"-h\" listing","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2015-03-12T18:15:09Z","receivedAt":"2015-03-12T18:15:09Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"Running \"git tag -h\" currently prints:\n\n  [...]\n  Tag creation options\n      [...]\n      --column[=<style>]    show tag list in columns\n      --sort <type>         sort tags\n\n  Tag listing options\n      --contains <commit>   print only tags that contain the commit\n      --points-at <object>  print only tags of the object\n\nThe \"--column\" and \"--sort\" options should go under the \"Tag listing\" group.\n\nSigned-off-by: Jeff King <peff@peff.net>\n---\n builtin/tag.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/tag.c b/builtin/tag.c\nindex 4194b9a..6f07ac6 100644\n--- a/builtin/tag.c\n+++ b/builtin/tag.c\n@@ -605,13 +605,13 @@ int cmd_tag(int argc, const char **argv, const char *prefix)\n \t\tOPT_STRING('u', \"local-user\", &keyid, N_(\"key-id\"),\n \t\t\t\t\tN_(\"use another key to sign the tag\")),\n \t\tOPT__FORCE(&force, N_(\"replace the tag if exists\")),\n+\n+\t\tOPT_GROUP(N_(\"Tag listing options\")),\n \t\tOPT_COLUMN(0, \"column\", &colopts, N_(\"show tag list in columns\")),\n \t\t{\n \t\t\tOPTION_CALLBACK, 0, \"sort\", &tag_sort, N_(\"type\"), N_(\"sort tags\"),\n \t\t\tPARSE_OPT_NONEG, parse_opt_sort\n \t\t},\n-\n-\t\tOPT_GROUP(N_(\"Tag listing options\")),\n \t\t{\n \t\t\tOPTION_CALLBACK, 0, \"contains\", &with_commit, N_(\"commit\"),\n \t\t\tN_(\"print only tags that contain the commit\"),\n-- \n2.3.2.472.geadab3c\n"},{"id":"257599","messageId":"xmqq61a62frl.fsf@gitster.dls.corp.google.com","threadId":"38786","inReplyTo":"20150312181509.GA20987@peff.net","subject":"Re: [PATCH] tag: fix some mis-organized options in \"-h\" listing","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-03-12T19:10:38Z","receivedAt":"2015-03-12T19:10:38Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n\nEven though this dates back to d96e3c15 (tag: add --column,\n2012-04-13), I do not think it is worth backporting it to v1.7.x\nseries, so I'll queue the fix for a bit newer maintenance track,\nperhaps for v2.1.x and above.\n"}]}