{"thread":{"id":"38760","subject":"[PATCH] Add --recursive flag to git bash completion script.","startedAt":"2015-03-09T00:00:16Z","lastAt":"2015-03-09T10:43:53Z","messageCount":2,"participants":["James","Thomas Ferris Nicolaisen"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"257354","messageId":"1425859216.8244.40.camel@gmail.com","threadId":"38760","inReplyTo":null,"subject":"[PATCH] Add --recursive flag to git bash completion script.","fromName":"James","fromEmail":"purpleidea@gmail.com","sentAt":"2015-03-09T00:00:16Z","receivedAt":"2015-03-09T00:00:16Z","isPatch":true,"sender":{"key":"purpleidea@gmail.com","avatar":"https://gravatar.com/avatar/161941d0314aee3803e1012aa5dedb2403ed9dcd00ec769bce81435493abe18d?d=mp&s=160"},"body":"This is a patch to add a much needed option to the bash completion\nscript. I'm not subscribed to this list, so please include me in your\nreply if you'd like me to see your response.\n\nThanks,\nJames\n\n\n\nFrom ca976de5bfeccc9bd69c22183f82b9d1e59d2547 Mon Sep 17 00:00:00 2001\nFrom: James Shubin <james@shubin.ca>\nDate: Sun, 8 Mar 2015 19:57:17 -0400\nSubject: [PATCH] Add --recursive flag to git bash completion script.\n\nThis flag was missing from the list, and I use it quite often :)\n\nSigned-off-by: James Shubin <james@shubin.ca>\n---\n contrib/completion/git-completion.bash | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex c21190d..6cb7ff5 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1090,6 +1090,7 @@ _git_clone ()\n \t\t\t--no-hardlinks\n \t\t\t--shared\n \t\t\t--reference\n+\t\t\t--recursive\n \t\t\t--quiet\n \t\t\t--no-checkout\n \t\t\t--bare\n-- \n2.1.0\n\n"},{"id":"257393","messageId":"CAEcj5uVCudOV3a9BaWnwY=dvAOGmPfYfBeFBS9y2vyrzBBZbOQ@mail.gmail.com","threadId":"38760","inReplyTo":"1425859216.8244.40.camel@gmail.com","subject":"Re: [PATCH] Add --recursive flag to git bash completion script.","fromName":"Thomas Ferris Nicolaisen","fromEmail":"tfnico@gmail.com","sentAt":"2015-03-09T10:43:53Z","receivedAt":"2015-03-09T10:43:53Z","isPatch":true,"sender":{"key":"tfnico@gmail.com","avatar":"https://gravatar.com/avatar/628cf28a25ca4c596c7284562100f70f0ef908bcbfadd4da1eb3d48c23658d01?d=mp&s=160"},"body":"On Mon, Mar 9, 2015 at 1:00 AM, James <purpleidea@gmail.com> wrote:\n> This is a patch to add a much needed option to the bash completion\n> script. I'm not subscribed to this list, so please include me in your\n> reply if you'd like me to see your response.\n\nPlease read the guide on how to submit patches [1].\n\nAlthough the change is trivial, some immediate problems I see are:\n\n* The patch is attached rather than being inlined.\n* The fix should also be made for the other shells (zsh and tcsh)\n* The commit message contains an unnecessary smiley, personal\ndigression, and a period in the first line.\n* The change or the problem it is solving is not clearly described. I\nthink it would be better if you write something like this in the first\nline:\n\n\"completion: add --recursive flag to git clone\"\n\nAnd for good measure, add another sentence below explaining why this\nshould be available for completion.\n\nDo a `git log --grep completion` to see how others have formulated\nchanges in the same place in the past. You want to be consistent with\nthem.\n\n[1] https://raw.githubusercontent.com/git/git/master/Documentation/SubmittingPatches\n"}]}