{"thread":{"id":"38732","subject":"[PATCH] send-email: Add CCs from additional commit tags","startedAt":"2015-03-06T21:59:21Z","lastAt":"2015-03-10T23:00:13Z","messageCount":2,"participants":["Soren Brinkmann","Eric Sunshine"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"257204","messageId":"1425679161-13963-1-git-send-email-soren.brinkmann@xilinx.com","threadId":"38732","inReplyTo":null,"subject":"[PATCH] send-email: Add CCs from additional commit tags","fromName":"Soren Brinkmann","fromEmail":"soren.brinkmann@xilinx.com","sentAt":"2015-03-06T21:59:21Z","receivedAt":"2015-03-06T21:59:21Z","isPatch":true,"sender":{"key":"soren.brinkmann@xilinx.com","avatar":null},"body":"Add email addresses from additional commonly used tags to the CC-list of\npatches. Additional tags are:\n - Acked-by\n - Reviewed-by\n - Tested-by\n - Reported-by\n - Reviewed-and-tested-by\n\n--suppress-cc=ack suppresses these additional CCs.\n\nSigned-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>\n---\n Documentation/git-send-email.txt | 3 +++\n git-send-email.perl              | 5 +++--\n 2 files changed, 6 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex f248a8665e1f..1b521446ca11 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -293,6 +293,9 @@ Automating\n   patch body (commit message) except for self (use 'self' for that).\n - 'sob' will avoid including anyone mentioned in Signed-off-by lines except\n    for self (use 'self' for that).\n+- 'ack' will avoid including anyone who acked the  patch (mentioned in\n+  Acked-by, Reviewed-by, Tested-by, Reviewed-and-tested-by lines except for\n+  self (use 'self' for that).\n - 'cccmd' will avoid running the --cc-cmd.\n - 'body' is equivalent to 'sob' + 'bodycc'\n - 'all' will suppress all auto cc values.\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex 3092ab356c76..18eb8a5139a4 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -407,7 +407,7 @@ my(%suppress_cc);\n if (@suppress_cc) {\n \tforeach my $entry (@suppress_cc) {\n \t\tdie \"Unknown --suppress-cc field: '$entry'\\n\"\n-\t\t\tunless $entry =~ /^(?:all|cccmd|cc|author|self|sob|body|bodycc)$/;\n+\t\t\tunless $entry =~ /^(?:all|cccmd|cc|author|self|sob|body|bodycc|ack)$/;\n \t\t$suppress_cc{$entry} = 1;\n \t}\n }\n@@ -1452,7 +1452,7 @@ foreach my $t (@files) {\n \t# Now parse the message body\n \twhile(<$fh>) {\n \t\t$message .=  $_;\n-\t\tif (/^(Signed-off-by|Cc): (.*)$/i) {\n+\t\tif (/^(Signed-off-by|Cc|Acked-by|Reviewed-by|Tested-by|Reported-by|Reviewed-and-tested-by): (.*)$/i) {\n \t\t\tchomp;\n \t\t\tmy ($what, $c) = ($1, $2);\n \t\t\tchomp $c;\n@@ -1462,6 +1462,7 @@ foreach my $t (@files) {\n \t\t\t} else {\n \t\t\t\tnext if $suppress_cc{'sob'} and $what =~ /Signed-off-by/i;\n \t\t\t\tnext if $suppress_cc{'bodycc'} and $what =~ /Cc/i;\n+\t\t\t\tnext if $suppress_cc{'ack'} and $what =~ /(Acked-by|Reviewed-by|Tested-by|Reported-by|Reviewed-and-tested-by)/i;\n \t\t\t}\n \t\t\tpush @cc, $c;\n \t\t\tprintf(\"(body) Adding cc: %s from line '%s'\\n\",\n-- \n2.3.1.2.g90df61e.dirty\n"},{"id":"257512","messageId":"CAPig+cSJkGQ8YHb7D5XV2DvNCyxdAf4GksRNAqEt-kEXznaNUw@mail.gmail.com","threadId":"38732","inReplyTo":"1425679161-13963-1-git-send-email-soren.brinkmann@xilinx.com","subject":"Re: [PATCH] send-email: Add CCs from additional commit tags","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2015-03-10T23:00:13Z","receivedAt":"2015-03-10T23:00:13Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Fri, Mar 6, 2015 at 4:59 PM, Soren Brinkmann\n<soren.brinkmann@xilinx.com> wrote:\n> Add email addresses from additional commonly used tags to the CC-list of\n> patches. Additional tags are:\n>  - Acked-by\n>  - Reviewed-by\n>  - Tested-by\n>  - Reported-by\n>  - Reviewed-and-tested-by\n>\n> --suppress-cc=ack suppresses these additional CCs.\n\nThis and similar suggestions have come up a number of times. Rather\nthan hard-coding an ever-growing list of tags, general consensus seems\nto be that it would be better to provide some sort of mechanism for\npeople to customize the list for their needs. See, for instance, [1].\nSuch ability would also be a better fit for non-standard, potentially\ncontested tags, such as Reviewed-and-tested-by:.\n\n[1]: http://thread.gmane.org/gmane.comp.version-control.git/233003/focus=233739\n\n> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>\n> ---\n>  Documentation/git-send-email.txt | 3 +++\n>  git-send-email.perl              | 5 +++--\n>  2 files changed, 6 insertions(+), 2 deletions(-)\n>\n> diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\n> index f248a8665e1f..1b521446ca11 100644\n> --- a/Documentation/git-send-email.txt\n> +++ b/Documentation/git-send-email.txt\n> @@ -293,6 +293,9 @@ Automating\n>    patch body (commit message) except for self (use 'self' for that).\n>  - 'sob' will avoid including anyone mentioned in Signed-off-by lines except\n>     for self (use 'self' for that).\n> +- 'ack' will avoid including anyone who acked the  patch (mentioned in\n> +  Acked-by, Reviewed-by, Tested-by, Reviewed-and-tested-by lines except for\n> +  self (use 'self' for that).\n>  - 'cccmd' will avoid running the --cc-cmd.\n>  - 'body' is equivalent to 'sob' + 'bodycc'\n>  - 'all' will suppress all auto cc values.\n> diff --git a/git-send-email.perl b/git-send-email.perl\n> index 3092ab356c76..18eb8a5139a4 100755\n> --- a/git-send-email.perl\n> +++ b/git-send-email.perl\n> @@ -407,7 +407,7 @@ my(%suppress_cc);\n>  if (@suppress_cc) {\n>         foreach my $entry (@suppress_cc) {\n>                 die \"Unknown --suppress-cc field: '$entry'\\n\"\n> -                       unless $entry =~ /^(?:all|cccmd|cc|author|self|sob|body|bodycc)$/;\n> +                       unless $entry =~ /^(?:all|cccmd|cc|author|self|sob|body|bodycc|ack)$/;\n>                 $suppress_cc{$entry} = 1;\n>         }\n>  }\n> @@ -1452,7 +1452,7 @@ foreach my $t (@files) {\n>         # Now parse the message body\n>         while(<$fh>) {\n>                 $message .=  $_;\n> -               if (/^(Signed-off-by|Cc): (.*)$/i) {\n> +               if (/^(Signed-off-by|Cc|Acked-by|Reviewed-by|Tested-by|Reported-by|Reviewed-and-tested-by): (.*)$/i) {\n>                         chomp;\n>                         my ($what, $c) = ($1, $2);\n>                         chomp $c;\n> @@ -1462,6 +1462,7 @@ foreach my $t (@files) {\n>                         } else {\n>                                 next if $suppress_cc{'sob'} and $what =~ /Signed-off-by/i;\n>                                 next if $suppress_cc{'bodycc'} and $what =~ /Cc/i;\n> +                               next if $suppress_cc{'ack'} and $what =~ /(Acked-by|Reviewed-by|Tested-by|Reported-by|Reviewed-and-tested-by)/i;\n>                         }\n>                         push @cc, $c;\n>                         printf(\"(body) Adding cc: %s from line '%s'\\n\",\n> --\n> 2.3.1.2.g90df61e.dirty\n"}]}