{"thread":{"id":"38722","subject":"GSoC applicants: discuss other applicants patches, perhaps?","startedAt":"2015-03-06T07:44:08Z","lastAt":"2015-03-08T10:10:02Z","messageCount":5,"participants":["Junio C Hamano","Matthieu Moy","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"257131","messageId":"CAPc5daV7Dv8K8itmQhdf1CG-opMVw7DYyheHdcdL0r_9zFQR-Q@mail.gmail.com","threadId":"38722","inReplyTo":null,"subject":"GSoC applicants: discuss other applicants patches, perhaps?","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-03-06T07:44:08Z","receivedAt":"2015-03-06T07:44:08Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"The objective of GSoC program is to learn how to work on\nprojects as a part of an open source community, and working\nin Git project is not only about writing your own patches.\nConstructively critiquing design and implementation of\npatches by other people is also an important skill you need\nto learn in order to effectively collaborate with others.\n\nSo, if you have time and inclination, it would be beneficial\nto read and understand other applicants' patches, think if\nyou agree that the problem they are trying to solve is worth\nsolving, the approach they are taking is the best way (or\nif you think of a better way to solve it), etc., and respond\nto their patches with the result of your thinking as a review.\n\nWhat do mentors and others think?\n"},{"id":"257153","messageId":"1425642837-31651-1-git-send-email-Matthieu.Moy@imag.fr","threadId":"38722","inReplyTo":"CAPc5daV7Dv8K8itmQhdf1CG-opMVw7DYyheHdcdL0r_9zFQR-Q@mail.gmail.com","subject":"[PATCH] Suggest applicants to participate in review of other peoples' patches","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@imag.fr","sentAt":"2015-03-06T11:53:57Z","receivedAt":"2015-03-06T11:53:57Z","isPatch":true,"sender":{"key":"git@matthieu-moy.fr","avatar":"https://avatars.githubusercontent.com/u/14709?v=4"},"body":"Idea and most of the wording comes from Junio's message on the list. I\nadded a hint to include links to review in the application (which makes\nthe suggestion a bit stronger since it implies that it will be taken into\naccount in the selection).\n\nSigned-off-by: Matthieu Moy \n---\n> What do mentors and others think?\n\nVery good idea indeed.\n\n SoC-2015-Ideas.md | 15 ++++++++++++++-\n 1 file changed, 14 insertions(+), 1 deletion(-)\n\ndiff --git a/SoC-2015-Ideas.md b/SoC-2015-Ideas.md\nindex 0ccbcdc..ba8b25e 100644\n--- a/SoC-2015-Ideas.md\n+++ b/SoC-2015-Ideas.md\n@@ -16,9 +16,22 @@ way for us to get experience with applicants, but it will also help\n applicants become familiar with Git's development and submission\n process.\n \n+Also, working in Git project is not only about writing your own\n+patches. Constructively critiquing design and implementation of\n+patches by other people is also an important skill you need to learn\n+in order to effectively collaborate with others. So, if you have time\n+and inclination, it would be beneficial to read and understand other\n+applicants' patches (or any other patch submitted to the mailing-list),\n+think if you agree that the problem they are trying to solve is worth\n+solving, the approach they are taking is the best way (or if you think\n+of a better way to solve it), etc., and respond to their patches with\n+the result of your thinking as a review.\n+\n Please, include link(s) to the mailing-list discussion(s) related to\n your microproject in your application (e.g. linking to\n-[gmane](http://news.gmane.org/gmane.comp.version-control.git)).\n+[gmane](http://news.gmane.org/gmane.comp.version-control.git)). If you\n+participate in the review of other patches, then you may also include\n+links to discussions that would support your application.\n \n ## Note about the number of slots\n \n-- \n2.3.0.157.g79e124b\n"},{"id":"257198","messageId":"20150306211048.GB24267@peff.net","threadId":"38722","inReplyTo":"1425642837-31651-1-git-send-email-Matthieu.Moy@imag.fr","subject":"Re: [PATCH] Suggest applicants to participate in review of other peoples' patches","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2015-03-06T21:10:48Z","receivedAt":"2015-03-06T21:10:48Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Mar 06, 2015 at 12:53:57PM +0100, Matthieu Moy wrote:\n\n> Idea and most of the wording comes from Junio's message on the list. I\n> added a hint to include links to review in the application (which makes\n> the suggestion a bit stronger since it implies that it will be taken into\n> account in the selection).\n\nSeems reasonable. I do not know what the quality of reviews will be from\napplicants, but I guess we will find out. :)\n\n-Peff\n"},{"id":"257202","messageId":"xmqqd24lyejv.fsf@gitster.dls.corp.google.com","threadId":"38722","inReplyTo":"20150306211048.GB24267@peff.net","subject":"Re: [PATCH] Suggest applicants to participate in review of other peoples' patches","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-03-06T21:57:40Z","receivedAt":"2015-03-06T21:57:40Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King writes:\n\n> On Fri, Mar 06, 2015 at 12:53:57PM +0100, Matthieu Moy wrote:\n>\n>> Idea and most of the wording comes from Junio's message on the list. I\n>> added a hint to include links to review in the application (which makes\n>> the suggestion a bit stronger since it implies that it will be taken into\n>> account in the selection).\n>\n> Seems reasonable. I do not know what the quality of reviews will be from\n> applicants, but I guess we will find out. :)\n\nI actually was hoping to see an applicant replaying the review\ncomments given to him to another applicant that makes the same kind\nof mistakes. That is a fairly easy entry to get into reviewing\nprocess---even you may not yet know what you are suggesting the\nother to do is the norm in this community, if a more experienced\nperson told you something similar, it would be likely it is.\n"},{"id":"257286","messageId":"vpq61ab6br9.fsf@anie.imag.fr","threadId":"38722","inReplyTo":"xmqqd24lyejv.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH] Suggest applicants to participate in review of other peoples' patches","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2015-03-08T10:10:02Z","receivedAt":"2015-03-08T10:10:02Z","isPatch":true,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Junio C Hamano writes:\n\n> Jeff King writes:\n>\n>> On Fri, Mar 06, 2015 at 12:53:57PM +0100, Matthieu Moy wrote:\n>>\n>>> Idea and most of the wording comes from Junio's message on the list. I\n>>> added a hint to include links to review in the application (which makes\n>>> the suggestion a bit stronger since it implies that it will be taken into\n>>> account in the selection).\n>>\n>> Seems reasonable. I do not know what the quality of reviews will be from\n>> applicants, but I guess we will find out. :)\n>\n> I actually was hoping to see an applicant replaying the review\n> comments given to him to another applicant that makes the same kind\n> of mistakes.\n\nI'm also hoping that applicants just watch the mailing-list better, and\neven if the don't actually write much, that they read a bit more what's\ngoing on here.\n\nI pushed my patch.\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"}]}