{"thread":{"id":"38720","subject":"[PATCH][GSoC] revision: forbid --graph and --no-walk usage","startedAt":"2015-03-06T05:13:30Z","lastAt":"2015-03-08T10:13:18Z","messageCount":4,"participants":["Akshay Aurora","Junio C Hamano","Matthieu Moy"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"257128","messageId":"1425618810-21192-1-git-send-email-akshayaurora@yahoo.com","threadId":"38720","inReplyTo":null,"subject":"[PATCH][GSoC] revision: forbid --graph and --no-walk usage","fromName":"Akshay Aurora","fromEmail":"akshayaurora@yahoo.com","sentAt":"2015-03-06T05:13:30Z","receivedAt":"2015-03-06T05:13:30Z","isPatch":true,"sender":{"key":"akshayaurora@yahoo.com","avatar":"https://gravatar.com/avatar/07e443d5c5589cab6f36170d55ab46619245b0d58bcb3d8e017e3652f614e856?d=mp&s=160"},"body":"Signed-off-by: Akshay Aurora \n---\nThis is my first patch for a GSoC Microproject, would be great to have your feedback.\n\n revision.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)\n\ndiff --git a/revision.c b/revision.c\nindex bd027bc..d578652 100644\n--- a/revision.c\n+++ b/revision.c\n@@ -2248,7 +2248,8 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s\n \t */\n \tif (revs->reverse && revs->graph)\n \t\tdie(\"cannot combine --reverse with --graph\");\n-\n+\tif (revs->no_walk && revs->graph)\n+\t\tdie(\"cannot combine --no-walk with --graph\");\n \tif (revs->reflog_info && revs->graph)\n \t\tdie(\"cannot combine --walk-reflogs with --graph\");\n \tif (!revs->reflog_info && revs->grep_filter.use_reflog_filter)\n-- \n2.3.1\n"},{"id":"257183","messageId":"xmqqtwxyyo5u.fsf@gitster.dls.corp.google.com","threadId":"38720","inReplyTo":"1425618810-21192-1-git-send-email-akshayaurora@yahoo.com","subject":"Re: [PATCH][GSoC] revision: forbid --graph and --no-walk usage","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-03-06T18:30:05Z","receivedAt":"2015-03-06T18:30:05Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Akshay Aurora writes:\n\n> Signed-off-by: Akshay Aurora \n> ---\n> This is my first patch for a GSoC Microproject, would be great to have your feedback.\n>\n> revision.c | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/revision.c b/revision.c\n> index bd027bc..d578652 100644\n> --- a/revision.c\n> +++ b/revision.c\n> @@ -2248,7 +2248,8 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s\n> \t */\n> \tif (revs->reverse && revs->graph)\n> \t\tdie(\"cannot combine --reverse with --graph\");\n> -\n> +\tif (revs->no_walk && revs->graph)\n> +\t\tdie(\"cannot combine --no-walk with --graph\");\n> \tif (revs->reflog_info && revs->graph)\n> \t\tdie(\"cannot combine --walk-reflogs with --graph\");\n> \tif (!revs->reflog_info && revs->grep_filter.use_reflog_filter)\n\nNeeds a new test to make sure \"log --no-walk --graph\" is rejected,\nand also you need to make sure all other existing tests that used to\npass before this change still pass.\n"},{"id":"257196","messageId":"CAPGnZZ=B4kX2Cbfa4RmjnQToWcBb6nc3AUgvU2rSY4tbW08MKw@mail.gmail.com","threadId":"38720","inReplyTo":"xmqqtwxyyo5u.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH][GSoC] revision: forbid --graph and --no-walk usage","fromName":"Akshay Aurora","fromEmail":"akshayaurora2008@gmail.com","sentAt":"2015-03-06T20:57:40Z","receivedAt":"2015-03-06T20:57:40Z","isPatch":true,"sender":{"key":"akshayaurora2008@gmail.com","avatar":null},"body":"Thanks Junio. Working on v2 for this patch.\n\nOn Sat, Mar 7, 2015 at 12:00 AM, Junio C Hamano wrote:\n> Akshay Aurora writes:\n>\n>> Signed-off-by: Akshay Aurora \n>> ---\n>> This is my first patch for a GSoC Microproject, would be great to have your feedback.\n>>\n>> revision.c | 3 ++-\n>> 1 file changed, 2 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/revision.c b/revision.c\n>> index bd027bc..d578652 100644\n>> --- a/revision.c\n>> +++ b/revision.c\n>> @@ -2248,7 +2248,8 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s\n>> */\n>> if (revs->reverse && revs->graph)\n>> die(\"cannot combine --reverse with --graph\");\n>> -\n>> + if (revs->no_walk && revs->graph)\n>> + die(\"cannot combine --no-walk with --graph\");\n>> if (revs->reflog_info && revs->graph)\n>> die(\"cannot combine --walk-reflogs with --graph\");\n>> if (!revs->reflog_info && revs->grep_filter.use_reflog_filter)\n>\n> Needs a new test to make sure \"log --no-walk --graph\" is rejected,\n> and also you need to make sure all other existing tests that used to\n> pass before this change still pass.\n>\n\n\n\n-- \n- Akshay Aurora\n"},{"id":"257290","messageId":"vpqoao34x1d.fsf@anie.imag.fr","threadId":"38720","inReplyTo":"CAPGnZZ=B4kX2Cbfa4RmjnQToWcBb6nc3AUgvU2rSY4tbW08MKw@mail.gmail.com","subject":"Re: [PATCH][GSoC] revision: forbid --graph and --no-walk usage","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2015-03-08T10:13:18Z","receivedAt":"2015-03-08T10:13:18Z","isPatch":true,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Akshay Aurora writes:\n\n> Thanks Junio. Working on v2 for this patch.\n>\n> On Sat, Mar 7, 2015 at 12:00 AM, Junio C Hamano wrote:\n\nPlease, don't top-post on this list.\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"}]}