{"thread":{"id":"38661","subject":"compiling master fails","startedAt":"2015-02-26T20:48:34Z","lastAt":"2015-02-26T21:00:48Z","messageCount":4,"participants":["Stefan Beller","Jonathan Nieder"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"256703","messageId":"CAGZ79kaRJg1QzFSyj0iAtUn2nUFxzZRy7BsrYC2++kaN0RD1Aw@mail.gmail.com","threadId":"38661","inReplyTo":null,"subject":"compiling master fails","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2015-02-26T20:48:34Z","receivedAt":"2015-02-26T20:48:34Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Post 2.3 cyle (batch #5) (v2.3.1-167-g7f4ba4b)\n\n    CC http.o\nhttp.c: In function 'get_preferred_languages':\nhttp.c:1021:2: warning: implicit declaration of function 'setlocale'\n[-Wimplicit-function-declaration]\n  retval = setlocale(LC_MESSAGES, NULL);\n  ^\nhttp.c:1021:21: error: 'LC_MESSAGES' undeclared (first use in this function)\n  retval = setlocale(LC_MESSAGES, NULL);\n                     ^\nhttp.c:1021:21: note: each undeclared identifier is reported only once\nfor each function it appears in\nmake: *** [http.o] Error 1\n"},{"id":"256704","messageId":"CAGZ79kZvVFTGASbsx6vZXvYJUwLjgqDeCGrN0Cz=3pjW58Qbyw@mail.gmail.com","threadId":"38661","inReplyTo":"CAGZ79kaRJg1QzFSyj0iAtUn2nUFxzZRy7BsrYC2++kaN0RD1Aw@mail.gmail.com","subject":"Re: compiling master fails","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2015-02-26T20:52:18Z","receivedAt":"2015-02-26T20:52:18Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"Removing config.mak makes it compile again.\nconfig.mak contained:\nCFLAGS += -Wall -g -rdynamic -O0\n# CFLAGS += -Wextra\n# CFLAGS += -Werror\nCFLAGS += -Wno-format-zero-length\nCFLAGS += -Wdeclaration-after-statement\nCFLAGS += -Wpointer-arith\nCFLAGS += -Wstrict-prototypes\nCFLAGS += -Wold-style-declaration\n# CFLAGS += -flto\n# CFLAGS += -fwhole-program\nCC = /usr/lib/gcc-snapshot/bin/gcc\n\nMind that compiling did work with this exact version of\nconfig.mak, (I did not touch it for a few weeks now),\nso I suspect new changes in changes to break the\ncompilation.\n\n\nOn Thu, Feb 26, 2015 at 12:48 PM, Stefan Beller <sbeller@google.com> wrote:\n> On Post 2.3 cyle (batch #5) (v2.3.1-167-g7f4ba4b)\n>\n>     CC http.o\n> http.c: In function 'get_preferred_languages':\n> http.c:1021:2: warning: implicit declaration of function 'setlocale'\n> [-Wimplicit-function-declaration]\n>   retval = setlocale(LC_MESSAGES, NULL);\n>   ^\n> http.c:1021:21: error: 'LC_MESSAGES' undeclared (first use in this function)\n>   retval = setlocale(LC_MESSAGES, NULL);\n>                      ^\n> http.c:1021:21: note: each undeclared identifier is reported only once\n> for each function it appears in\n> make: *** [http.o] Error 1\n"},{"id":"256706","messageId":"CAGZ79kZ-4-5zD4xZn7sLjvT3WJEueGFKT6Df7V1By77u5uosgA@mail.gmail.com","threadId":"38661","inReplyTo":"CAGZ79kZvVFTGASbsx6vZXvYJUwLjgqDeCGrN0Cz=3pjW58Qbyw@mail.gmail.com","subject":"Re: compiling master fails","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2015-02-26T20:57:28Z","receivedAt":"2015-02-26T20:57:28Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"> On Thu, Feb 26, 2015 at 12:48 PM, Stefan Beller <sbeller@google.com> wrote:\n>> On Post 2.3 cyle (batch #5) (v2.3.1-167-g7f4ba4b)\n>>\n>>     CC http.o\n>> http.c: In function 'get_preferred_languages':\n>> http.c:1021:2: warning: implicit declaration of function 'setlocale'\n>> [-Wimplicit-function-declaration]\n>>   retval = setlocale(LC_MESSAGES, NULL);\n>>   ^\n>> http.c:1021:21: error: 'LC_MESSAGES' undeclared (first use in this function)\n>>   retval = setlocale(LC_MESSAGES, NULL);\n>>                      ^\n>> http.c:1021:21: note: each undeclared identifier is reported only once\n>> for each function it appears in\n>> make: *** [http.o] Error 1\n\n\nOn Thu, Feb 26, 2015 at 12:52 PM, Stefan Beller <sbeller@google.com> wrote:\n> Removing config.mak makes it compile again.\n> config.mak contained:\n> CFLAGS += -Wall -g -rdynamic -O0\n> # CFLAGS += -Wextra\n> # CFLAGS += -Werror\n> CFLAGS += -Wno-format-zero-length\n> CFLAGS += -Wdeclaration-after-statement\n> CFLAGS += -Wpointer-arith\n> CFLAGS += -Wstrict-prototypes\n> CFLAGS += -Wold-style-declaration\n> # CFLAGS += -flto\n> # CFLAGS += -fwhole-program\n> CC = /usr/lib/gcc-snapshot/bin/gcc\n>\n> Mind that compiling did work with this exact version of\n> config.mak, (I did not touch it for a few weeks now),\n> so I suspect new changes in changes to break the\n> compilation.\n>\n>\n\n\n\"git bisect run make\" shows\nf18604bbf2c391c689a41fca14cbaeff5e106255 is the first bad commit\ncommit f18604bbf2c391c689a41fca14cbaeff5e106255\nAuthor: Yi EungJun <eungjun.yi@navercorp.com>\nDate:   Wed Jan 28 21:04:37 2015 +0900\n\nIs there an easy way to fix it or is my config.mak bogus now?\n"},{"id":"256709","messageId":"20150226210048.GB13958@google.com","threadId":"38661","inReplyTo":"CAGZ79kaRJg1QzFSyj0iAtUn2nUFxzZRy7BsrYC2++kaN0RD1Aw@mail.gmail.com","subject":"Re: compiling master fails","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2015-02-26T21:00:48Z","receivedAt":"2015-02-26T21:00:48Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi,\n\nStefan Beller wrote:\n\n> On Post 2.3 cyle (batch #5) (v2.3.1-167-g7f4ba4b)\n>\n>     CC http.o\n> http.c: In function 'get_preferred_languages':\n> http.c:1021:2: warning: implicit declaration of function 'setlocale'\n> [-Wimplicit-function-declaration]\n>   retval = setlocale(LC_MESSAGES, NULL);\n>   ^\n\nSee http://thread.gmane.org/gmane.comp.version-control.git/253901/focus=264421\n\nThanks for reporting,\nJonathan\n"}]}