{"thread":{"id":"38619","subject":"[PATCH v2 2/3] t5601: add more test cases for IPV6","startedAt":"2015-02-21T15:53:01Z","lastAt":"2015-02-23T05:36:40Z","messageCount":3,"participants":["Torsten Bögershausen","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":3},"messages":[{"id":"256469","messageId":"54E8A9DD.7090908@web.de","threadId":"38619","inReplyTo":null,"subject":"[PATCH v2 2/3] t5601: add more test cases for IPV6","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2015-02-21T15:53:01Z","receivedAt":"2015-02-21T15:53:01Z","isPatch":true,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"Test the parsing of literall IPV6 addresses more systematically:\n- with and without brackets (e.g. ::1 [::1])\n- with brackets and port number: (e.g. [::1]:22)\n- with username (e.g. user@::1)\n- with username and brackets:\n  Because user@[::1] was not supported on older Git version,\n  [user@::1] had to be used as a workaround.\n  Test that user@::1 user@[::1] and [user@::1] all do the same.\n\nSigned-off-by: Torsten Bögershausen <tboegi@web.de>\n---\n t/t5601-clone.sh | 57 +++++++++++++++++++++++++++++++++++++++-----------------\n 1 file changed, 40 insertions(+), 17 deletions(-)\n\ndiff --git a/t/t5601-clone.sh b/t/t5601-clone.sh\nindex f901b8a..02b40b1 100755\n--- a/t/t5601-clone.sh\n+++ b/t/t5601-clone.sh\n@@ -301,11 +301,17 @@ expect_ssh () {\n \t\t(cd \"$TRASH_DIRECTORY\" && rm -f ssh-expect && >ssh-output)\n \t' &&\n \t{\n-\t\tcase \"$1\" in\n-\t\tnone)\n+\t\tcase \"$#\" in\n+\t\t1)\n \t\t\t;;\n-\t\t*)\n+\t\t2)\n \t\t\techo \"ssh: $1 git-upload-pack '$2'\"\n+\t\t\t;;\n+\t\t3)\n+\t\t\techo \"ssh: $1 $2 git-upload-pack '$3'\"\n+\t\t\t;;\n+\t\t*)\n+\t\t\techo \"ssh: $1 $2 git-upload-pack '$3' $4\"\n \t\tesac\n \t} >\"$TRASH_DIRECTORY/ssh-expect\" &&\n \t(cd \"$TRASH_DIRECTORY\" && test_cmp ssh-expect ssh-output)\n@@ -336,7 +342,8 @@ counter=0\n test_clone_url () {\n \tcounter=$(($counter + 1))\n \ttest_might_fail git clone \"$1\" tmp$counter &&\n-\texpect_ssh \"$2\" \"$3\"\n+\tshift &&\n+\texpect_ssh \"$@\"\n }\n \n test_expect_success !MINGW 'clone c:temp is ssl' '\n@@ -359,7 +366,7 @@ done\n for repo in rep rep/home/project 123\n do\n \ttest_expect_success \"clone [::1]:$repo\" '\n-\t\ttest_clone_url [::1]:$repo ::1 $repo\n+\t\ttest_clone_url [::1]:$repo ::1 \"$repo\"\n \t'\n done\n #home directory\n@@ -400,24 +407,40 @@ test_expect_success 'clone ssh://host.xz:22/~repo' '\n '\n \n #IPv6\n-test_expect_success 'clone ssh://[::1]/home/user/repo' '\n-\ttest_clone_url \"ssh://[::1]/home/user/repo\" \"::1\" \"/home/user/repo\"\n-'\n+for tuah in ::1 [::1] user@::1 user@[::1] [user@::1]\n+do\n+\tehost=$(echo $tuah | tr -d \"[]\")\n+\ttest_expect_success \"clone ssh://$tuah/home/user/repo\" \"\n+\t  test_clone_url ssh://$tuah/home/user/repo $ehost /home/user/repo\n+\t\"\n+done\n \n #IPv6 from home directory\n-test_expect_success 'clone ssh://[::1]/~repo' '\n-\ttest_clone_url \"ssh://[::1]/~repo\" \"::1\" \"~repo\"\n-'\n+for tuah in ::1 [::1] user@::1 user@[::1] [user@::1]\n+do\n+\teuah=$(echo $tuah | tr -d \"[]\")\n+\ttest_expect_success \"clone ssh://$tuah/~repo\" \"\n+\t  test_clone_url ssh://$tuah/~repo $euah '~repo'\n+\t\"\n+done\n \n #IPv6 with port number\n-test_expect_success 'clone ssh://[::1]:22/home/user/repo' '\n-\ttest_clone_url \"ssh://[::1]:22/home/user/repo\" \"-p 22 ::1\" \"/home/user/repo\"\n-'\n+for tuah in [::1] user@[::1] [user@::1]\n+do\n+\teuah=$(echo $tuah | tr -d \"[]\")\n+\ttest_expect_success \"clone ssh://$tuah:22/home/user/repo\" \"\n+\t  test_clone_url ssh://$tuah:22/home/user/repo '-p 22' $euah /home/user/repo\n+\t\"\n+done\n \n #IPv6 from home directory with port number\n-test_expect_success 'clone ssh://[::1]:22/~repo' '\n-\ttest_clone_url \"ssh://[::1]:22/~repo\" \"-p 22 ::1\" \"~repo\"\n-'\n+for tuah in [::1] user@[::1] [user@::1]\n+do\n+\teuah=$(echo $tuah | tr -d \"[]\")\n+\ttest_expect_success \"clone ssh://$tuah:22/~repo\" \"\n+\t  test_clone_url ssh://$tuah:22/~repo '-p 22' $euah '~repo'\n+\t\"\n+done\n \n test_expect_success 'clone from a repository with two identical branches' '\n \n-- \n2.2.0.rc1.790.ge19fcd2\n"},{"id":"256494","messageId":"xmqq61atuysn.fsf@gitster.dls.corp.google.com","threadId":"38619","inReplyTo":"54E8A9DD.7090908@web.de","subject":"Re: [PATCH v2 2/3] t5601: add more test cases for IPV6","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-02-23T02:50:00Z","receivedAt":"2015-02-23T02:50:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Torsten Bögershausen <tboegi@web.de> writes:\n\n> @@ -359,7 +366,7 @@ done\n>  for repo in rep rep/home/project 123\n>  do\n>  \ttest_expect_success \"clone [::1]:$repo\" '\n> -\t\ttest_clone_url [::1]:$repo ::1 $repo\n> +\t\ttest_clone_url [::1]:$repo ::1 \"$repo\"\n>  \t'\n>  done\n\nThis change is somewhat a curious one.  Why quote the last\noccurrence of $repo but not the previous one?\n\n> +for tuah in ::1 [::1] user@::1 user@[::1] [user@::1]\n> +do\n> +\teuah=$(echo $tuah | tr -d \"[]\")\n\nWhat are tuah and euah, by the way?  Are they FLA for some phrases?\n"},{"id":"256496","messageId":"54EABC68.40308@web.de","threadId":"38619","inReplyTo":"xmqq61atuysn.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH v2 2/3] t5601: add more test cases for IPV6","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2015-02-23T05:36:40Z","receivedAt":"2015-02-23T05:36:40Z","isPatch":true,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"On 02/23/2015 03:50 AM, Junio C Hamano wrote:\n> Torsten Bögershausen <tboegi@web.de> writes:\n>\n>> @@ -359,7 +366,7 @@ done\n>>   for repo in rep rep/home/project 123\n>>   do\n>>   \ttest_expect_success \"clone [::1]:$repo\" '\n>> -\t\ttest_clone_url [::1]:$repo ::1 $repo\n>> +\t\ttest_clone_url [::1]:$repo ::1 \"$repo\"\n>>   \t'\n>>   done\n> This change is somewhat a curious one.  Why quote the last\n> occurrence of $repo but not the previous one?\nThe reason to quote is that\nsome shells replace ~ with $HOME, but not \"~\"\nexactly here it seems not to be needed.\n>\n>> +for tuah in ::1 [::1] user@::1 user@[::1] [user@::1]\n>> +do\n>> +\teuah=$(echo $tuah | tr -d \"[]\")\n> What are tuah and euah, by the way?  Are they FLA for some phrases?\ntuah = tested username and host\neuah = expected username and host\n"}]}