{"thread":{"id":"38593","subject":"gitk drawing bug","startedAt":"2015-02-18T19:27:58Z","lastAt":"2015-04-06T03:11:35Z","messageCount":4,"participants":["Martin d'Anjou","Alex Henrie","Paul Mackerras"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"256306","messageId":"CACZ2eqdm_DXfa0o9J3NXfxD0XG-iAbPNUhySg026qhkqZAYWJA@mail.gmail.com","threadId":"38593","inReplyTo":null,"subject":"gitk drawing bug","fromName":"Martin d'Anjou","fromEmail":"martin.danjou14@gmail.com","sentAt":"2015-02-18T19:27:58Z","receivedAt":"2015-02-18T19:27:58Z","isPatch":false,"sender":{"key":"martin.danjou14@gmail.com","avatar":null},"body":"Hi,\n\nIt appears I have uncovered inconsistent behaviour in gitk. Looks like\na bug. I have a picture here:\nhttps://docs.google.com/document/d/19TTzGD94B9EEIrVU5mRMjfJFvF5Ar3MlPblRJfP5OdQ/edit?usp=sharing\n\nEssentially, when I hit shift-F5, it sometimes draw the history\ndifferently (still valid, but drawn differently). There is no change\nin the repository between the shift-F5 keystrokes.\n\nThanks,\nMartin\n"},{"id":"258963","messageId":"CAMMLpeQ3J_x5xee=V+Sn4=FTRNM-yQSm_yXSwFpiCNJz2AD7Gg@mail.gmail.com","threadId":"38593","inReplyTo":"CACZ2eqdm_DXfa0o9J3NXfxD0XG-iAbPNUhySg026qhkqZAYWJA@mail.gmail.com","subject":"Re: gitk drawing bug","fromName":"Alex Henrie","fromEmail":"alexhenrie24@gmail.com","sentAt":"2015-04-03T23:05:33Z","receivedAt":"2015-04-03T23:05:33Z","isPatch":false,"sender":{"key":"alexhenrie24@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5951993?v=4"},"body":"2015-02-18 12:27 GMT-07:00 Martin d'Anjou :\n> It appears I have uncovered inconsistent behaviour in gitk. Looks like\n> a bug. I have a picture here:\n> https://docs.google.com/document/d/19TTzGD94B9EEIrVU5mRMjfJFvF5Ar3MlPblRJfP5OdQ/edit?usp=sharing\n>\n> Essentially, when I hit shift-F5, it sometimes draw the history\n> differently (still valid, but drawn differently). There is no change\n> in the repository between the shift-F5 keystrokes.\n\nDid you ever contact the gitk maintainer, Paul Mackerras\n, about this bug?\n\n-Alex\n"},{"id":"258973","messageId":"551F3E20.5010306@gmail.com","threadId":"38593","inReplyTo":"CAMMLpeQ3J_x5xee=V+Sn4=FTRNM-yQSm_yXSwFpiCNJz2AD7Gg@mail.gmail.com","subject":"Re: gitk drawing bug","fromName":"Martin d'Anjou","fromEmail":"martin.danjou14@gmail.com","sentAt":"2015-04-04T01:28:00Z","receivedAt":"2015-04-04T01:28:00Z","isPatch":false,"sender":{"key":"martin.danjou14@gmail.com","avatar":null},"body":"On 15-04-03 07:05 PM, Alex Henrie wrote:\n> 2015-02-18 12:27 GMT-07:00 Martin d'Anjou :\n>> It appears I have uncovered inconsistent behaviour in gitk. Looks like\n>> a bug. I have a picture here:\n>> https://docs.google.com/document/d/19TTzGD94B9EEIrVU5mRMjfJFvF5Ar3MlPblRJfP5OdQ/edit?usp=sharing\n>>\n>> Essentially, when I hit shift-F5, it sometimes draw the history\n>> differently (still valid, but drawn differently). There is no change\n>> in the repository between the shift-F5 keystrokes.\n> Did you ever contact the gitk maintainer, Paul Mackerras\n> , about this bug?\n>\n> -Alex\nI do not remember contacting Paul Mackerras, but thank you for doing so.\n\nMartin\n"},{"id":"259044","messageId":"20150406031134.GA26765@iris.ozlabs.ibm.com","threadId":"38593","inReplyTo":"551F3E20.5010306@gmail.com","subject":"Re: gitk drawing bug","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2015-04-06T03:11:35Z","receivedAt":"2015-04-06T03:11:35Z","isPatch":false,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"On Fri, Apr 03, 2015 at 09:28:00PM -0400, Martin d'Anjou wrote:\n> On 15-04-03 07:05 PM, Alex Henrie wrote:\n> >2015-02-18 12:27 GMT-07:00 Martin d'Anjou :\n> >>It appears I have uncovered inconsistent behaviour in gitk. Looks like\n> >>a bug. I have a picture here:\n> >>https://docs.google.com/document/d/19TTzGD94B9EEIrVU5mRMjfJFvF5Ar3MlPblRJfP5OdQ/edit?usp=sharing\n> >>\n> >>Essentially, when I hit shift-F5, it sometimes draw the history\n> >>differently (still valid, but drawn differently). There is no change\n> >>in the repository between the shift-F5 keystrokes.\n\nThat's not a bug, it's a consequence of the fact that gitk is designed\nto be fast. It only lays out as much of the graph is visible plus a\nlittle more, not the whole graph, and it doesn't use any global\nanalysis. The reason for that is speed. Gitk is usable on a\nrepository with half a million commits, such as the linux kernel, and\nto achieve that we can't afford to do wait until we have all the\ncommits read in and then do some computation over the whole topology;\nit all has to be done incrementally. Also, the underlying git log\nsometimes gives gitk a parent commit before one of its children, and\nwhen that happens the topology has to be modified and thus the graph\ndoes too, if any topology that has already been drawn gets modified.\n\nAs long as the graph correctly shows the relationships between\ncommits, it has achieved its purpose. If you (or anyone) can come up\nwith improvements that make it look nicer, that's great, and I'll\nconsider them as long as they don't slow down gitk on large\nrepositories to any noticeable extent.\n\nPaul.\n"}]}