{"thread":{"id":"3850","subject":"t5501-old-fetch-and-upload.sh fails with NO_PYTHON=1","startedAt":"2006-04-11T17:05:08Z","lastAt":"2006-04-11T21:31:42Z","messageCount":3,"participants":["Dennis Stosberg","Junio C Hamano","Johannes Schindelin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"18565","messageId":"20060411170508.G14ba7e47@leonov.stosberg.net","threadId":"3850","inReplyTo":null,"subject":"t5501-old-fetch-and-upload.sh fails with NO_PYTHON=1","fromName":"Dennis Stosberg","fromEmail":"dennis@stosberg.net","sentAt":"2006-04-11T17:05:08Z","receivedAt":"2006-04-11T17:05:08Z","isPatch":false,"sender":{"key":"dennis@stosberg.net","avatar":null},"body":"Hello,\n\nt/t5501-old-fetch-and-upload.sh fails on Solaris 9 with NO_PYTHON=1.\nThe test doesn't work correctly on Linux with NO_PYTHON=1, too, but it\ndoesn't cause a failure there.\n\nWhen NO_PYTHON=1 is set, t/Makefile passes \"--no-python\" to the test as\nan argument.  That causes the $list variable to be set to \"--no-python\"\ninstead of \"fetch upload\".  Since that string does not identify a\nprogram to be tested, $pgm remains unset.\n\nOn Linux the return code of \"which $pgm\" is 1 in that case, which\ncauses the test to do nothing and exit without failure.  In contrast,\nthe return code of \"which\" without any argument is 0 on Solaris, so\nthe test is being run and fails.\n\nI have attached a simple fix, but is this test still useful at all?\n\nRegards,\nDennis\n\ndiff --git a/t/t5501-old-fetch-and-upload.sh b/t/t5501-old-fetch-and-upload.sh\nindex 596c88b..df69d97 100755\n--- a/t/t5501-old-fetch-and-upload.sh\n+++ b/t/t5501-old-fetch-and-upload.sh\n@@ -13,10 +13,11 @@ tmp=`pwd`/.tmp$$\n \n retval=0\n \n-if [ -z \"$1\" ]; then\n+tests=`echo \"$@\"| sed -e 's/--[a-zA-Z\\-]*//g'`\n+if [ -z \"$tests\" ]; then\n \tlist=\"fetch upload\"\n else\n-\tlist=\"$@\"\n+\tlist=\"$tests\"\n fi\n \n for i in $list; do\n"},{"id":"18567","messageId":"7vlkuc56m9.fsf@assigned-by-dhcp.cox.net","threadId":"3850","inReplyTo":"20060411170508.G14ba7e47@leonov.stosberg.net","subject":"Re: t5501-old-fetch-and-upload.sh fails with NO_PYTHON=1","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-04-11T18:06:54Z","receivedAt":"2006-04-11T18:06:54Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Dennis Stosberg <dennis@stosberg.net> writes:\n\n> I have attached a simple fix, but is this test still useful at all?\n\nThanks.  I am inclined to say that when we need the \"make sure\nthis updated send-pack works with older receive-pack and vice\nversa\" tests the next time, the framework to call the\ncounterpart program from different vintage might be reusable but\nwhat the test tries to test would be different, so keeping this\nparticular test would be somewhat useful as reference and\nperhaps a starting point for such new test, but otherwise not\nvery much.  And for that kind of usage, \"the Net never forgets\".\n\nI'd vote for its removal.  Thoughts?\n"},{"id":"18570","messageId":"Pine.LNX.4.63.0604112329030.26779@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"3850","inReplyTo":"7vlkuc56m9.fsf@assigned-by-dhcp.cox.net","subject":"Re: t5501-old-fetch-and-upload.sh fails with NO_PYTHON=1","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-04-11T21:31:42Z","receivedAt":"2006-04-11T21:31:42Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 11 Apr 2006, Junio C Hamano wrote:\n\n> [...] so keeping this particular test would be somewhat useful as \n> reference and perhaps a starting point for such new test, but otherwise \n> not very much.  And for that kind of usage, \"the Net never forgets\".\n\nNot only that. Git itself never forgets. \"git-cat-file blob 596c88b\" will \nprobably work virtually forever.\n\n> I'd vote for its removal.  Thoughts?\n\nYeah.\n\nCiao,\nDscho\n"}]}