{"thread":{"id":"38465","subject":"[PATCH] Correction to git-p4 \"exclude\" change","startedAt":"2015-01-28T06:08:03Z","lastAt":"2015-02-05T19:05:28Z","messageCount":5,"participants":["Luke Diamand","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"255357","messageId":"1422425284-5282-1-git-send-email-luke@diamand.org","threadId":"38465","inReplyTo":null,"subject":"[PATCH] Correction to git-p4 \"exclude\" change","fromName":"Luke Diamand","fromEmail":"luke@diamand.org","sentAt":"2015-01-28T06:08:03Z","receivedAt":"2015-01-28T06:08:03Z","isPatch":true,"sender":{"key":"luke@diamand.org","avatar":"https://avatars.githubusercontent.com/u/5330967?v=4"},"body":"My previous change for adding support for \"exclude\" to git-p4 \"sync\"\nwas incorrect, missing out a comma, which stopped git-p4 from working.\nThis change fixes that.\n\nI've also noticed that t9814-git-p4-rename.sh has stopped working; I'm\ngoing to follow up with a fix for that once I've worked out what's\nwrong with it. There's a small shell syntax problem (missing \"esac\")\nbut after fixing that it still fails, so I'm not sure what's happening\nyet. It was discussed a while back.\n\nLuke Diamand (1):\n git-p4: correct \"exclude\" change\n\n git-p4.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n-- \n2.3.0.rc2.188.g4b64765.dirty\n"},{"id":"255358","messageId":"1422425284-5282-2-git-send-email-luke@diamand.org","threadId":"38465","inReplyTo":"1422425284-5282-1-git-send-email-luke@diamand.org","subject":"[PATCH] git-p4: correct \"exclude\" change","fromName":"Luke Diamand","fromEmail":"luke@diamand.org","sentAt":"2015-01-28T06:08:04Z","receivedAt":"2015-01-28T06:08:04Z","isPatch":true,"sender":{"key":"luke@diamand.org","avatar":"https://avatars.githubusercontent.com/u/5330967?v=4"},"body":"The previous change for excluding paths in the \"sync\"\nsubcommand was incorrect, missing a comma, preventing\ngit-p4 from working.\n\nSigned-off-by: Luke Diamand \n---\n git-p4.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/git-p4.py b/git-p4.py\nindex 6ff0b76..549022e 100755\n--- a/git-p4.py\n+++ b/git-p4.py\n@@ -1915,7 +1915,7 @@ class P4Sync(Command, P4UserMap):\n optparse.make_option(\"--keep-path\", dest=\"keepRepoPath\", action='store_true',\n help=\"Keep entire BRANCH/DIR/SUBDIR prefix during import\"),\n optparse.make_option(\"--use-client-spec\", dest=\"useClientSpec\", action='store_true',\n- help=\"Only sync files that are included in the Perforce Client Spec\")\n+ help=\"Only sync files that are included in the Perforce Client Spec\"),\n optparse.make_option(\"-/\", dest=\"cloneExclude\",\n action=\"append\", type=\"string\",\n help=\"exclude depot path\"),\n-- \n2.3.0.rc2.188.g4b64765.dirty\n"},{"id":"255375","messageId":"xmqqwq46fx59.fsf@gitster.dls.corp.google.com","threadId":"38465","inReplyTo":"1422425284-5282-1-git-send-email-luke@diamand.org","subject":"Re: [PATCH] Correction to git-p4 \"exclude\" change","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-01-28T20:49:54Z","receivedAt":"2015-01-28T20:49:54Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Luke Diamand writes:\n\n> My previous change for adding support for \"exclude\" to git-p4 \"sync\"\n> was incorrect, missing out a comma, which stopped git-p4 from working.\n> This change fixes that.\n>\n> I've also noticed that t9814-git-p4-rename.sh has stopped working; I'm\n> going to follow up with a fix for that once I've worked out what's\n> wrong with it. There's a small shell syntax problem (missing \"esac\")\n> but after fixing that it still fails, so I'm not sure what's happening\n> yet. It was discussed a while back.\n>\n> Luke Diamand (1):\n> git-p4: correct \"exclude\" change\n>\n> git-p4.py | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n\nThanks.\n\nWill keep out of 'master' for now. It may not be a bad idea to\nsquash this fix (and any futher ones if needed) into a single patch\nwhen we rewind 'next' after 2.3 final is tagged.\n"},{"id":"255620","messageId":"CAE5ih7-Eo9uNCRQHO8bOGCuE0w8U_S4q+aYTNfttSHLQM6GVpA@mail.gmail.com","threadId":"38465","inReplyTo":"CAE5ih7_TJOQ=ttw03V3J9A=jtwUD-Emy-mSp0kNrYKkqMs30ng@mail.gmail.com","subject":"Re: [PATCH] Correction to git-p4 \"exclude\" change","fromName":"Luke Diamand","fromEmail":"luke@diamand.org","sentAt":"2015-02-05T08:24:12Z","receivedAt":"2015-02-05T08:24:12Z","isPatch":true,"sender":{"key":"luke@diamand.org","avatar":"https://avatars.githubusercontent.com/u/5330967?v=4"},"body":"(Resending as plain text).\n\nI could be wrong about this, but my correction above doesn't seem to\nbe in 'next'. Does that mean (reading your last \"what's cooking\") that\nthe broken version is going to go out to 'master' soon?\n\nThanks,\nLuke\n\nOn 5 February 2015 at 08:19, Luke Diamand wrote:\n> I could be wrong about this, but my correction above doesn't seem to be in\n> 'next'. Does that mean (reading your last \"what's cooking\") that the broken\n> version is going to go out to 'master' soon?\n>\n> Thanks,\n> Luke\n>\n>\n> On 28 January 2015 at 20:49, Junio C Hamano wrote:\n>>\n>> Luke Diamand writes:\n>>\n>> > My previous change for adding support for \"exclude\" to git-p4 \"sync\"\n>> > was incorrect, missing out a comma, which stopped git-p4 from working.\n>> > This change fixes that.\n>> >\n>> > I've also noticed that t9814-git-p4-rename.sh has stopped working; I'm\n>> > going to follow up with a fix for that once I've worked out what's\n>> > wrong with it. There's a small shell syntax problem (missing \"esac\")\n>> > but after fixing that it still fails, so I'm not sure what's happening\n>> > yet. It was discussed a while back.\n>> >\n>> > Luke Diamand (1):\n>> > git-p4: correct \"exclude\" change\n>> >\n>> > git-p4.py | 2 +-\n>> > 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> Thanks.\n>>\n>> Will keep out of 'master' for now. It may not be a bad idea to\n>> squash this fix (and any futher ones if needed) into a single patch\n>> when we rewind 'next' after 2.3 final is tagged.\n>>\n>\n"},{"id":"255637","messageId":"xmqq1tm4mb5z.fsf@gitster.dls.corp.google.com","threadId":"38465","inReplyTo":"CAE5ih7-Eo9uNCRQHO8bOGCuE0w8U_S4q+aYTNfttSHLQM6GVpA@mail.gmail.com","subject":"Re: [PATCH] Correction to git-p4 \"exclude\" change","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-02-05T19:05:28Z","receivedAt":"2015-02-05T19:05:28Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Luke Diamand writes:\n\n> (Resending as plain text).\n>\n> I could be wrong about this, but my correction above doesn't seem to\n> be in 'next'. Does that mean (reading your last \"what's cooking\") that\n> the broken version is going to go out to 'master' soon?\n\nThe current copy of \"What's cooking\" I have reads like so:\n\n * ld/p4-exclude-in-sync (2015-01-28) 2 commits\n - git-p4: correct \"exclude\" change\n (merged to 'next' on 2015-01-22 at f6f1fc7)\n + git-p4: support excluding paths on sync\n\n Will squash into one after 2.3 final.\n\nAs we are too late to merge anything new to 'master', and the broken\none is not in 'master', I have been playing lazy to make time to\ntend to other issues ;-) After 2.3 final, we would rewind the tip\nof 'next' and will rebuild, and when that happens, I am hoping that\nwe can make these two into one commit that does not have the \"oops,\nI forgot a comma and broke the entire command\" fix-up as a separate\ncommit.\n\nOr did I mis-read you? Do we have broken code already in 'master'\nthat this hot-fix needs to be applied to unbreak?\n"}]}