{"thread":{"id":"38454","subject":"[PATCH] git-gui: sort entries in tclIndex","startedAt":"2015-01-26T17:07:23Z","lastAt":"2015-10-05T07:43:32Z","messageCount":6,"participants":["Olaf Hering","René Scharfe","Pat Thoyts"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"255296","messageId":"1422292043-12711-1-git-send-email-olaf@aepfle.de","threadId":"38454","inReplyTo":null,"subject":"[PATCH] git-gui: sort entries in tclIndex","fromName":"Olaf Hering","fromEmail":"olaf@aepfle.de","sentAt":"2015-01-26T17:07:23Z","receivedAt":"2015-01-26T17:07:23Z","isPatch":true,"sender":{"key":"olaf@aepfle.de","avatar":"https://avatars.githubusercontent.com/u/942324?v=4"},"body":"ALL_LIBFILES uses wildcard, which provides the result in directory\norder. This order depends on the underlying filesystem on the\nbuildhost. To get reproducible builds it is required to sort such list\nbefore using them.\n\nSigned-off-by: Olaf Hering <olaf@aepfle.de>\n---\n git-gui/Makefile | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/git-gui/Makefile b/git-gui/Makefile\nindex cde8b2e..7564a18 100644\n--- a/git-gui/Makefile\n+++ b/git-gui/Makefile\n@@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS\n \t rm -f $@ ; \\\n \t echo '# Autogenerated by git-gui Makefile' >$@ && \\\n \t echo >>$@ && \\\n-\t $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' >>$@ &&) \\\n+\t $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' >>$@ &&) \\\n \t echo >>$@ ; \\\n \tfi\n \n"},{"id":"255884","messageId":"20150210151803.GB8965@aepfle.de","threadId":"38454","inReplyTo":"1422292043-12711-1-git-send-email-olaf@aepfle.de","subject":"Re: [PATCH] git-gui: sort entries in tclIndex","fromName":"Olaf Hering","fromEmail":"olaf@aepfle.de","sentAt":"2015-02-10T15:18:03Z","receivedAt":"2015-02-10T15:18:03Z","isPatch":true,"sender":{"key":"olaf@aepfle.de","avatar":"https://avatars.githubusercontent.com/u/942324?v=4"},"body":"Ping?\n\nOn Mon, Jan 26, Olaf Hering wrote:\n\n> ALL_LIBFILES uses wildcard, which provides the result in directory\n> order. This order depends on the underlying filesystem on the\n> buildhost. To get reproducible builds it is required to sort such list\n> before using them.\n> \n> Signed-off-by: Olaf Hering <olaf@aepfle.de>\n> ---\n>  git-gui/Makefile | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/git-gui/Makefile b/git-gui/Makefile\n> index cde8b2e..7564a18 100644\n> --- a/git-gui/Makefile\n> +++ b/git-gui/Makefile\n> @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS\n>  \t rm -f $@ ; \\\n>  \t echo '# Autogenerated by git-gui Makefile' >$@ && \\\n>  \t echo >>$@ && \\\n> -\t $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' >>$@ &&) \\\n> +\t $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' >>$@ &&) \\\n>  \t echo >>$@ ; \\\n>  \tfi\n>  \n"},{"id":"259396","messageId":"20150415072251.GA18595@aepfle.de","threadId":"38454","inReplyTo":"20150210151803.GB8965@aepfle.de","subject":"Re: [PATCH] git-gui: sort entries in tclIndex","fromName":"Olaf Hering","fromEmail":"olaf@aepfle.de","sentAt":"2015-04-15T07:22:51Z","receivedAt":"2015-04-15T07:22:51Z","isPatch":true,"sender":{"key":"olaf@aepfle.de","avatar":"https://avatars.githubusercontent.com/u/942324?v=4"},"body":"Ping?\n\nOn Tue, Feb 10, Olaf Hering wrote:\n\n> Ping?\n> \n> On Mon, Jan 26, Olaf Hering wrote:\n> \n> > ALL_LIBFILES uses wildcard, which provides the result in directory\n> > order. This order depends on the underlying filesystem on the\n> > buildhost. To get reproducible builds it is required to sort such list\n> > before using them.\n> > \n> > Signed-off-by: Olaf Hering <olaf@aepfle.de>\n> > ---\n> >  git-gui/Makefile | 2 +-\n> >  1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/git-gui/Makefile b/git-gui/Makefile\n> > index cde8b2e..7564a18 100644\n> > --- a/git-gui/Makefile\n> > +++ b/git-gui/Makefile\n> > @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS\n> >  \t rm -f $@ ; \\\n> >  \t echo '# Autogenerated by git-gui Makefile' >$@ && \\\n> >  \t echo >>$@ && \\\n> > -\t $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' >>$@ &&) \\\n> > +\t $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' >>$@ &&) \\\n> >  \t echo >>$@ ; \\\n> >  \tfi\n> >  \n"},{"id":"259996","messageId":"553BC05F.1070702@web.de","threadId":"38454","inReplyTo":"20150415072251.GA18595@aepfle.de","subject":"Re: [PATCH] git-gui: sort entries in tclIndex","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2015-04-25T16:27:11Z","receivedAt":"2015-04-25T16:27:11Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Looping in Pat (git-gui maintainer).\n\nAm 15.04.2015 um 09:22 schrieb Olaf Hering:\n> Ping?\n>\n> On Tue, Feb 10, Olaf Hering wrote:\n>\n>> Ping?\n>>\n>> On Mon, Jan 26, Olaf Hering wrote:\n>>\n>>> ALL_LIBFILES uses wildcard, which provides the result in directory\n>>> order. This order depends on the underlying filesystem on the\n>>> buildhost. To get reproducible builds it is required to sort such list\n>>> before using them.\n>>>\n>>> Signed-off-by: Olaf Hering <olaf@aepfle.de>\n>>> ---\n>>>   git-gui/Makefile | 2 +-\n>>>   1 file changed, 1 insertion(+), 1 deletion(-)\n>>>\n>>> diff --git a/git-gui/Makefile b/git-gui/Makefile\n>>> index cde8b2e..7564a18 100644\n>>> --- a/git-gui/Makefile\n>>> +++ b/git-gui/Makefile\n>>> @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS\n>>>   \t rm -f $@ ; \\\n>>>   \t echo '# Autogenerated by git-gui Makefile' >$@ && \\\n>>>   \t echo >>$@ && \\\n>>> -\t $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' >>$@ &&) \\\n>>> +\t $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' >>$@ &&) \\\n>>>   \t echo >>$@ ; \\\n>>>   \tfi\n>>>\n"},{"id":"260338","messageId":"87sibgpcpp.fsf@red.patthoyts.tk","threadId":"38454","inReplyTo":"553BC05F.1070702@web.de","subject":"Re: [PATCH] git-gui: sort entries in tclIndex","fromName":"Pat Thoyts","fromEmail":"patthoyts@users.sourceforge.net","sentAt":"2015-05-01T14:57:38Z","receivedAt":"2015-05-01T14:57:38Z","isPatch":true,"sender":{"key":"patthoyts@users.sourceforge.net","avatar":"https://avatars.githubusercontent.com/u/30739?v=4"},"body":"René Scharfe <l.s.r@web.de> writes:\n\n>Looping in Pat (git-gui maintainer).\n>\n>Am 15.04.2015 um 09:22 schrieb Olaf Hering:\n>> Ping?\n>>\n>> On Tue, Feb 10, Olaf Hering wrote:\n>>\n>>> Ping?\n>>>\n>>> On Mon, Jan 26, Olaf Hering wrote:\n>>>\n>>>> ALL_LIBFILES uses wildcard, which provides the result in directory\n>>>> order. This order depends on the underlying filesystem on the\n>>>> buildhost. To get reproducible builds it is required to sort such list\n>>>> before using them.\n>>>>\n>>>> Signed-off-by: Olaf Hering <olaf@aepfle.de>\n>>>> ---\n>>>>   git-gui/Makefile | 2 +-\n>>>>   1 file changed, 1 insertion(+), 1 deletion(-)\n>>>>\n>>>> diff --git a/git-gui/Makefile b/git-gui/Makefile\n>>>> index cde8b2e..7564a18 100644\n>>>> --- a/git-gui/Makefile\n>>>> +++ b/git-gui/Makefile\n>>>> @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS\n>>>>   \t rm -f $@ ; \\\n>>>>   \t echo '# Autogenerated by git-gui Makefile' >$@ && \\\n>>>>   \t echo >>$@ && \\\n>>>> -\t $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' >>$@ &&) \\\n>>>> +\t $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' >>$@ &&) \\\n>>>>   \t echo >>$@ ; \\\n>>>>   \tfi\n>>>>\n>\n\nApplied. Thank you.\n\n-- \nPat Thoyts                            http://www.patthoyts.tk/\nPGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD\n"},{"id":"271126","messageId":"20151005074332.GA21840@aepfle.de","threadId":"38454","inReplyTo":"87sibgpcpp.fsf@red.patthoyts.tk","subject":"Re: [PATCH] git-gui: sort entries in tclIndex","fromName":"Olaf Hering","fromEmail":"olaf@aepfle.de","sentAt":"2015-10-05T07:43:32Z","receivedAt":"2015-10-05T07:43:32Z","isPatch":true,"sender":{"key":"olaf@aepfle.de","avatar":"https://avatars.githubusercontent.com/u/942324?v=4"},"body":"To which branch was this applied?\nIts still broken in git-2.6.0.\n\nOlaf\n\nOn Fri, May 01, Pat Thoyts wrote:\n\n> René Scharfe <l.s.r@web.de> writes:\n> \n> >Looping in Pat (git-gui maintainer).\n> >\n> >Am 15.04.2015 um 09:22 schrieb Olaf Hering:\n> >> Ping?\n> >>\n> >> On Tue, Feb 10, Olaf Hering wrote:\n> >>\n> >>> Ping?\n> >>>\n> >>> On Mon, Jan 26, Olaf Hering wrote:\n> >>>\n> >>>> ALL_LIBFILES uses wildcard, which provides the result in directory\n> >>>> order. This order depends on the underlying filesystem on the\n> >>>> buildhost. To get reproducible builds it is required to sort such list\n> >>>> before using them.\n> >>>>\n> >>>> Signed-off-by: Olaf Hering <olaf@aepfle.de>\n> >>>> ---\n> >>>>   git-gui/Makefile | 2 +-\n> >>>>   1 file changed, 1 insertion(+), 1 deletion(-)\n> >>>>\n> >>>> diff --git a/git-gui/Makefile b/git-gui/Makefile\n> >>>> index cde8b2e..7564a18 100644\n> >>>> --- a/git-gui/Makefile\n> >>>> +++ b/git-gui/Makefile\n> >>>> @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS\n> >>>>   \t rm -f $@ ; \\\n> >>>>   \t echo '# Autogenerated by git-gui Makefile' >$@ && \\\n> >>>>   \t echo >>$@ && \\\n> >>>> -\t $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' >>$@ &&) \\\n> >>>> +\t $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' >>$@ &&) \\\n> >>>>   \t echo >>$@ ; \\\n> >>>>   \tfi\n> >>>>\n> >\n> \n> Applied. Thank you.\n"}]}