{"thread":{"id":"38441","subject":"[PATCH 0/7] Coding style fixes.","startedAt":"2015-01-23T11:06:48Z","lastAt":"2015-01-23T18:36:33Z","messageCount":11,"participants":["Alexander Kuleshov","Torsten Bögershausen","Stefan Beller"],"isPatch":true,"patchVersion":1,"patchTotal":7},"messages":[{"id":"255168","messageId":"1422011208-3832-1-git-send-email-kuleshovmail@gmail.com","threadId":"38441","inReplyTo":null,"subject":"[PATCH 0/7] Coding style fixes.","fromName":"Alexander Kuleshov","fromEmail":"kuleshovmail@gmail.com","sentAt":"2015-01-23T11:06:48Z","receivedAt":"2015-01-23T11:06:48Z","isPatch":true,"sender":{"key":"kuleshovmail@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2699235?v=4"},"body":"This patch set contatins minor style fixes. CodingGuidelines contains\nrule that the star must side with variable name.\n\nAlexander Kuleshov (7):\n show-branch: minor style fix\n clone: minor style fix\n test-hashmap: minor style fix\n http-backend: minor style fix\n refs: minor style fix\n quote: minor style fix\n fast-import: minor style fix\n\n builtin/clone.c | 2 +-\n builtin/show-branch.c | 2 +-\n fast-import.c | 2 +-\n http-backend.c | 2 +-\n quote.c | 2 +-\n refs.h | 2 +-\n test-hashmap.c | 4 ++--\n 7 files changed, 8 insertions(+), 8 deletions(-)\n\n--\n2.3.0.rc1.275.g028c360\n"},{"id":"255169","messageId":"1422011244-3900-1-git-send-email-kuleshovmail@gmail.com","threadId":"38441","inReplyTo":"1422011208-3832-1-git-send-email-kuleshovmail@gmail.com","subject":"[PATCH 1/7] show-branch: minor style fix","fromName":"Alexander Kuleshov","fromEmail":"kuleshovmail@gmail.com","sentAt":"2015-01-23T11:07:24Z","receivedAt":"2015-01-23T11:07:24Z","isPatch":true,"sender":{"key":"kuleshovmail@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2699235?v=4"},"body":"Asterisk must be next with variable\n\nSigned-off-by: Alexander Kuleshov \n---\n builtin/show-branch.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/show-branch.c b/builtin/show-branch.c\nindex 3a7ec55..e7684c8 100644\n--- a/builtin/show-branch.c\n+++ b/builtin/show-branch.c\n@@ -6,7 +6,7 @@\n #include \"parse-options.h\"\n #include \"commit-slab.h\"\n\n-static const char* show_branch_usage[] = {\n+static const char *show_branch_usage[] = {\n N_(\"git show-branch [-a | --all] [-r | --remotes] [--topo-order | --date-order]\\n\"\n \"\t\t[--current] [--color[=] | --no-color] [--sparse]\\n\"\n \"\t\t[--more= | --list | --independent | --merge-base]\\n\"\n--\n2.3.0.rc1.275.g028c360\n"},{"id":"255173","messageId":"1422011280-4007-1-git-send-email-kuleshovmail@gmail.com","threadId":"38441","inReplyTo":"1422011208-3832-1-git-send-email-kuleshovmail@gmail.com","subject":"[PATCH 2/7] clone: minor style fix","fromName":"Alexander Kuleshov","fromEmail":"kuleshovmail@gmail.com","sentAt":"2015-01-23T11:08:00Z","receivedAt":"2015-01-23T11:08:00Z","isPatch":true,"sender":{"key":"kuleshovmail@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2699235?v=4"},"body":"Asterisk must be next with variable\n\nSigned-off-by: Alexander Kuleshov \n---\n builtin/clone.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/clone.c b/builtin/clone.c\nindex d262a4d..a1ca780 100644\n--- a/builtin/clone.c\n+++ b/builtin/clone.c\n@@ -741,7 +741,7 @@ static void write_refspec_config(const char *src_ref_prefix,\n\n static void dissociate_from_references(void)\n {\n-\tstatic const char* argv[] = { \"repack\", \"-a\", \"-d\", NULL };\n+\tstatic const char *argv[] = { \"repack\", \"-a\", \"-d\", NULL };\n\n \tif (run_command_v_opt(argv, RUN_GIT_CMD|RUN_COMMAND_NO_STDIN))\n \t\tdie(_(\"cannot repack to clean up\"));\n--\n2.3.0.rc1.275.g028c360\n"},{"id":"255170","messageId":"1422011288-4062-1-git-send-email-kuleshovmail@gmail.com","threadId":"38441","inReplyTo":"1422011208-3832-1-git-send-email-kuleshovmail@gmail.com","subject":"[PATCH 3/7] test-hashmap: minor style fix","fromName":"Alexander Kuleshov","fromEmail":"kuleshovmail@gmail.com","sentAt":"2015-01-23T11:08:08Z","receivedAt":"2015-01-23T11:08:08Z","isPatch":true,"sender":{"key":"kuleshovmail@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2699235?v=4"},"body":"Asterisk must be next with variable\n\nSigned-off-by: Alexander Kuleshov \n---\n test-hashmap.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/test-hashmap.c b/test-hashmap.c\nindex cc2891d..5f67120 100644\n--- a/test-hashmap.c\n+++ b/test-hashmap.c\n@@ -14,13 +14,13 @@ static const char *get_value(const struct test_entry *e)\n }\n\n static int test_entry_cmp(const struct test_entry *e1,\n-\t\tconst struct test_entry *e2, const char* key)\n+\t\tconst struct test_entry *e2, const char *key)\n {\n \treturn strcmp(e1->key, key ? key : e2->key);\n }\n\n static int test_entry_cmp_icase(const struct test_entry *e1,\n-\t\tconst struct test_entry *e2, const char* key)\n+\t\tconst struct test_entry *e2, const char *key)\n {\n \treturn strcasecmp(e1->key, key ? key : e2->key);\n }\n--\n2.3.0.rc1.275.g028c360\n"},{"id":"255171","messageId":"1422011297-4116-1-git-send-email-kuleshovmail@gmail.com","threadId":"38441","inReplyTo":"1422011208-3832-1-git-send-email-kuleshovmail@gmail.com","subject":"[PATCH 4/7] http-backend: minor style fix","fromName":"Alexander Kuleshov","fromEmail":"kuleshovmail@gmail.com","sentAt":"2015-01-23T11:08:17Z","receivedAt":"2015-01-23T11:08:17Z","isPatch":true,"sender":{"key":"kuleshovmail@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2699235?v=4"},"body":"Asterisk must be next with variable\n\nSigned-off-by: Alexander Kuleshov \n---\n http-backend.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/http-backend.c b/http-backend.c\nindex b6c0484..7b5670b 100644\n--- a/http-backend.c\n+++ b/http-backend.c\n@@ -515,7 +515,7 @@ static NORETURN void die_webcgi(const char *err, va_list params)\n \texit(0); /* we successfully reported a failure ;-) */\n }\n\n-static char* getdir(void)\n+static char *getdir(void)\n {\n \tstruct strbuf buf = STRBUF_INIT;\n \tchar *pathinfo = getenv(\"PATH_INFO\");\n--\n2.3.0.rc1.275.g028c360\n"},{"id":"255172","messageId":"1422011305-4170-1-git-send-email-kuleshovmail@gmail.com","threadId":"38441","inReplyTo":"1422011208-3832-1-git-send-email-kuleshovmail@gmail.com","subject":"[PATCH 5/7] refs: minor style fix","fromName":"Alexander Kuleshov","fromEmail":"kuleshovmail@gmail.com","sentAt":"2015-01-23T11:08:25Z","receivedAt":"2015-01-23T11:08:25Z","isPatch":true,"sender":{"key":"kuleshovmail@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2699235?v=4"},"body":"Asterisk must be next with variable\n\nSigned-off-by: Alexander Kuleshov \n---\n refs.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/refs.h b/refs.h\nindex 425ecf7..bd8afe2 100644\n--- a/refs.h\n+++ b/refs.h\n@@ -86,7 +86,7 @@ extern int for_each_branch_ref(each_ref_fn, void *);\n extern int for_each_remote_ref(each_ref_fn, void *);\n extern int for_each_replace_ref(each_ref_fn, void *);\n extern int for_each_glob_ref(each_ref_fn, const char *pattern, void *);\n-extern int for_each_glob_ref_in(each_ref_fn, const char *pattern, const char* prefix, void *);\n+extern int for_each_glob_ref_in(each_ref_fn, const char *pattern, const char *prefix, void *);\n\n extern int head_ref_submodule(const char *submodule, each_ref_fn fn, void *cb_data);\n extern int for_each_ref_submodule(const char *submodule, each_ref_fn fn, void *cb_data);\n--\n2.3.0.rc1.275.g028c360\n"},{"id":"255174","messageId":"1422011313-4224-1-git-send-email-kuleshovmail@gmail.com","threadId":"38441","inReplyTo":"1422011208-3832-1-git-send-email-kuleshovmail@gmail.com","subject":"[PATCH 6/7] quote: minor style fix","fromName":"Alexander Kuleshov","fromEmail":"kuleshovmail@gmail.com","sentAt":"2015-01-23T11:08:33Z","receivedAt":"2015-01-23T11:08:33Z","isPatch":true,"sender":{"key":"kuleshovmail@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2699235?v=4"},"body":"Asterisk must be next with variable\n\nSigned-off-by: Alexander Kuleshov \n---\n quote.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/quote.c b/quote.c\nindex 7920e18..02e9a3c 100644\n--- a/quote.c\n+++ b/quote.c\n@@ -42,7 +42,7 @@ void sq_quote_buf(struct strbuf *dst, const char *src)\n \tfree(to_free);\n }\n\n-void sq_quote_argv(struct strbuf *dst, const char** argv, size_t maxlen)\n+void sq_quote_argv(struct strbuf *dst, const char **argv, size_t maxlen)\n {\n \tint i;\n\n--\n2.3.0.rc1.275.g028c360\n"},{"id":"255175","messageId":"1422011323-4278-1-git-send-email-kuleshovmail@gmail.com","threadId":"38441","inReplyTo":"1422011208-3832-1-git-send-email-kuleshovmail@gmail.com","subject":"[PATCH 7/7] fast-import: minor style fix","fromName":"Alexander Kuleshov","fromEmail":"kuleshovmail@gmail.com","sentAt":"2015-01-23T11:08:43Z","receivedAt":"2015-01-23T11:08:43Z","isPatch":true,"sender":{"key":"kuleshovmail@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2699235?v=4"},"body":"Asterisk must be next with variable\n\nSigned-off-by: Alexander Kuleshov \n---\n fast-import.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/fast-import.c b/fast-import.c\nindex 1b50923..fec67ca 100644\n--- a/fast-import.c\n+++ b/fast-import.c\n@@ -3110,7 +3110,7 @@ static void parse_progress(void)\n \tskip_optional_lf();\n }\n\n-static char* make_fast_import_path(const char *path)\n+static char *make_fast_import_path(const char *path)\n {\n \tif (!relative_marks_paths || is_absolute_path(path))\n \t\treturn xstrdup(path);\n--\n2.3.0.rc1.275.g028c360\n"},{"id":"255177","messageId":"CANCZXo4Ga5a0OjNhqSOP39p76RfOOX+N5cZhA8j9hjhKodTqcg@mail.gmail.com","threadId":"38441","inReplyTo":"1422011208-3832-1-git-send-email-kuleshovmail@gmail.com","subject":"Re: [PATCH 0/7] Coding style fixes.","fromName":"Alexander Kuleshov","fromEmail":"kuleshovmail@gmail.com","sentAt":"2015-01-23T12:09:37Z","receivedAt":"2015-01-23T12:09:37Z","isPatch":true,"sender":{"key":"kuleshovmail@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2699235?v=4"},"body":"I made separate patch for every file. Please, let me know if need to\nsquash it into one commit.\n\n\n2015-01-23 17:06 GMT+06:00 Alexander Kuleshov :\n> This patch set contatins minor style fixes. CodingGuidelines contains\n> rule that the star must side with variable name.\n>\n> Alexander Kuleshov (7):\n> show-branch: minor style fix\n> clone: minor style fix\n> test-hashmap: minor style fix\n> http-backend: minor style fix\n> refs: minor style fix\n> quote: minor style fix\n> fast-import: minor style fix\n>\n> builtin/clone.c | 2 +-\n> builtin/show-branch.c | 2 +-\n> fast-import.c | 2 +-\n> http-backend.c | 2 +-\n> quote.c | 2 +-\n> refs.h | 2 +-\n> test-hashmap.c | 4 ++--\n> 7 files changed, 8 insertions(+), 8 deletions(-)\n>\n> --\n> 2.3.0.rc1.275.g028c360\n\n\n\n-- \n_________________________\n0xAX\n"},{"id":"255178","messageId":"54C23D0C.8020207@web.de","threadId":"38441","inReplyTo":"1422011323-4278-1-git-send-email-kuleshovmail@gmail.com","subject":"Re: [PATCH 7/7] fast-import: minor style fix","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2015-01-23T12:22:36Z","receivedAt":"2015-01-23T12:22:36Z","isPatch":true,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"On 2015-01-23 12.08, Alexander Kuleshov wrote:\n..\nAsterisk must be next with variable\n..\nBut this is a function:\n> -static char* make_fast_import_path(const char *path)\n> +static char *make_fast_import_path(const char *path)\n\n(Sorry when I need to read this:)\n\n - Fixing style violations while working on a real change as a\n preparatory clean-up step is good, but otherwise avoid useless code\n churn for the sake of conforming to the style.\n\n \"Once it _is_ in the tree, it's not really worth the patch noise to\n go and fix it up.\"\n Cf. http://article.gmane.org/gmane.linux.kernel/943020\n"},{"id":"255203","messageId":"CAGZ79kYPHv7UCy1jzf=0WeRP7od+3pZ61Rps9NK6_qbwER_Jjw@mail.gmail.com","threadId":"38441","inReplyTo":"CANCZXo4Ga5a0OjNhqSOP39p76RfOOX+N5cZhA8j9hjhKodTqcg@mail.gmail.com","subject":"Re: [PATCH 0/7] Coding style fixes.","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2015-01-23T18:36:33Z","receivedAt":"2015-01-23T18:36:33Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Fri, Jan 23, 2015 at 4:09 AM, Alexander Kuleshov\n wrote:\n> I made separate patch for every file. Please, let me know if need to\n> squash it into one commit.\n>\n>\n> 2015-01-23 17:06 GMT+06:00 Alexander Kuleshov :\n>> This patch set contatins minor style fixes. CodingGuidelines contains\n>> rule that the star must side with variable name.\n>>\n\nThe whole series is\nReviewed-by: Stefan Beller \n"}]}