{"thread":{"id":"38440","subject":"[PATCH] git-p4: correct --prepare-p4-only instructions","startedAt":"2015-01-23T09:15:11Z","lastAt":"2015-01-23T21:39:20Z","messageCount":3,"participants":["Luke Diamand","Pete Wyckoff"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"255165","messageId":"1422004512-10049-1-git-send-email-luke@diamand.org","threadId":"38440","inReplyTo":null,"subject":"[PATCH] git-p4: correct --prepare-p4-only instructions","fromName":"Luke Diamand","fromEmail":"luke@diamand.org","sentAt":"2015-01-23T09:15:11Z","receivedAt":"2015-01-23T09:15:11Z","isPatch":true,"sender":{"key":"luke@diamand.org","avatar":"https://avatars.githubusercontent.com/u/5330967?v=4"},"body":"This fixes a small error in the command that git-p4 suggests when\nthe user gives the --prepare-p4-only option.\n\nIt tells the user to use \"p4 submit -i filename\" but the p4 submit\ncommand reads a change specification on standard input. The correct\ncommand line is therefore:\n\n   p4 submit -i <filename\n\nLuke Diamand (1):\n  git-p4: correct --prepare-p4-only instructions\n\n git-p4.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n-- \n2.1.3.1037.g95a6691.dirty\n"},{"id":"255166","messageId":"1422004512-10049-2-git-send-email-luke@diamand.org","threadId":"38440","inReplyTo":"1422004512-10049-1-git-send-email-luke@diamand.org","subject":"[PATCH] git-p4: correct --prepare-p4-only instructions","fromName":"Luke Diamand","fromEmail":"luke@diamand.org","sentAt":"2015-01-23T09:15:12Z","receivedAt":"2015-01-23T09:15:12Z","isPatch":true,"sender":{"key":"luke@diamand.org","avatar":"https://avatars.githubusercontent.com/u/5330967?v=4"},"body":"If you use git-p4 with the \"--prepare-p4-only\" option, then\nit prints the p4 command line to use. However, the command\nline was incorrect: the changelist specification must be\nsupplied on standard input, not as an argument to p4.\n\nSigned-off-by: Luke Diamand <luke@diamand.org>\n---\n git-p4.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/git-p4.py b/git-p4.py\nindex ff132b2..90447de 100755\n--- a/git-p4.py\n+++ b/git-p4.py\n@@ -1442,7 +1442,7 @@ class P4Submit(Command, P4UserMap):\n             print \"  \" + self.clientPath\n             print\n             print \"To submit, use \\\"p4 submit\\\" to write a new description,\"\n-            print \"or \\\"p4 submit -i %s\\\" to use the one prepared by\" \\\n+            print \"or \\\"p4 submit -i <%s\\\" to use the one prepared by\" \\\n                   \" \\\"git p4\\\".\" % fileName\n             print \"You can delete the file \\\"%s\\\" when finished.\" % fileName\n \n-- \n2.1.3.1037.g95a6691.dirty\n"},{"id":"255226","messageId":"20150123213920.GA3779@padd.com","threadId":"38440","inReplyTo":"1422004512-10049-2-git-send-email-luke@diamand.org","subject":"Re: [PATCH] git-p4: correct --prepare-p4-only instructions","fromName":"Pete Wyckoff","fromEmail":"pw@padd.com","sentAt":"2015-01-23T21:39:20Z","receivedAt":"2015-01-23T21:39:20Z","isPatch":true,"sender":{"key":"pw@padd.com","avatar":null},"body":"luke@diamand.org wrote on Fri, 23 Jan 2015 09:15 +0000:\n> If you use git-p4 with the \"--prepare-p4-only\" option, then\n> it prints the p4 command line to use. However, the command\n> line was incorrect: the changelist specification must be\n> supplied on standard input, not as an argument to p4.\n> \n> Signed-off-by: Luke Diamand <luke@diamand.org>\n> ---\n>  git-p4.py | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/git-p4.py b/git-p4.py\n> index ff132b2..90447de 100755\n> --- a/git-p4.py\n> +++ b/git-p4.py\n> @@ -1442,7 +1442,7 @@ class P4Submit(Command, P4UserMap):\n>              print \"  \" + self.clientPath\n>              print\n>              print \"To submit, use \\\"p4 submit\\\" to write a new description,\"\n> -            print \"or \\\"p4 submit -i %s\\\" to use the one prepared by\" \\\n> +            print \"or \\\"p4 submit -i <%s\\\" to use the one prepared by\" \\\n>                    \" \\\"git p4\\\".\" % fileName\n>              print \"You can delete the file \\\"%s\\\" when finished.\" % fileName\n>  \n\nLooks obviously good here.  Ack!\n\n\t\t-- Pete\n"}]}