{"thread":{"id":"38435","subject":"[PATCH] Documentation: fix version numbering","startedAt":"2015-01-22T19:32:33Z","lastAt":"2015-01-22T20:28:02Z","messageCount":2,"participants":["Sven van Haastregt","brian m. carlson"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"255121","messageId":"1421955153-14066-1-git-send-email-svenvh@gmail.com","threadId":"38435","inReplyTo":null,"subject":"[PATCH] Documentation: fix version numbering","fromName":"Sven van Haastregt","fromEmail":"svenvh@gmail.com","sentAt":"2015-01-22T19:32:33Z","receivedAt":"2015-01-22T19:32:33Z","isPatch":true,"sender":{"key":"svenvh@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1358906?v=4"},"body":"Version numbers in asciidoc-generated content (such as man pages)\nwent missing as of da8a366 (Documentation: refactor common operations\ninto variables).  Fix by putting the underscore back in the variable\nname.\n\nSigned-off-by: Sven van Haastregt <svenvh@gmail.com>\n---\n Documentation/Makefile | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/Makefile b/Documentation/Makefile\nindex 2f6b6aa..3e39e28 100644\n--- a/Documentation/Makefile\n+++ b/Documentation/Makefile\n@@ -103,7 +103,7 @@ ASCIIDOC_HTML = xhtml11\n ASCIIDOC_DOCBOOK = docbook\n ASCIIDOC_CONF = -f asciidoc.conf\n ASCIIDOC_COMMON = $(ASCIIDOC) $(ASCIIDOC_EXTRA) $(ASCIIDOC_CONF) \\\n-\t\t-agit-version=$(GIT_VERSION)\n+\t\t-agit_version=$(GIT_VERSION)\n TXT_TO_HTML = $(ASCIIDOC_COMMON) -b $(ASCIIDOC_HTML)\n TXT_TO_XML = $(ASCIIDOC_COMMON) -b $(ASCIIDOC_DOCBOOK)\n MANPAGE_XSL = manpage-normal.xsl\n-- \n2.2.2\n"},{"id":"255131","messageId":"20150122202802.GC96498@vauxhall.crustytoothpaste.net","threadId":"38435","inReplyTo":"1421955153-14066-1-git-send-email-svenvh@gmail.com","subject":"Re: [PATCH] Documentation: fix version numbering","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2015-01-22T20:28:02Z","receivedAt":"2015-01-22T20:28:02Z","isPatch":true,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"On Thu, Jan 22, 2015 at 07:32:33PM +0000, Sven van Haastregt wrote:\n>Version numbers in asciidoc-generated content (such as man pages)\n>went missing as of da8a366 (Documentation: refactor common operations\n>into variables).  Fix by putting the underscore back in the variable\n>name.\n>\n>Signed-off-by: Sven van Haastregt <svenvh@gmail.com>\n>---\n> Documentation/Makefile | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n>diff --git a/Documentation/Makefile b/Documentation/Makefile\n>index 2f6b6aa..3e39e28 100644\n>--- a/Documentation/Makefile\n>+++ b/Documentation/Makefile\n>@@ -103,7 +103,7 @@ ASCIIDOC_HTML = xhtml11\n> ASCIIDOC_DOCBOOK = docbook\n> ASCIIDOC_CONF = -f asciidoc.conf\n> ASCIIDOC_COMMON = $(ASCIIDOC) $(ASCIIDOC_EXTRA) $(ASCIIDOC_CONF) \\\n>-\t\t-agit-version=$(GIT_VERSION)\n>+\t\t-agit_version=$(GIT_VERSION)\n\nYes, this does seem to fix it.  My apologies for the bug, and thanks for \nnoticing.\n-- \nbrian m. carlson / brian with sandals: Houston, Texas, US\n+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only\nOpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187\n"}]}