{"thread":{"id":"38368","subject":"[PULL] git-svn updates from Ramkumar","startedAt":"2015-01-15T09:07:03Z","lastAt":"2015-01-21T17:47:36Z","messageCount":9,"participants":["Eric Wong","Junio C Hamano","Ramkumar Ramachandra"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"254735","messageId":"20150115090703.GA12333@dcvr.yhbt.net","threadId":"38368","inReplyTo":null,"subject":"[PULL] git-svn updates from Ramkumar","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2015-01-15T09:07:03Z","receivedAt":"2015-01-15T09:07:03Z","isPatch":false,"sender":{"key":"e@80x24.org","avatar":null},"body":"The following changes since commit 563d4e59bd167fe2eecc5480e3841d878b1c8c2b:\n\n Fifth batch for 2.3 cycle (2015-01-14 12:44:03 -0800)\n\nare available in the git repository at:\n\n git://bogomips.org/git-svn.git for-junio\n\nfor you to fetch changes up to a94655dcfedc6b266ba32a3d32b0d52a1ce6a928:\n\n git-svn: make it play nicely with submodules (2015-01-15 08:35:55 +0000)\n\n----------------------------------------------------------------\nRamkumar Ramachandra (2):\n Git::SVN: handle missing ref_id case correctly\n git-svn: make it play nicely with submodules\n\n git-svn.perl | 6 ++++++\n perl/Git/SVN.pm | 2 +-\n 2 files changed, 7 insertions(+), 1 deletion(-)\n"},{"id":"254766","messageId":"xmqqr3uv7u7v.fsf@gitster.dls.corp.google.com","threadId":"38368","inReplyTo":"20150115090703.GA12333@dcvr.yhbt.net","subject":"Re: [PULL] git-svn updates from Ramkumar","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-01-15T18:51:48Z","receivedAt":"2015-01-15T18:51:48Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eric Wong writes:\n\n> The following changes since commit 563d4e59bd167fe2eecc5480e3841d878b1c8c2b:\n>\n> Fifth batch for 2.3 cycle (2015-01-14 12:44:03 -0800)\n>\n> are available in the git repository at:\n>\n> git://bogomips.org/git-svn.git for-junio\n>\n> for you to fetch changes up to a94655dcfedc6b266ba32a3d32b0d52a1ce6a928:\n>\n> git-svn: make it play nicely with submodules (2015-01-15 08:35:55 +0000)\n>\n> ----------------------------------------------------------------\n> Ramkumar Ramachandra (2):\n> Git::SVN: handle missing ref_id case correctly\n> git-svn: make it play nicely with submodules\n>\n> git-svn.perl | 6 ++++++\n> perl/Git/SVN.pm | 2 +-\n> 2 files changed, 7 insertions(+), 1 deletion(-)\n\nThanks. No tests necessary/feasible? Just being curious.\n"},{"id":"254785","messageId":"20150115224652.GA25482@dcvr.yhbt.net","threadId":"38368","inReplyTo":"xmqqr3uv7u7v.fsf@gitster.dls.corp.google.com","subject":"Re: [PULL] git-svn updates from Ramkumar","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2015-01-15T22:46:52Z","receivedAt":"2015-01-15T22:46:52Z","isPatch":false,"sender":{"key":"e@80x24.org","avatar":null},"body":"Junio C Hamano wrote:\n> Thanks. No tests necessary/feasible? Just being curious.\n\nThey seemed simple and obvious enough to me,\n(and most importantly, didn't trigger regressions).\nIf Ramkumar or anybody else has the time, I'd welcome them.\n"},{"id":"254788","messageId":"xmqqtwzr4ofo.fsf@gitster.dls.corp.google.com","threadId":"38368","inReplyTo":"20150115224652.GA25482@dcvr.yhbt.net","subject":"Re: [PULL] git-svn updates from Ramkumar","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-01-15T23:24:59Z","receivedAt":"2015-01-15T23:24:59Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eric Wong writes:\n\n> Junio C Hamano wrote:\n>> Thanks. No tests necessary/feasible? Just being curious.\n>\n> They seemed simple and obvious enough to me,\n> (and most importantly, didn't trigger regressions).\n\nI can see that the top-most one is about .git that is a textual\nsymlink \".gitdir: \" and the code after this part needed\nto convert it to the real place in order to be able to read/write\n\"${GIT_DIR}/\", so that is obvious to me.\n\nBut the other one just says \"handle missing ref_id case correctly\"\nwithout clarifying what is incorrect in the original and how the\ndesired correct behaviour is different (in other words, what breaks\nwithout this change)\n\nTo which a natural reaction was \"Can the existing breakage\ndemonstrated by a test?\".\n\nIf it is obvious for git-svn folks, then I wouldn't complain,\nthough.\n"},{"id":"254792","messageId":"CALkWK0kHQ-qhD3p0_VEhVrbD39yV=F5t2nQZ4D6RKP_gpg9tKA@mail.gmail.com","threadId":"38368","inReplyTo":"xmqqtwzr4ofo.fsf@gitster.dls.corp.google.com","subject":"Re: [PULL] git-svn updates from Ramkumar","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2015-01-15T23:52:32Z","receivedAt":"2015-01-15T23:52:32Z","isPatch":false,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Junio C Hamano wrote:\n> To which a natural reaction was \"Can the existing breakage\n> demonstrated by a test?\".\n\nThere's a lot to do, if we really want to dig deeper.\n\nThe second git-svn-basic test onwards doesn't pass for me, so I really\ncan't do much in the way of contributing tests until that's fixed.\n\nCouldn't open a repository: Unable to connect to a repository at URL\n'file:///Users/artagnon/src/git/t/trash%20directory.t9100-git-svn-basic/svnrepo':\nUnable to open an ra_local session to URL: Unable to open repository\n'file:///Users/artagnon/src/git/t/trash%20directory.t9100-git-svn-basic/svnrepo':\nExpected FS format between '1' and '4'; found format '6' at\n/Users/artagnon/src/git/perl/blib/lib/Git/SVN.pm line 148.\n"},{"id":"254796","messageId":"20150116000802.GA8616@dcvr.yhbt.net","threadId":"38368","inReplyTo":"CALkWK0kHQ-qhD3p0_VEhVrbD39yV=F5t2nQZ4D6RKP_gpg9tKA@mail.gmail.com","subject":"Re: [PULL] git-svn updates from Ramkumar","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2015-01-16T00:08:02Z","receivedAt":"2015-01-16T00:08:02Z","isPatch":false,"sender":{"key":"e@80x24.org","avatar":null},"body":"Ramkumar Ramachandra wrote:\n> Junio C Hamano wrote:\n> > To which a natural reaction was \"Can the existing breakage\n> > demonstrated by a test?\".\n> \n> There's a lot to do, if we really want to dig deeper.\n> \n> The second git-svn-basic test onwards doesn't pass for me, so I really\n> can't do much in the way of contributing tests until that's fixed.\n> \n> Couldn't open a repository: Unable to connect to a repository at URL\n> 'file:///Users/artagnon/src/git/t/trash%20directory.t9100-git-svn-basic/svnrepo':\n> Unable to open an ra_local session to URL: Unable to open repository\n> 'file:///Users/artagnon/src/git/t/trash%20directory.t9100-git-svn-basic/svnrepo':\n> Expected FS format between '1' and '4'; found format '6' at\n> /Users/artagnon/src/git/perl/blib/lib/Git/SVN.pm line 148.\n\nI haven't seen this before. Which SVN Perl binding version are you\nusing? Perhaps your \"svnadmin\" tool is from a different SVN version\nor installation of SVN than your Perl bindings?\n"},{"id":"254798","messageId":"CALkWK0kFngxd2uwHjAtov+9rUbo13OOoeAhmvbxxsz39hmMnaw@mail.gmail.com","threadId":"38368","inReplyTo":"20150116000802.GA8616@dcvr.yhbt.net","subject":"Re: [PULL] git-svn updates from Ramkumar","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2015-01-16T00:18:24Z","receivedAt":"2015-01-16T00:18:24Z","isPatch":false,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Eric Wong wrote:\n> I haven't seen this before. Which SVN Perl binding version are you\n> using? Perhaps your \"svnadmin\" tool is from a different SVN version\n> or installation of SVN than your Perl bindings?\n\nI have two installations of Subversion: the system one is at\n/Library/Developer/CommandLineTools @ version 1.7.17, and the brew\ninstalled one is at /usr/local @ version 1.8.10. When I build git from\nscratch, it links to the dated SVN bindings for some reason. I suspect\nI have to tweak $PERL5LIB?\n\nCan we patch git-svn to link to the Right one on OS X?\n"},{"id":"254799","messageId":"20150116003931.GA28184@dcvr.yhbt.net","threadId":"38368","inReplyTo":"CALkWK0kFngxd2uwHjAtov+9rUbo13OOoeAhmvbxxsz39hmMnaw@mail.gmail.com","subject":"Re: [PULL] git-svn updates from Ramkumar","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2015-01-16T00:39:31Z","receivedAt":"2015-01-16T00:39:31Z","isPatch":false,"sender":{"key":"e@80x24.org","avatar":null},"body":"Ramkumar Ramachandra wrote:\n> Eric Wong wrote:\n> > I haven't seen this before. Which SVN Perl binding version are you\n> > using? Perhaps your \"svnadmin\" tool is from a different SVN version\n> > or installation of SVN than your Perl bindings?\n> \n> I have two installations of Subversion: the system one is at\n> /Library/Developer/CommandLineTools @ version 1.7.17, and the brew\n> installed one is at /usr/local @ version 1.8.10. When I build git from\n> scratch, it links to the dated SVN bindings for some reason. I suspect\n> I have to tweak $PERL5LIB?\n\nAdding it to GITPERLLIB should work...\n\n> Can we patch git-svn to link to the Right one on OS X?\n\nYou should be able to set up everything in the Makefile, that has\nspecial cases for Fink and Darwin ports, at least. Somebody who knows\nOS X packaging systems might have better advice.\n"},{"id":"254997","messageId":"CALkWK0mtZ_w6ExL+GZX4q3gsFj3qVwb+V463nAFFuTabqzobmA@mail.gmail.com","threadId":"38368","inReplyTo":"20150116003931.GA28184@dcvr.yhbt.net","subject":"Re: [PULL] git-svn updates from Ramkumar","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2015-01-21T17:47:36Z","receivedAt":"2015-01-21T17:47:36Z","isPatch":false,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Eric Wong wrote:\n> Adding it to GITPERLLIB should work...\n\nI tried everything including replicating the commands in the brew\nformula that does the Right thing:\nhttps://github.com/Homebrew/homebrew/blob/master/Library/Formula/git.rb\n\nI'm clearly missing something. Can someone on Darwin tell us the right\nflags/ env variables?\n"}]}