{"thread":{"id":"38353","subject":"[PATCH] stash: git stash create and git stash store added to git stash usage synopsys","startedAt":"2015-01-13T17:54:06Z","lastAt":"2015-02-12T22:54:58Z","messageCount":4,"participants":["Alexander Kuleshov","Scott Schmit","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"254608","messageId":"1421171646-12113-1-git-send-email-kuleshovmail@gmail.com","threadId":"38353","inReplyTo":null,"subject":"[PATCH] stash: git stash create and git stash store added to git stash usage synopsys","fromName":"Alexander Kuleshov","fromEmail":"kuleshovmail@gmail.com","sentAt":"2015-01-13T17:54:06Z","receivedAt":"2015-01-13T17:54:06Z","isPatch":true,"sender":{"key":"kuleshovmail@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2699235?v=4"},"body":"Signed-off-by: Alexander Kuleshov \n---\n git-stash.sh | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)\n\ndiff --git a/git-stash.sh b/git-stash.sh\nindex 6846b18..6e30380 100755\n--- a/git-stash.sh\n+++ b/git-stash.sh\n@@ -9,7 +9,9 @@ USAGE=\"list []\n or: $dashless branch []\n or: $dashless [save [--patch] [-k|--[no-]keep-index] [-q|--quiet]\n \t\t [-u|--include-untracked] [-a|--all] []]\n- or: $dashless clear\"\n+ or: $dashless clear\n+ or: $dashless create []\n+ or: $dashless store [-m|--message ] [-q|--quiet] \"\n \n SUBDIRECTORY_OK=Yes\n OPTIONS_SPEC=\n-- \n2.3.0.rc0.239.g0ae1f56.dirty\n"},{"id":"254636","messageId":"20150114031137.GA12605@odin.ulthar.us","threadId":"38353","inReplyTo":"1421171646-12113-1-git-send-email-kuleshovmail@gmail.com","subject":"Re: [PATCH] stash: git stash create and git stash store added to git stash usage synopsys","fromName":"Scott Schmit","fromEmail":"i.grok@comcast.net","sentAt":"2015-01-14T03:11:37Z","receivedAt":"2015-01-14T03:11:37Z","isPatch":true,"sender":{"key":"i.grok@comcast.net","avatar":null},"body":"On Tue, Jan 13, 2015 at 11:54:06PM +0600, Alexander Kuleshov wrote:\n> Signed-off-by: Alexander Kuleshov \n> ---\n> git-stash.sh | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/git-stash.sh b/git-stash.sh\n> index 6846b18..6e30380 100755\n> --- a/git-stash.sh\n> +++ b/git-stash.sh\n> @@ -9,7 +9,9 @@ USAGE=\"list []\n> or: $dashless branch []\n> or: $dashless [save [--patch] [-k|--[no-]keep-index] [-q|--quiet]\n> \t\t [-u|--include-untracked] [-a|--all] []]\n> - or: $dashless clear\"\n> + or: $dashless clear\n> + or: $dashless create []\n> + or: $dashless store [-m|--message ] [-q|--quiet] \"\n> \n> SUBDIRECTORY_OK=Yes\n> OPTIONS_SPEC=\n\nConsidering the man page says create & store are intended for scripts\nand \"probably not the command you want to use\", why would we want it in\nthe synopsis?\n\n-- \nScott Schmit\n"},{"id":"254667","messageId":"xmqqy4p59s1q.fsf@gitster.dls.corp.google.com","threadId":"38353","inReplyTo":"20150114031137.GA12605@odin.ulthar.us","subject":"Re: [PATCH] stash: git stash create and git stash store added to git stash usage synopsys","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-01-14T17:43:29Z","receivedAt":"2015-01-14T17:43:29Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Scott Schmit writes:\n\n[administrivia: please refrain from using Mail-follow-up-to]\n\n> On Tue, Jan 13, 2015 at 11:54:06PM +0600, Alexander Kuleshov wrote:\n>> Signed-off-by: Alexander Kuleshov \n>> ---\n>> git-stash.sh | 4 +++-\n>> 1 file changed, 3 insertions(+), 1 deletion(-)\n>> \n>> diff --git a/git-stash.sh b/git-stash.sh\n>> index 6846b18..6e30380 100755\n>> --- a/git-stash.sh\n>> +++ b/git-stash.sh\n>> @@ -9,7 +9,9 @@ USAGE=\"list []\n>> or: $dashless branch []\n>> or: $dashless [save [--patch] [-k|--[no-]keep-index] [-q|--quiet]\n>> \t\t [-u|--include-untracked] [-a|--all] []]\n>> - or: $dashless clear\"\n>> + or: $dashless clear\n>> + or: $dashless create []\n>> + or: $dashless store [-m|--message ] [-q|--quiet] \"\n>> \n>> SUBDIRECTORY_OK=Yes\n>> OPTIONS_SPEC=\n>\n> Considering the man page says create & store are intended for scripts\n> and \"probably not the command you want to use\", why would we want it in\n> the synopsis?\n\nWith the understanding that these are only for scripters, I think we\ncan agree that we do want to describe them in the manual pages, and\nwe do not want them in the completion.\n\nI feel \"git stash -h\" output is on the borderline, and can be argued\nboth ways:\n\n - When you script and are not clear how a command you wanted to use\n in your script is to be used, it wouldn't be a crime to ask the\n short \"git stash -h\" form (instead of the full manual page \"git\n stash --help\") to remind how the command line ought to be\n spelled.\n\n - When you are not interested in script at all, from the command\n line you may want to be reminded how to spell the subcommand with\n \"git stash -h\" form. Having \"store\" listed, which will never be\n what you want in this scenario, will be confusing. You want to\n see \"save\".\n\nSo, I dunno.\n"},{"id":"256031","messageId":"xmqqpp9epwot.fsf@gitster.dls.corp.google.com","threadId":"38353","inReplyTo":"xmqqy4p59s1q.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH] stash: git stash create and git stash store added to git stash usage synopsys","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-02-12T22:54:58Z","receivedAt":"2015-02-12T22:54:58Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano writes:\n\n> Scott Schmit writes:\n>>\n>> Considering the man page says create & store are intended for scripts\n>> and \"probably not the command you want to use\", why would we want it in\n>> the synopsis?\n>\n> With the understanding that these are only for scripters, I think we\n> can agree that we do want to describe them in the manual pages, and\n> we do not want them in the completion.\n>\n> I feel \"git stash -h\" output is on the borderline, and can be argued\n> both ways:\n>\n> - When you script and are not clear how a command you wanted to use\n> in your script is to be used, it wouldn't be a crime to ask the\n> short \"git stash -h\" form (instead of the full manual page \"git\n> stash --help\") to remind how the command line ought to be\n> spelled.\n>\n> - When you are not interested in script at all, from the command\n> line you may want to be reminded how to spell the subcommand with\n> \"git stash -h\" form. Having \"store\" listed, which will never be\n> what you want in this scenario, will be confusing. You want to\n> see \"save\".\n>\n> So, I dunno.\n\nAs I haven't heard anything after this, I am inclined to drop this\ntopic that has been sitting on my Undecided pile.\n\n * ak/stash-store-create-help (2015-01-13) 1 commit\n - stash: show \"create\" and \"store\" subcommands in usage-help\n\n Undecided.\n\nPlease speak up if somebody new feels strongly otherwise [*1*].\n\nThanks.\n\n\n[Footnote]\n\n*1* I already know Scott Schmit was against it, and Alexander\nKuleshov as the original author was for it ;-)\n"}]}