{"thread":{"id":"38329","subject":"[PATCH] git-svn: show progress in working_head_info()","startedAt":"2015-01-10T13:21:36Z","lastAt":"2015-01-14T22:40:23Z","messageCount":3,"participants":["Ramkumar Ramachandra","Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"254529","messageId":"1420896096-15254-1-git-send-email-artagnon@gmail.com","threadId":"38329","inReplyTo":null,"subject":"[PATCH] git-svn: show progress in working_head_info()","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2015-01-10T13:21:36Z","receivedAt":"2015-01-10T13:21:36Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"The working_head_info routine takes a very long time to execute on large\nrepositories. The least we can do is to comfort users that some progress\nis being made.\n\nSigned-off-by: Ramkumar Ramachandra <artagnon@gmail.com>\n---\n I was worried because of the long wait, so I wrote this to convince\n myself that git-svn wasn't stuck.\n\n git-svn.perl | 3 +++\n 1 file changed, 3 insertions(+)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex 60f8814..6aa156c 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -2022,6 +2022,9 @@ sub working_head_info {\n \t\t\tnext;\n \t\t}\n \t\tnext unless s{^\\s*(git-svn-id:)}{$1};\n+\t\tmy $chomped = $_;\n+\t\tchomp $chomped;\n+\t\tprint \"[Importing] $chomped\\n\";\n \t\tmy ($url, $rev, $uuid) = extract_metadata($_);\n \t\tif (defined $url && defined $rev) {\n \t\t\tnext if $max{$url} and $max{$url} < $rev;\n-- \n2.2.1\n"},{"id":"254546","messageId":"20150110222135.GB32253@dcvr.yhbt.net","threadId":"38329","inReplyTo":"1420896096-15254-1-git-send-email-artagnon@gmail.com","subject":"Re: [PATCH] git-svn: show progress in working_head_info()","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2015-01-10T22:21:35Z","receivedAt":"2015-01-10T22:21:35Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Ramkumar Ramachandra <artagnon@gmail.com> wrote:\n> The working_head_info routine takes a very long time to execute on large\n> repositories. The least we can do is to comfort users that some progress\n> is being made.\n> \n> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>\n> ---\n>  I was worried because of the long wait, so I wrote this to convince\n>  myself that git-svn wasn't stuck.\n\nUnfortunately, this breaks show-ignore and t9101-git-svn-props.sh\n\nshow-ignore.expect show-ignore.got differ: char 1, line 1\nnot ok 23 - test show-ignore\n\nPerhaps output should go to STDERR and also respect $_q?\n\n>  git-svn.perl | 3 +++\n>  1 file changed, 3 insertions(+)\n> \n> diff --git a/git-svn.perl b/git-svn.perl\n> index 60f8814..6aa156c 100755\n> --- a/git-svn.perl\n> +++ b/git-svn.perl\n> @@ -2022,6 +2022,9 @@ sub working_head_info {\n>  \t\t\tnext;\n>  \t\t}\n>  \t\tnext unless s{^\\s*(git-svn-id:)}{$1};\n> +\t\tmy $chomped = $_;\n> +\t\tchomp $chomped;\n> +\t\tprint \"[Importing] $chomped\\n\";\n>  \t\tmy ($url, $rev, $uuid) = extract_metadata($_);\n>  \t\tif (defined $url && defined $rev) {\n>  \t\t\tnext if $max{$url} and $max{$url} < $rev;\n"},{"id":"254704","messageId":"CALkWK0nJdkk0D3R62upGWm24s4vqF5tehkb5fU=nWMnCJ-OGWw@mail.gmail.com","threadId":"38329","inReplyTo":"20150110222135.GB32253@dcvr.yhbt.net","subject":"Re: [PATCH] git-svn: show progress in working_head_info()","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2015-01-14T22:40:23Z","receivedAt":"2015-01-14T22:40:23Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Eric,\n\nI'm sorry, but this change isn't important enough for me to follow up.\nPlease merge the other two patches, if you think they're good.\n\nThanks.\n"}]}