{"thread":{"id":"38324","subject":"[PATCH] git.c: remove unused includes","startedAt":"2015-01-09T10:12:33Z","lastAt":"2015-01-09T19:52:01Z","messageCount":2,"participants":["Alexander Kuleshov","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"254506","messageId":"1420798353-12316-1-git-send-email-kuleshovmail@gmail.com","threadId":"38324","inReplyTo":null,"subject":"[PATCH] git.c: remove unused includes","fromName":"Alexander Kuleshov","fromEmail":"kuleshovmail@gmail.com","sentAt":"2015-01-09T10:12:33Z","receivedAt":"2015-01-09T10:12:33Z","isPatch":true,"sender":{"key":"kuleshovmail@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2699235?v=4"},"body":"* <cache.h> and <commit.h> already included in <builtin.h>\n\n* <quote.h> was appeared in (6035d6aa GIT_TRACE: show which\nbuilt-in/external commands are executed  25 Jun 2006) and sq_quote_print\nwas removed at (82aae5c quote: remove sq_quote_print() Jul 30 2013)\n\nSigned-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>\n---\n git.c | 3 ---\n 1 file changed, 3 deletions(-)\n\ndiff --git a/git.c b/git.c\nindex 09b3bcf..c9bec99 100644\n--- a/git.c\n+++ b/git.c\n@@ -1,10 +1,7 @@\n #include \"builtin.h\"\n-#include \"cache.h\"\n #include \"exec_cmd.h\"\n #include \"help.h\"\n-#include \"quote.h\"\n #include \"run-command.h\"\n-#include \"commit.h\"\n \n const char git_usage_string[] =\n \t\"git [--version] [--help] [-C <path>] [-c name=value]\\n\"\n-- \n2.2.1.522.g2561c04.dirty\n"},{"id":"254511","messageId":"xmqq7fwvd95q.fsf@gitster.dls.corp.google.com","threadId":"38324","inReplyTo":"1420798353-12316-1-git-send-email-kuleshovmail@gmail.com","subject":"Re: [PATCH] git.c: remove unused includes","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-01-09T19:52:01Z","receivedAt":"2015-01-09T19:52:01Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Alexander Kuleshov <kuleshovmail@gmail.com> writes:\n\n> * <cache.h> and <commit.h> already included in <builtin.h>\n>\n> * <quote.h> was appeared in (6035d6aa GIT_TRACE: show which\n> built-in/external commands are executed  25 Jun 2006) and sq_quote_print\n> was removed at (82aae5c quote: remove sq_quote_print() Jul 30 2013)\n\nThat's not 6035d6aa, though.\n\nWe started to include \"quote.h\" at 575ba9d6 (GIT_TRACE: show which\nbuilt-in/external commands are executed, 2006-06-25) that wanted to\nuse sq_quote_print().\n\nWhen 6ce4e61f (Trace into a file or an open fd and refactor tracing\ncode., 2006-09-02) introduced trace.c API, the calls this file makes\nto sq_quote_print() were replaced by calls to trace_argv_printf()\nthat are declared in \"cache.h\", which this file already includes.\nWe should have stopped including \"quote.h\" in that commit, but\nforgot to do so.\n\n>\n> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>\n> ---\n>  git.c | 3 ---\n>  1 file changed, 3 deletions(-)\n>\n> diff --git a/git.c b/git.c\n> index 09b3bcf..c9bec99 100644\n> --- a/git.c\n> +++ b/git.c\n> @@ -1,10 +1,7 @@\n>  #include \"builtin.h\"\n> -#include \"cache.h\"\n>  #include \"exec_cmd.h\"\n>  #include \"help.h\"\n> -#include \"quote.h\"\n>  #include \"run-command.h\"\n> -#include \"commit.h\"\n>  \n>  const char git_usage_string[] =\n>  \t\"git [--version] [--help] [-C <path>] [-c name=value]\\n\"\n"}]}