{"thread":{"id":"38313","subject":"[PATCH 1/2] remote: Remove -v/--verbose option from git remote show synopsis","startedAt":"2015-01-08T17:57:43Z","lastAt":"2015-01-08T20:32:35Z","messageCount":6,"participants":["Alexander Kuleshov","René Scharfe","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"254471","messageId":"1420739863-11602-1-git-send-email-kuleshovmail@gmail.com","threadId":"38313","inReplyTo":null,"subject":"[PATCH 1/2] remote: Remove -v/--verbose option from git remote show synopsis","fromName":"Alexander Kuleshov","fromEmail":"kuleshovmail@gmail.com","sentAt":"2015-01-08T17:57:43Z","receivedAt":"2015-01-08T17:57:43Z","isPatch":true,"sender":{"key":"kuleshovmail@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2699235?v=4"},"body":"git remote show doesn't use -v/--verbose option\n\nSigned-off-by: Alexander Kuleshov \n---\n builtin/remote.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/remote.c b/builtin/remote.c\nindex 46ecfd9..978c645 100644\n--- a/builtin/remote.c\n+++ b/builtin/remote.c\n@@ -14,7 +14,7 @@ static const char * const builtin_remote_usage[] = {\n \tN_(\"git remote rename \"),\n \tN_(\"git remote remove \"),\n \tN_(\"git remote set-head (-a | --auto | -d | --delete |)\"),\n-\tN_(\"git remote [-v | --verbose] show [-n] \"),\n+\tN_(\"git remote show [-n] \"),\n \tN_(\"git remote prune [-n | --dry-run] \"),\n \tN_(\"git remote [-v | --verbose] update [-p | --prune] [( | )...]\"),\n \tN_(\"git remote set-branches [--add] ...\"),\n-- \n2.2.1.364.g47473d1.dirty\n"},{"id":"254477","messageId":"54AED7C3.8010604@web.de","threadId":"38313","inReplyTo":"1420739863-11602-1-git-send-email-kuleshovmail@gmail.com","subject":"Re: [PATCH 1/2] remote: Remove -v/--verbose option from git remote show synopsis","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2015-01-08T19:17:23Z","receivedAt":"2015-01-08T19:17:23Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Am 08.01.2015 um 18:57 schrieb Alexander Kuleshov:\n> git remote show doesn't use -v/--verbose option\n\nHmm, but it does?\n\n\t$ git version\n\tgit version 2.2.1\n\t$ git remote show\n\torigin\n\t$ git remote -v show\n\torigin git://git.kernel.org/pub/scm/git/git.git (fetch)\n\torigin git://git.kernel.org/pub/scm/git/git.git (push)\n\nPerhaps you meant the following variant? The changed line documents the \none above, though (-v before show).\n\n\t$ git remote show -v\n\terror: unknown switch `v'\n\tusage: git remote show [] \n\n\t -n do not query remotes\n\n> Signed-off-by: Alexander Kuleshov \n> ---\n> builtin/remote.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/builtin/remote.c b/builtin/remote.c\n> index 46ecfd9..978c645 100644\n> --- a/builtin/remote.c\n> +++ b/builtin/remote.c\n> @@ -14,7 +14,7 @@ static const char * const builtin_remote_usage[] = {\n> \tN_(\"git remote rename \"),\n> \tN_(\"git remote remove \"),\n> \tN_(\"git remote set-head (-a | --auto | -d | --delete |)\"),\n> -\tN_(\"git remote [-v | --verbose] show [-n] \"),\n> +\tN_(\"git remote show [-n] \"),\n> \tN_(\"git remote prune [-n | --dry-run] \"),\n> \tN_(\"git remote [-v | --verbose] update [-p | --prune] [( | )...]\"),\n> \tN_(\"git remote set-branches [--add] ...\"),\n>\n"},{"id":"254478","messageId":"CANCZXo41D9pYEPKAXmS3kYOjniXzoWMJK55Eooa=STAna8F0AA@mail.gmail.com","threadId":"38313","inReplyTo":"54AED7C3.8010604@web.de","subject":"Re: [PATCH 1/2] remote: Remove -v/--verbose option from git remote show synopsis","fromName":"Alexander Kuleshov","fromEmail":"kuleshovmail@gmail.com","sentAt":"2015-01-08T19:22:13Z","receivedAt":"2015-01-08T19:22:13Z","isPatch":true,"sender":{"key":"kuleshovmail@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2699235?v=4"},"body":"Ah, yes, right. Please dismiss 1,2 patches.\n\nSorry for noise\n\n2015-01-09 1:17 GMT+06:00 René Scharfe :\n> Am 08.01.2015 um 18:57 schrieb Alexander Kuleshov:\n>>\n>> git remote show doesn't use -v/--verbose option\n>\n>\n> Hmm, but it does?\n>\n> $ git version\n> git version 2.2.1\n> $ git remote show\n> origin\n> $ git remote -v show\n> origin git://git.kernel.org/pub/scm/git/git.git (fetch)\n> origin git://git.kernel.org/pub/scm/git/git.git (push)\n>\n> Perhaps you meant the following variant? The changed line documents the one\n> above, though (-v before show).\n>\n> $ git remote show -v\n> error: unknown switch `v'\n> usage: git remote show [] \n>\n> -n do not query remotes\n>\n>\n>> Signed-off-by: Alexander Kuleshov \n>> ---\n>> builtin/remote.c | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/builtin/remote.c b/builtin/remote.c\n>> index 46ecfd9..978c645 100644\n>> --- a/builtin/remote.c\n>> +++ b/builtin/remote.c\n>> @@ -14,7 +14,7 @@ static const char * const builtin_remote_usage[] = {\n>> N_(\"git remote rename \"),\n>> N_(\"git remote remove \"),\n>> N_(\"git remote set-head (-a | --auto | -d | --delete\n>> |)\"),\n>> - N_(\"git remote [-v | --verbose] show [-n] \"),\n>> + N_(\"git remote show [-n] \"),\n>> N_(\"git remote prune [-n | --dry-run] \"),\n>> N_(\"git remote [-v | --verbose] update [-p | --prune] [( |\n>> )...]\"),\n>> N_(\"git remote set-branches [--add] ...\"),\n>>\n>\n\n\n\n-- \n_________________________\n0xAX\n"},{"id":"254482","messageId":"xmqqwq4xdpgg.fsf@gitster.dls.corp.google.com","threadId":"38313","inReplyTo":"1420739863-11602-1-git-send-email-kuleshovmail@gmail.com","subject":"Re: [PATCH 1/2] remote: Remove -v/--verbose option from git remote show synopsis","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-01-08T19:47:43Z","receivedAt":"2015-01-08T19:47:43Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Alexander Kuleshov writes:\n\n> git remote show doesn't use -v/--verbose option\n>\n> Signed-off-by: Alexander Kuleshov \n\nThanks. \n\nI think these two patches should be squashed into one (which I can\ndo locally without asking you to resend) but they are good changes.\nThe subcommand does not just \"not use\", but it does not even support\n(i.e. it throws an error when the option is given).\n\n> ---\n> builtin/remote.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/builtin/remote.c b/builtin/remote.c\n> index 46ecfd9..978c645 100644\n> --- a/builtin/remote.c\n> +++ b/builtin/remote.c\n> @@ -14,7 +14,7 @@ static const char * const builtin_remote_usage[] = {\n> \tN_(\"git remote rename \"),\n> \tN_(\"git remote remove \"),\n> \tN_(\"git remote set-head (-a | --auto | -d | --delete |)\"),\n> -\tN_(\"git remote [-v | --verbose] show [-n] \"),\n> +\tN_(\"git remote show [-n] \"),\n> \tN_(\"git remote prune [-n | --dry-run] \"),\n> \tN_(\"git remote [-v | --verbose] update [-p | --prune] [( | )...]\"),\n> \tN_(\"git remote set-branches [--add] ...\"),\n"},{"id":"254487","messageId":"xmqqoaq9do7i.fsf@gitster.dls.corp.google.com","threadId":"38313","inReplyTo":"54AED7C3.8010604@web.de","subject":"Re: [PATCH 1/2] remote: Remove -v/--verbose option from git remote show synopsis","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-01-08T20:14:41Z","receivedAt":"2015-01-08T20:14:41Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"René Scharfe writes:\n\n> Am 08.01.2015 um 18:57 schrieb Alexander Kuleshov:\n>> git remote show doesn't use -v/--verbose option\n>\n> Hmm, but it does?\n>\n> \t$ git version\n> \tgit version 2.2.1\n> \t$ git remote show\n> \torigin\n> \t$ git remote -v show\n> \torigin git://git.kernel.org/pub/scm/git/git.git (fetch)\n> \torigin git://git.kernel.org/pub/scm/git/git.git (push)\n>\n> Perhaps you meant the following variant? The changed line documents\n> the one above, though (-v before show).\n>\n> \t$ git remote show -v\n> \terror: unknown switch `v'\n> \tusage: git remote show [] \n>\n> \t -n do not query remotes\n\nAhh, I misread the patch. Thanks.\n\n>> diff --git a/builtin/remote.c b/builtin/remote.c\n>> index 46ecfd9..978c645 100644\n>> --- a/builtin/remote.c\n>> +++ b/builtin/remote.c\n>> @@ -14,7 +14,7 @@ static const char * const builtin_remote_usage[] = {\n>> \tN_(\"git remote rename \"),\n>> \tN_(\"git remote remove \"),\n>> \tN_(\"git remote set-head (-a | --auto | -d | --delete |)\"),\n>> -\tN_(\"git remote [-v | --verbose] show [-n] \"),\n>> +\tN_(\"git remote show [-n] \"),\n>> \tN_(\"git remote prune [-n | --dry-run] \"),\n>> \tN_(\"git remote [-v | --verbose] update [-p | --prune] [( | )...]\"),\n>> \tN_(\"git remote set-branches [--add] ...\"),\n>>\n\nI however have a bit larger question. Does it make sense to have\n[-v/--verbose] in front of some but not all of the subcommands?\n\nFor example, the above snippet gives me an impression that\n\n $ git remote -v prune -n origin\n\nshould not work, but that does not seem to be the case.\n"},{"id":"254491","messageId":"CANCZXo5KT9OZHtJm3HUUncRgaBdY35nsvfGz8z-6WdMQ0ALQyw@mail.gmail.com","threadId":"38313","inReplyTo":"xmqqoaq9do7i.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH 1/2] remote: Remove -v/--verbose option from git remote show synopsis","fromName":"Alexander Kuleshov","fromEmail":"kuleshovmail@gmail.com","sentAt":"2015-01-08T20:32:35Z","receivedAt":"2015-01-08T20:32:35Z","isPatch":true,"sender":{"key":"kuleshovmail@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2699235?v=4"},"body":"What if move -v/--verbose after commands? Like:\n\ngit remote show [-v | --verbose] [-n] \n\nand etc...?\n\n2015-01-09 2:14 GMT+06:00 Junio C Hamano :\n> René Scharfe writes:\n>\n>> Am 08.01.2015 um 18:57 schrieb Alexander Kuleshov:\n>>> git remote show doesn't use -v/--verbose option\n>>\n>> Hmm, but it does?\n>>\n>> $ git version\n>> git version 2.2.1\n>> $ git remote show\n>> origin\n>> $ git remote -v show\n>> origin git://git.kernel.org/pub/scm/git/git.git (fetch)\n>> origin git://git.kernel.org/pub/scm/git/git.git (push)\n>>\n>> Perhaps you meant the following variant? The changed line documents\n>> the one above, though (-v before show).\n>>\n>> $ git remote show -v\n>> error: unknown switch `v'\n>> usage: git remote show [] \n>>\n>> -n do not query remotes\n>\n> Ahh, I misread the patch. Thanks.\n>\n>>> diff --git a/builtin/remote.c b/builtin/remote.c\n>>> index 46ecfd9..978c645 100644\n>>> --- a/builtin/remote.c\n>>> +++ b/builtin/remote.c\n>>> @@ -14,7 +14,7 @@ static const char * const builtin_remote_usage[] = {\n>>> N_(\"git remote rename \"),\n>>> N_(\"git remote remove \"),\n>>> N_(\"git remote set-head (-a | --auto | -d | --delete |)\"),\n>>> - N_(\"git remote [-v | --verbose] show [-n] \"),\n>>> + N_(\"git remote show [-n] \"),\n>>> N_(\"git remote prune [-n | --dry-run] \"),\n>>> N_(\"git remote [-v | --verbose] update [-p | --prune] [( | )...]\"),\n>>> N_(\"git remote set-branches [--add] ...\"),\n>>>\n>\n> I however have a bit larger question. Does it make sense to have\n> [-v/--verbose] in front of some but not all of the subcommands?\n>\n> For example, the above snippet gives me an impression that\n>\n> $ git remote -v prune -n origin\n>\n> should not work, but that does not seem to be the case.\n\n\n\n-- \n_________________________\n0xAX\n"}]}