{"thread":{"id":"38300","subject":"Tab completion missing for --includes and branch description in git config","startedAt":"2015-01-07T00:58:27Z","lastAt":"2015-01-07T18:14:36Z","messageCount":2,"participants":["Michael Paquier","Stefan Beller"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"254388","messageId":"CAB7nPqRnDTEXWEDUHX7xJG_+QvoXdt2aA6RLRn4Hiq-rOZMEmQ@mail.gmail.com","threadId":"38300","inReplyTo":null,"subject":"Tab completion missing for --includes and branch description in git config","fromName":"Michael Paquier","fromEmail":"michael.paquier@gmail.com","sentAt":"2015-01-07T00:58:27Z","receivedAt":"2015-01-07T00:58:27Z","isPatch":false,"sender":{"key":"michael.paquier@gmail.com","avatar":null},"body":"Hi all,\n\nWhile toying with the tab completion script for bash, I found a couple\nof things missing that cannot be completed:\n- git config --includes\n- git config branch.$BRANCH_NAME.description\nAttached are trivial patches based on master to fix those things.\nRegards,\n-- \nMichael\n\n\nFrom cc463975e4a21dc523fa920db813eada881a0ccd Mon Sep 17 00:00:00 2001\nFrom: Michael Paquier <michael@otacoo.com>\nDate: Wed, 7 Jan 2015 09:43:29 +0900\nSubject: [PATCH 1/2] Identify --includes for git config in tab completion\n\nSigned-off-by: Michael Paquier <michael@otacoo.com>\n---\n contrib/completion/git-completion.bash | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 23988ec..d6b0754 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1891,7 +1891,7 @@ _git_config ()\n \t--*)\n \t\t__gitcomp \"\n \t\t\t--system --global --local --file=\n-\t\t\t--list --replace-all\n+\t\t\t--includes --list --replace-all\n \t\t\t--get --get-all --get-regexp\n \t\t\t--add --unset --unset-all\n \t\t\t--remove-section --rename-section\n-- \n2.2.1\n\n\n\nFrom c2323d093b3a3a9daf0cf7e17dddff6bc028bd0e Mon Sep 17 00:00:00 2001\nFrom: Michael Paquier <michael@otacoo.com>\nDate: Wed, 7 Jan 2015 09:48:10 +0900\nSubject: [PATCH 2/2] Identify description for git config in tab completion\n\nSigned-off-by: Michael Paquier <michael@otacoo.com>\n---\n contrib/completion/git-completion.bash | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex d6b0754..412f74b 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1900,7 +1900,9 @@ _git_config ()\n \t\t;;\n \tbranch.*.*)\n \t\tlocal pfx=\"${cur%.*}.\" cur_=\"${cur##*.}\"\n-\t\t__gitcomp \"remote pushremote merge mergeoptions rebase\" \"$pfx\" \"$cur_\"\n+\t\t__gitcomp \"\n+\t\t\tdescription remote pushremote merge mergeoptions rebase\n+\t\t\t\" \"$pfx\" \"$cur_\"\n \t\treturn\n \t\t;;\n \tbranch.*)\n-- \n2.2.1\n\n"},{"id":"254408","messageId":"CAGZ79kbNyXLyXMRPqk0HPpYK1XSbnL8tZEvXRaWW-rNK=OrQCA@mail.gmail.com","threadId":"38300","inReplyTo":"CAB7nPqRnDTEXWEDUHX7xJG_+QvoXdt2aA6RLRn4Hiq-rOZMEmQ@mail.gmail.com","subject":"Re: Tab completion missing for --includes and branch description in git config","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2015-01-07T18:14:36Z","receivedAt":"2015-01-07T18:14:36Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Tue, Jan 6, 2015 at 4:58 PM, Michael Paquier\n<michael.paquier@gmail.com> wrote:\n> Hi all,\n>\n> While toying with the tab completion script for bash, I found a couple\n> of things missing that cannot be completed:\n> - git config --includes\n> - git config branch.$BRANCH_NAME.description\n> Attached are trivial patches based on master to fix those things.\n> Regards,\n> --\n> Michael\n\nThanks for your effort on improving git!\n\nPlease have a look at Documentation/SubmittingPatches in git[1],\nspecially section \"(4) Sending your patches.\" so discussion on the\npatches is easier.\n\n>Do not attach the patch as a MIME attachment, compressed or not.\n>Do not let your e-mail client send quoted-printable.  Do not let\n>your e-mail client send format=flowed which would destroy\n>whitespaces in your patches. Many\n>popular e-mail applications will not always transmit a MIME\n>attachment as plain text, making it impossible to comment on\n>your code.  A MIME attachment also takes a bit more time to\n>process.  This does not decrease the likelihood of your\n>MIME-attached change being accepted, but it makes it more likely\n>that it will be postponed.\n\nThe easiest way to comply with all these rules outlined in SubmittingPatches\nis to use git format-patch and git send-email (as they follow the best\npractice).\n\nI recently wrote about my experiences when sending patches to the git\nmailing list,\nincluding how to configure git send-email[2], maybe that helps.\n\nThanks,\nStefan\n\n\n[1] for example it can be found at\nhttps://raw.githubusercontent.com/git/git/master/Documentation/SubmittingPatches\n\n[2]http://thread.gmane.org/gmane.comp.version-control.git/261900\n"}]}