{"thread":{"id":"38267","subject":"Re: [PATCH] Documentation/SubmittingPatches: Explain the rationale of git notes","startedAt":"2014-12-30T23:30:30Z","lastAt":"2014-12-30T23:30:30Z","messageCount":1,"participants":["Eric Sunshine"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"254227","messageId":"20141230233030.GA6344@flurp.local","threadId":"38267","inReplyTo":"CAGZ79kZcnu4ArwfEVNMh+mQjkYAvj=rJXP4jz2o6YF1t5=SQ6w@mail.gmail.com","subject":"Re: [PATCH] Documentation/SubmittingPatches: Explain the rationale of git notes","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2014-12-30T23:30:30Z","receivedAt":"2014-12-30T23:30:30Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Mon, Dec 29, 2014 at 06:48:48PM -0800, Stefan Beller wrote:\n> On Mon, Dec 29, 2014 at 6:47 PM, Stefan Beller <sbeller@google.com> wrote:\n> > From: Eric Sunshine <sunshine@sunshineco.com>\n> \n> As I just copied the whole text of Eric, I think\n> it would be better if Eric is credited for this commit.\n> \n> Eric,\n> I already added your sign off to help Junio just pick it up.\n> Please confirm that's ok.\n\nYou can have my sign-off with a rewritten commit message (below) plus a\nminor grammatical fix to the existing text.\n\n-- >8 --\nFrom: Eric Sunshine <sunshine@sunshineco.com>\nSubject: [PATCH] SubmittingPatches: explain rationale for using --notes with format-patch\n\nWhile here, also change grammatically poor \"three dash lines\" to\n\"three-dash line\".\n\nSuggested-by: Stefan Beller <sbeller@google.com>\nSigned-off-by: Eric Sunshine <sunshine@sunshineco.com>\nSigned-off-by: Stefan Beller <sbeller@google.com>\n---\n Documentation/SubmittingPatches | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\nindex e3c942e..8536bf3 100644\n--- a/Documentation/SubmittingPatches\n+++ b/Documentation/SubmittingPatches\n@@ -176,8 +176,11 @@ message starts, you can put a \"From: \" line to name that person.\n \n You often want to add additional explanation about the patch,\n other than the commit message itself.  Place such \"cover letter\"\n-material between the three dash lines and the diffstat. Git-notes\n-can also be inserted using the `--notes` option.\n+material between the three-dash line and the diffstat.  For\n+patches requiring multiple iterations of review and discussion,\n+an explanation of changes between each iteration can be kept in\n+Git-notes and inserted automatically following the three-dash\n+line via `git format-patch --notes`.\n \n Do not attach the patch as a MIME attachment, compressed or not.\n Do not let your e-mail client send quoted-printable.  Do not let\n-- \n2.2.1.313.gcc831f2\n"}]}