{"thread":{"id":"38242","subject":"[PATCH] transport: simplify duplicating a substring in transport_get() using xmemdupz()","startedAt":"2014-12-24T00:18:31Z","lastAt":"2014-12-24T02:08:47Z","messageCount":2,"participants":["René Scharfe","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"254059","messageId":"549A0657.6010509@web.de","threadId":"38242","inReplyTo":null,"subject":"[PATCH] transport: simplify duplicating a substring in transport_get() using xmemdupz()","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2014-12-24T00:18:31Z","receivedAt":"2014-12-24T00:18:31Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Signed-off-by: Rene Scharfe <l.s.r@web.de>\n---\n transport.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)\n\ndiff --git a/transport.c b/transport.c\nindex 70d38e4..08bcd3a 100644\n--- a/transport.c\n+++ b/transport.c\n@@ -971,9 +971,7 @@ struct transport *transport_get(struct remote *remote, const char *url)\n \t} else {\n \t\t/* Unknown protocol in URL. Pass to external handler. */\n \t\tint len = external_specification_len(url);\n-\t\tchar *handler = xmalloc(len + 1);\n-\t\thandler[len] = 0;\n-\t\tstrncpy(handler, url, len);\n+\t\tchar *handler = xmemdupz(url, len);\n \t\ttransport_helper_init(ret, handler);\n \t}\n \n-- \n2.2.1\n"},{"id":"254063","messageId":"20141224020847.GC29365@google.com","threadId":"38242","inReplyTo":"549A0657.6010509@web.de","subject":"Re: [PATCH] transport: simplify duplicating a substring in transport_get() using xmemdupz()","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2014-12-24T02:08:47Z","receivedAt":"2014-12-24T02:08:47Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"René Scharfe wrote:\n\n> Signed-off-by: Rene Scharfe <l.s.r@web.de>\n> ---\n>  transport.c | 4 +---\n>  1 file changed, 1 insertion(+), 3 deletions(-)\n\nSince external_specification_len(url) is defined to always be less than\nstrlen(url) when is_url(url), this should be safe.\n\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n"}]}