{"thread":{"id":"38239","subject":"[PATCH] commit-tree: simplify parsing of option -S using skip_prefix()","startedAt":"2014-12-24T00:18:11Z","lastAt":"2014-12-24T02:06:13Z","messageCount":2,"participants":["René Scharfe","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"254056","messageId":"549A0643.8090202@web.de","threadId":"38239","inReplyTo":null,"subject":"[PATCH] commit-tree: simplify parsing of option -S using skip_prefix()","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2014-12-24T00:18:11Z","receivedAt":"2014-12-24T00:18:11Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Signed-off-by: Rene Scharfe <l.s.r@web.de>\n---\n builtin/commit-tree.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)\n\ndiff --git a/builtin/commit-tree.c b/builtin/commit-tree.c\nindex 8a66c74..25aa2cd 100644\n--- a/builtin/commit-tree.c\n+++ b/builtin/commit-tree.c\n@@ -66,10 +66,8 @@ int cmd_commit_tree(int argc, const char **argv, const char *prefix)\n \t\t\tcontinue;\n \t\t}\n \n-\t\tif (!memcmp(arg, \"-S\", 2)) {\n-\t\t\tsign_commit = arg + 2;\n+\t\tif (skip_prefix(arg, \"-S\", &sign_commit))\n \t\t\tcontinue;\n-\t\t}\n \n \t\tif (!strcmp(arg, \"--no-gpg-sign\")) {\n \t\t\tsign_commit = NULL;\n-- \n2.2.1\n"},{"id":"254062","messageId":"20141224020613.GB29365@google.com","threadId":"38239","inReplyTo":"549A0643.8090202@web.de","subject":"Re: [PATCH] commit-tree: simplify parsing of option -S using skip_prefix()","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2014-12-24T02:06:13Z","receivedAt":"2014-12-24T02:06:13Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"René Scharfe wrote:\n\n> Signed-off-by: Rene Scharfe <l.s.r@web.de>\n> ---\n>  builtin/commit-tree.c | 4 +---\n>  1 file changed, 1 insertion(+), 3 deletions(-)\n\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n\nThanks.\n"}]}