{"thread":{"id":"38224","subject":"Misbehaving git bisect bad HEAD","startedAt":"2014-12-22T14:04:09Z","lastAt":"2014-12-22T15:56:29Z","messageCount":2,"participants":["Andreas Schwab","Christian Couder"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"253919","messageId":"87y4pzbx2e.fsf@igel.home","threadId":"38224","inReplyTo":null,"subject":"Misbehaving git bisect bad HEAD","fromName":"Andreas Schwab","fromEmail":"schwab@linux-m68k.org","sentAt":"2014-12-22T14:04:09Z","receivedAt":"2014-12-22T14:04:09Z","isPatch":false,"sender":{"key":"schwab@linux-m68k.org","avatar":"https://avatars.githubusercontent.com/u/2175493?v=4"},"body":"Running \"git bisect bad\" should be the same as \"git bisect bad HEAD\",\nshouldn't it?\n\nWhen replaying this bisect log on the Linux kernel tree:\n\ngit bisect start\n# bad: [97bf6af1f928216fd6c5a66e8a57bfa95a659672] Linux 3.19-rc1\ngit bisect bad 97bf6af1f928216fd6c5a66e8a57bfa95a659672\n# good: [b2776bf7149bddd1f4161f14f79520f17fc1d71d] Linux 3.18\ngit bisect good b2776bf7149bddd1f4161f14f79520f17fc1d71d\n# good: [70e71ca0af244f48a5dcf56dc435243792e3a495] Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next\ngit bisect good 70e71ca0af244f48a5dcf56dc435243792e3a495\n# good: [988adfdffdd43cfd841df734664727993076d7cb] Merge branch 'drm-next' of git://people.freedesktop.org/~airlied/linux\ngit bisect good 988adfdffdd43cfd841df734664727993076d7cb\n# good: [b024793188002b9eed452b5f6a04d45003ed5772] staging: rtl8723au: phy_SsPwrSwitch92CU() was never called with bRegSSPwrLvl != 1\ngit bisect good b024793188002b9eed452b5f6a04d45003ed5772\n# good: [66dcff86ba40eebb5133cccf450878f2bba102ef] Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm\ngit bisect good 66dcff86ba40eebb5133cccf450878f2bba102ef\n# bad: [88a57667f2990f00b019d46c8426441c9e516d51] Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip\ngit bisect bad 88a57667f2990f00b019d46c8426441c9e516d51\n# good: [0ec28c37c21a2b4393692e832e11a7573ac545e2] Merge tag 'media/v3.19-2' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media\ngit bisect good 0ec28c37c21a2b4393692e832e11a7573ac545e2\n# good: [c0f486fde3f353232c1cc2fd4d62783ac782a467] Merge tag 'pm+acpi-3.19-rc1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm\ngit bisect good c0f486fde3f353232c1cc2fd4d62783ac782a467\n# bad: [34b85e3574424beb30e4cd163e6da2e2282d2683] Merge tag 'powerpc-3.19-2' of git://git.kernel.org/pub/scm/linux/kernel/git/mpe/linux\ngit bisect bad 34b85e3574424beb30e4cd163e6da2e2282d2683\n# good: [64ec45bff6b3dade2643ed4c0f688a15ecf46ea2] Merge tag 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost\ngit bisect good 64ec45bff6b3dade2643ed4c0f688a15ecf46ea2\n\nRunning \"git bisect bad\" gives this:\n\n$ git bisect bad \nBisecting: 6 revisions left to test after this (roughly 3 steps)\n[ec2aef5a8d3c14272f7a2d29b34f1f8e71f2be5b] power/perf/hv-24x7: Use kmem_cache_free() instead of kfree\n\nRunning \"git bisect bad HEAD\" instead gives this:\n\n$ git bisect bad HEAD\nBisecting: a merge base must be tested\n[56548fc0e86cb9156af7a7e1f15ba78f251dafaf] powerpc/powernv: Return to cpu offline loop when finished in KVM guest\n\nThis is git 2.2.1.\n\nAndreas.\n\n-- \nAndreas Schwab, schwab@linux-m68k.org\nGPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5\n\"And now for something completely different.\"\n"},{"id":"253921","messageId":"CAP8UFD0aBioiHZLB=YHjN09OfPfem1=V14VnfUJAZ0a70=w5gA@mail.gmail.com","threadId":"38224","inReplyTo":"87y4pzbx2e.fsf@igel.home","subject":"Re: Misbehaving git bisect bad HEAD","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2014-12-22T15:56:29Z","receivedAt":"2014-12-22T15:56:29Z","isPatch":false,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"On Mon, Dec 22, 2014 at 3:04 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:\n> Running \"git bisect bad\" should be the same as \"git bisect bad HEAD\",\n> shouldn't it?\n\nYeah, it should.\n\n> When replaying this bisect log on the Linux kernel tree:\n>\n> git bisect start\n> # bad: [97bf6af1f928216fd6c5a66e8a57bfa95a659672] Linux 3.19-rc1\n> git bisect bad 97bf6af1f928216fd6c5a66e8a57bfa95a659672\n> # good: [b2776bf7149bddd1f4161f14f79520f17fc1d71d] Linux 3.18\n> git bisect good b2776bf7149bddd1f4161f14f79520f17fc1d71d\n> # good: [70e71ca0af244f48a5dcf56dc435243792e3a495] Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next\n> git bisect good 70e71ca0af244f48a5dcf56dc435243792e3a495\n> # good: [988adfdffdd43cfd841df734664727993076d7cb] Merge branch 'drm-next' of git://people.freedesktop.org/~airlied/linux\n> git bisect good 988adfdffdd43cfd841df734664727993076d7cb\n> # good: [b024793188002b9eed452b5f6a04d45003ed5772] staging: rtl8723au: phy_SsPwrSwitch92CU() was never called with bRegSSPwrLvl != 1\n> git bisect good b024793188002b9eed452b5f6a04d45003ed5772\n> # good: [66dcff86ba40eebb5133cccf450878f2bba102ef] Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm\n> git bisect good 66dcff86ba40eebb5133cccf450878f2bba102ef\n> # bad: [88a57667f2990f00b019d46c8426441c9e516d51] Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip\n> git bisect bad 88a57667f2990f00b019d46c8426441c9e516d51\n> # good: [0ec28c37c21a2b4393692e832e11a7573ac545e2] Merge tag 'media/v3.19-2' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media\n> git bisect good 0ec28c37c21a2b4393692e832e11a7573ac545e2\n> # good: [c0f486fde3f353232c1cc2fd4d62783ac782a467] Merge tag 'pm+acpi-3.19-rc1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm\n> git bisect good c0f486fde3f353232c1cc2fd4d62783ac782a467\n> # bad: [34b85e3574424beb30e4cd163e6da2e2282d2683] Merge tag 'powerpc-3.19-2' of git://git.kernel.org/pub/scm/linux/kernel/git/mpe/linux\n> git bisect bad 34b85e3574424beb30e4cd163e6da2e2282d2683\n> # good: [64ec45bff6b3dade2643ed4c0f688a15ecf46ea2] Merge tag 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost\n> git bisect good 64ec45bff6b3dade2643ed4c0f688a15ecf46ea2\n>\n> Running \"git bisect bad\" gives this:\n>\n> $ git bisect bad\n> Bisecting: 6 revisions left to test after this (roughly 3 steps)\n> [ec2aef5a8d3c14272f7a2d29b34f1f8e71f2be5b] power/perf/hv-24x7: Use kmem_cache_free() instead of kfree\n>\n> Running \"git bisect bad HEAD\" instead gives this:\n>\n> $ git bisect bad HEAD\n> Bisecting: a merge base must be tested\n> [56548fc0e86cb9156af7a7e1f15ba78f251dafaf] powerpc/powernv: Return to cpu offline loop when finished in KVM guest\n>\n> This is git 2.2.1.\n\nI think it is a very old bug.\n\nThe following patch should fix it:\n\ndiff --git a/git-bisect.sh b/git-bisect.sh\nindex 6cda2b5..26a336a 100755\n--- a/git-bisect.sh\n+++ b/git-bisect.sh\n@@ -200,7 +200,8 @@ is_expected_rev() {\n\n check_expected_revs() {\n        for _rev in \"$@\"; do\n-               if ! is_expected_rev \"$_rev\"\n+               _parsed=$(git rev-parse --verify \"$_rev\")\n+               if ! is_expected_rev \"$_parsed\"\n                then\n                        rm -f \"$GIT_DIR/BISECT_ANCESTORS_OK\"\n                        rm -f \"$GIT_DIR/BISECT_EXPECTED_REV\"\n\nI will send a proper patch later.\n\nThanks,\nChristian.\n"}]}