{"thread":{"id":"38216","subject":"[PATCH] completion: add --irreversible-delete for format-patch","startedAt":"2014-12-21T11:50:07Z","lastAt":"2014-12-22T19:00:59Z","messageCount":3,"participants":["Eric Wong","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"253889","messageId":"20141221115007.GA23500@dcvr.yhbt.net","threadId":"38216","inReplyTo":null,"subject":"[PATCH] completion: add --irreversible-delete for format-patch","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2014-12-21T11:50:07Z","receivedAt":"2014-12-21T11:50:07Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Normally I would use \"-D\", but send-email (which normally passes options\nto format-patch) interprets the \"-D\" as a case-insensitive abbreviation\nfor \"--dry-run\", preventing format-patch from seeing \"-D\".\n\nSigned-off-by: Eric Wong \n---\n Case-insensitivity strikes again! :<\n What a wacky default for Getopt::Long... And it's probably too late\n for us to disable case-insensitivity in CLI parsing for send-email.\n\n contrib/completion/git-completion.bash | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 2fece98..41d8ff8 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1257,6 +1257,7 @@ __git_format_patch_options=\"\n \t--not --all --cover-letter --no-prefix --src-prefix= --dst-prefix=\n \t--inline --suffix= --ignore-if-in-upstream --subject-prefix=\n \t--output-directory --reroll-count --to= --quiet --notes\n+\t--irreversible-delete\n \"\n \n _git_format_patch ()\n-- \nEW\n"},{"id":"253940","messageId":"xmqq3887a5qd.fsf@gitster.dls.corp.google.com","threadId":"38216","inReplyTo":"20141221115007.GA23500@dcvr.yhbt.net","subject":"Re: [PATCH] completion: add --irreversible-delete for format-patch","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-12-22T18:39:54Z","receivedAt":"2014-12-22T18:39:54Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eric Wong writes:\n\n> Normally I would use \"-D\", but send-email (which normally passes options\n> to format-patch) interprets the \"-D\" as a case-insensitive abbreviation\n> for \"--dry-run\", preventing format-patch from seeing \"-D\".\n\nIs this nonstandard option that is designed to produce an\ninapplicable patch so widely used to warrant a completion?\n\nI'd actually understand it if this were to complete \"git show\" and\nfriends, but not for format-patch. I'd actually think we might be\nbetter off forbidding its use for the format-patch command (but not\nfor other commands in the \"git log\" family), not just at the\ncompletion level but at the command line argument parser level.\n\nHmph...\n\n> Signed-off-by: Eric Wong \n> ---\n> Case-insensitivity strikes again! :<\n> What a wacky default for Getopt::Long... And it's probably too late\n> for us to disable case-insensitivity in CLI parsing for send-email.\n>\n> contrib/completion/git-completion.bash | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index 2fece98..41d8ff8 100644\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -1257,6 +1257,7 @@ __git_format_patch_options=\"\n> \t--not --all --cover-letter --no-prefix --src-prefix= --dst-prefix=\n> \t--inline --suffix= --ignore-if-in-upstream --subject-prefix=\n> \t--output-directory --reroll-count --to= --quiet --notes\n> +\t--irreversible-delete\n> \"\n> \n> _git_format_patch ()\n"},{"id":"253942","messageId":"20141222190059.GA19490@dcvr.yhbt.net","threadId":"38216","inReplyTo":"xmqq3887a5qd.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH] completion: add --irreversible-delete for format-patch","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2014-12-22T19:00:59Z","receivedAt":"2014-12-22T19:00:59Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Junio C Hamano wrote:\n> Eric Wong writes:\n> \n> > Normally I would use \"-D\", but send-email (which normally passes options\n> > to format-patch) interprets the \"-D\" as a case-insensitive abbreviation\n> > for \"--dry-run\", preventing format-patch from seeing \"-D\".\n> \n> Is this nonstandard option that is designed to produce an\n> inapplicable patch so widely used to warrant a completion?\n> \n> I'd actually understand it if this were to complete \"git show\" and\n> friends, but not for format-patch. I'd actually think we might be\n> better off forbidding its use for the format-patch command (but not\n> for other commands in the \"git log\" family), not just at the\n> completion level but at the command line argument parser level.\n> \n> Hmph...\n\nI was actually hoping Paul would resurrect his work on getting apply\nto understand --irreversible-delete:\n\nhttp://mid.gmane.org/1343939748-12256-1-git-send-email-paul.gortmaker@windriver.com\n($gmane/202789)\n\nI find this option useful to reduce mail traffic for others to review\nchanges which are already pushed to a public repo.\n\n> > Signed-off-by: Eric Wong \n> > ---\n> > Case-insensitivity strikes again! :<\n> > What a wacky default for Getopt::Long... And it's probably too late\n> > for us to disable case-insensitivity in CLI parsing for send-email.\n> >\n> > contrib/completion/git-completion.bash | 1 +\n> > 1 file changed, 1 insertion(+)\n> >\n> > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> > index 2fece98..41d8ff8 100644\n> > --- a/contrib/completion/git-completion.bash\n> > +++ b/contrib/completion/git-completion.bash\n> > @@ -1257,6 +1257,7 @@ __git_format_patch_options=\"\n> > \t--not --all --cover-letter --no-prefix --src-prefix= --dst-prefix=\n> > \t--inline --suffix= --ignore-if-in-upstream --subject-prefix=\n> > \t--output-directory --reroll-count --to= --quiet --notes\n> > +\t--irreversible-delete\n> > \"\n> > \n> > _git_format_patch ()\n"}]}