{"thread":{"id":"38183","subject":"[PATCH] t5400: remove dead code","startedAt":"2014-12-16T03:58:07Z","lastAt":"2014-12-16T18:58:37Z","messageCount":2,"participants":["Stefan Beller","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"253720","messageId":"1418702287-13771-1-git-send-email-sbeller@google.com","threadId":"38183","inReplyTo":null,"subject":"[PATCH] t5400: remove dead code","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2014-12-16T03:58:07Z","receivedAt":"2014-12-16T03:58:07Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"Signed-off-by: Stefan Beller <sbeller@google.com>\n---\n\nNotes:\n    When debugging the atomic push series I wondered if we want to have\n    tests for the atomic push as well as for atomic send-pack.\n    So I looked at the t5400 test if I could easily add tests for send-pack.\n    I don't think I will add tests in here, but I found dead code.\n    Also I am rambling about the other series this patch is totally unrelated.\n    \n    Removing dead code is always a joy!\n    \n    Thanks,\n    Stefan\n\n t/t5400-send-pack.sh | 16 +---------------\n 1 file changed, 1 insertion(+), 15 deletions(-)\n\ndiff --git a/t/t5400-send-pack.sh b/t/t5400-send-pack.sh\nindex 0736bcb..04cea97 100755\n--- a/t/t5400-send-pack.sh\n+++ b/t/t5400-send-pack.sh\n@@ -76,8 +76,7 @@ test_expect_success 'refuse pushing rewound head without --force' '\n \ttest \"$victim_head\" = \"$pushed_head\"\n '\n \n-test_expect_success \\\n-        'push can be used to delete a ref' '\n+test_expect_success 'push can be used to delete a ref' '\n \t( cd victim && git branch extra master ) &&\n \tgit send-pack ./victim :extra master &&\n \t( cd victim &&\n@@ -196,19 +195,6 @@ rewound_push_setup() {\n \t)\n }\n \n-rewound_push_succeeded() {\n-\tcmp ../parent/.git/refs/heads/master .git/refs/heads/master\n-}\n-\n-rewound_push_failed() {\n-\tif rewound_push_succeeded\n-\tthen\n-\t\tfalse\n-\telse\n-\t\ttrue\n-\tfi\n-}\n-\n test_expect_success 'pushing explicit refspecs respects forcing' '\n \trewound_push_setup &&\n \tparent_orig=$(cd parent && git rev-parse --verify master) &&\n-- \n2.2.0.31.gad78000.dirty\n"},{"id":"253732","messageId":"xmqqfvcfbew2.fsf@gitster.dls.corp.google.com","threadId":"38183","inReplyTo":"1418702287-13771-1-git-send-email-sbeller@google.com","subject":"Re: [PATCH] t5400: remove dead code","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-12-16T18:58:37Z","receivedAt":"2014-12-16T18:58:37Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n"}]}