{"thread":{"id":"38155","subject":"diff: use built-in patterns by default via git attributes","startedAt":"2014-12-09T20:18:30Z","lastAt":"2014-12-09T20:42:47Z","messageCount":2,"participants":["Daniel Hahler","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"253447","messageId":"54875916.7020107@thequod.de","threadId":"38155","inReplyTo":null,"subject":"diff: use built-in patterns by default via git attributes","fromName":"Daniel Hahler","fromEmail":"genml+git-2014@thequod.de","sentAt":"2014-12-09T20:18:30Z","receivedAt":"2014-12-09T20:18:30Z","isPatch":false,"sender":{"key":"genml+git-2014@thequod.de","avatar":null},"body":"Hi,\n\nI'm wondering why the built-in patterns (defined in userdiff.c) are not\nbeing applied by default, e.g. what you would normally do in\ncore.attributesfile via:\n\n    *.py diff=python\n\nWouldn't it make sense to provide certain defaults for attributes, where\nGit provides enhanced patterns?\n\n\nRegards,\nDaniel.\n\n-- \nhttp://daniel.hahler.de/\n\n\n"},{"id":"253452","messageId":"20141209204247.GD12001@peff.net","threadId":"38155","inReplyTo":"54875916.7020107@thequod.de","subject":"Re: diff: use built-in patterns by default via git attributes","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2014-12-09T20:42:47Z","receivedAt":"2014-12-09T20:42:47Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Dec 09, 2014 at 09:18:30PM +0100, Daniel Hahler wrote:\n\n> I'm wondering why the built-in patterns (defined in userdiff.c) are not\n> being applied by default, e.g. what you would normally do in\n> core.attributesfile via:\n> \n>     *.py diff=python\n> \n> Wouldn't it make sense to provide certain defaults for attributes, where\n> Git provides enhanced patterns?\n\nIt's been discussed:\n\n  http://thread.gmane.org/gmane.comp.version-control.git/187269\n\nIt ended up with a lot of back-and-forth over which extensions belonged\nto which type, and whether the C funcname pattern was terrible or not. I\ngot sick of it and dropped the patch.\n\nYou are welcome to try resurrecting it. :) It might help to read the\ndiscussion and drop any contentious names. Since that thread, the C/C++\npattern has improved greatly, so it might not meet so much resistance.\n\n-Peff\n"}]}