{"thread":{"id":"38068","subject":"[PATCH] t0050-*.sh: mark the rename (case change) test as passing","startedAt":"2014-11-28T16:57:18Z","lastAt":"2014-11-28T21:13:49Z","messageCount":2,"participants":["Ramsay Jones","Eric Sunshine"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"252667","messageId":"5478A96E.8030706@ramsay1.demon.co.uk","threadId":"38068","inReplyTo":null,"subject":"[PATCH] t0050-*.sh: mark the rename (case change) test as passing","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2014-11-28T16:57:18Z","receivedAt":"2014-11-28T16:57:18Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSince commit baa37bff (\"mv: allow renaming to fix case on case\ninsensitive filesystems\", 08-05-2014), the 'git mv' command has\nbeen able to rename a file, to one which differs only in case,\non a case insensitive filesystem.\n\nThis results in the 'rename (case change)' test, which used to fail\nprior to this commit, to now (unexpectedly) pass. Mark this test as\npassing.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n\nHi Junio,\n\nI noticed this last week while testing on cygwin. I have only tested\nthis on (64-bit) cygwin/ntfs, but I would assume that other case\ninsensitive filesystems would be OK, since there have been no complaints\nabout t6039-merge-ignorecase.sh not working.\n\nNote that I didn't remove $test_case, despite having removed its last\nuse in this test, in case there will be a future need. I'm not sure\nthere will be a future need, of course, so if you would rather I got\nrid of it, just let me know.\n\nATB,\nRamsay Jones\n\n t/t0050-filesystem.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t0050-filesystem.sh b/t/t0050-filesystem.sh\nindex 6b3cedc..988c392 100755\n--- a/t/t0050-filesystem.sh\n+++ b/t/t0050-filesystem.sh\n@@ -64,7 +64,7 @@ test_expect_success \"setup case tests\" '\n \tgit checkout -f master\n '\n \n-$test_case 'rename (case change)' '\n+test_expect_success 'rename (case change)' '\n \tgit mv camelcase CamelCase &&\n \tgit commit -m \"rename\"\n '\n-- \n2.1.0\n"},{"id":"252672","messageId":"CAPig+cRbdy6obKNvBWqvvEQD+MwXcNw+0T0c-f1AuPA+_c=8=Q@mail.gmail.com","threadId":"38068","inReplyTo":"5478A96E.8030706@ramsay1.demon.co.uk","subject":"Re: [PATCH] t0050-*.sh: mark the rename (case change) test as passing","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2014-11-28T21:13:49Z","receivedAt":"2014-11-28T21:13:49Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Fri, Nov 28, 2014 at 11:57 AM, Ramsay Jones\n<ramsay@ramsay1.demon.co.uk> wrote:\n> Since commit baa37bff (\"mv: allow renaming to fix case on case\n> insensitive filesystems\", 08-05-2014), the 'git mv' command has\n> been able to rename a file, to one which differs only in case,\n> on a case insensitive filesystem.\n>\n> This results in the 'rename (case change)' test, which used to fail\n> prior to this commit, to now (unexpectedly) pass. Mark this test as\n> passing.\n>\n> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n> ---\n>\n> Hi Junio,\n>\n> I noticed this last week while testing on cygwin. I have only tested\n> this on (64-bit) cygwin/ntfs, but I would assume that other case\n> insensitive filesystems would be OK, since there have been no complaints\n> about t6039-merge-ignorecase.sh not working.\n\nI tested and verified that this patch is also needed on Mac OS X (as expected).\n\n> Note that I didn't remove $test_case, despite having removed its last\n> use in this test, in case there will be a future need. I'm not sure\n> there will be a future need, of course, so if you would rather I got\n> rid of it, just let me know.\n>\n> ATB,\n> Ramsay Jones\n>\n>  t/t0050-filesystem.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/t/t0050-filesystem.sh b/t/t0050-filesystem.sh\n> index 6b3cedc..988c392 100755\n> --- a/t/t0050-filesystem.sh\n> +++ b/t/t0050-filesystem.sh\n> @@ -64,7 +64,7 @@ test_expect_success \"setup case tests\" '\n>         git checkout -f master\n>  '\n>\n> -$test_case 'rename (case change)' '\n> +test_expect_success 'rename (case change)' '\n>         git mv camelcase CamelCase &&\n>         git commit -m \"rename\"\n>  '\n> --\n> 2.1.0\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n"}]}