{"thread":{"id":"38041","subject":"[PATCHv2 3/3] string_list: Remove string_list_insert_at_index from its API","startedAt":"2014-11-25T01:31:40Z","lastAt":"2014-11-25T01:31:40Z","messageCount":1,"participants":["Stefan Beller"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"252481","messageId":"1416879100-32321-1-git-send-email-sbeller@google.com","threadId":"38041","inReplyTo":"CAPc5daXuecn9bvuQ4qa6p5Ln-RqoUxkh=9nfOZCWAdwHZYJD5g@mail.gmail.com","subject":"[PATCHv2 3/3] string_list: Remove string_list_insert_at_index from its API","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2014-11-25T01:31:40Z","receivedAt":"2014-11-25T01:31:40Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"Nobody is using this function any more, let's get rid of it.\n\nSigned-off-by: Stefan Beller <sbeller@google.com>\n---\n string-list.c | 8 +-------\n string-list.h | 2 --\n 2 files changed, 1 insertion(+), 9 deletions(-)\n\ndiff --git a/string-list.c b/string-list.c\nindex c5aa076..9584fa6 100644\n--- a/string-list.c\n+++ b/string-list.c\n@@ -59,13 +59,7 @@ static int add_entry(int insert_at, struct string_list *list, const char *string\n \n struct string_list_item *string_list_insert(struct string_list *list, const char *string)\n {\n-\treturn string_list_insert_at_index(list, -1, string);\n-}\n-\n-struct string_list_item *string_list_insert_at_index(struct string_list *list,\n-\t\t\t\t\t\t     int insert_at, const char *string)\n-{\n-\tint index = add_entry(insert_at, list, string);\n+\tint index = add_entry(-1, list, string);\n \n \tif (index < 0)\n \t\tindex = -1 - index;\ndiff --git a/string-list.h b/string-list.h\nindex 40ffe0c..ee9b100 100644\n--- a/string-list.h\n+++ b/string-list.h\n@@ -61,8 +61,6 @@ int string_list_find_insert_index(const struct string_list *list, const char *st\n  * Returns the string_list_item, the string is part of.\n  */\n struct string_list_item *string_list_insert(struct string_list *list, const char *string);\n-struct string_list_item *string_list_insert_at_index(struct string_list *list,\n-\t\t\t\t\t\t     int insert_at, const char *string);\n \n /*\n  * Checks if the given string is part of a sorted list. If it is part of the list,\n-- \n2.2.0.rc3\n"}]}