{"thread":{"id":"37966","subject":"[PATCH v3] allow TTY tests to run under recent Mac OS","startedAt":"2014-11-14T17:08:05Z","lastAt":"2014-11-14T19:34:04Z","messageCount":2,"participants":["Mike Blume","Junio C Hamano"],"isPatch":true,"patchVersion":3,"patchTotal":null},"messages":[{"id":"251891","messageId":"1415984885-59073-1-git-send-email-blume.mike@gmail.com","threadId":"37966","inReplyTo":null,"subject":"[PATCH v3] allow TTY tests to run under recent Mac OS","fromName":"Mike Blume","fromEmail":"blume.mike@gmail.com","sentAt":"2014-11-14T17:08:05Z","receivedAt":"2014-11-14T17:08:05Z","isPatch":true,"sender":{"key":"blume.mike@gmail.com","avatar":"https://gravatar.com/avatar/1a7b440e1d942425ff4098ac7fc15b86b30cecaa56e1692a7ef8b5939ba25ea7?d=mp&s=160"},"body":"listed bug doesn't reproduce on Mac OS Yosemite or Mavericks. For now,\njust enable TTY on Mavericks and higher\n\nSigned-off-by: Mike Blume <blume.mike@gmail.com>\nImproved-by: Junio C Hamano <gitster@pobox.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\nImproved-by: John Szakmeister <john@szakmeister.net>\n---\n t/lib-terminal.sh | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)\n\ndiff --git a/t/lib-terminal.sh b/t/lib-terminal.sh\nindex 5184549..7348f7e 100644\n--- a/t/lib-terminal.sh\n+++ b/t/lib-terminal.sh\n@@ -29,7 +29,10 @@ test_lazy_prereq TTY '\n \t# After 2000 iterations or so it hangs.\n \t# https://rt.cpan.org/Ticket/Display.html?id=65692\n \t#\n-\ttest \"$(uname -s)\" != Darwin &&\n+\t# Under Mac OS X 10.10.1 and Perl 5.18.2, this problem\n+\t# appears to be gone.\n+\t#\n+\ttest \"$(uname -s)\" != Darwin || test \"$(uname -r | cut -d. -f1)\" -ge 13 &&\n \n \tperl \"$TEST_DIRECTORY\"/test-terminal.perl \\\n \t\tsh -c \"test -t 1 && test -t 2\"\n-- \n2.2.0.rc1.197.g60bf093\n"},{"id":"251899","messageId":"xmqqsihl37bn.fsf@gitster.dls.corp.google.com","threadId":"37966","inReplyTo":"1415984885-59073-1-git-send-email-blume.mike@gmail.com","subject":"Re: [PATCH v3] allow TTY tests to run under recent Mac OS","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-11-14T19:34:04Z","receivedAt":"2014-11-14T19:34:04Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Mike Blume <blume.mike@gmail.com> writes:\n\n> listed bug doesn't reproduce on Mac OS Yosemite or Mavericks. For now,\n> just enable TTY on Mavericks and higher\n\nWhat is \"listed bug\" that begins a sentence in lowercase?\nEnd the description in full-stop, s/higher/&./;\n\n>\n> Signed-off-by: Mike Blume <blume.mike@gmail.com>\n> Improved-by: Junio C Hamano <gitster@pobox.com>\n> Signed-off-by: Junio C Hamano <gitster@pobox.com>\n> Improved-by: John Szakmeister <john@szakmeister.net>\n> ---\n>  t/lib-terminal.sh | 5 ++++-\n>  1 file changed, 4 insertions(+), 1 deletion(-)\n>\n> diff --git a/t/lib-terminal.sh b/t/lib-terminal.sh\n> index 5184549..7348f7e 100644\n> --- a/t/lib-terminal.sh\n> +++ b/t/lib-terminal.sh\n> @@ -29,7 +29,10 @@ test_lazy_prereq TTY '\n>  \t# After 2000 iterations or so it hangs.\n>  \t# https://rt.cpan.org/Ticket/Display.html?id=65692\n>  \t#\n> -\ttest \"$(uname -s)\" != Darwin &&\n> +\t# Under Mac OS X 10.10.1 and Perl 5.18.2, this problem\n> +\t# appears to be gone.\n> +\t#\n> +\ttest \"$(uname -s)\" != Darwin || test \"$(uname -r | cut -d. -f1)\" -ge 13 &&\n\nIs that \"13\" you have here consistent with \"10.10.1\" above in the\ncomment?  I am not a Mac person, but I vaguely recall that they are\nusually off by four.\n\n>  \n>  \tperl \"$TEST_DIRECTORY\"/test-terminal.perl \\\n>  \t\tsh -c \"test -t 1 && test -t 2\"\n"}]}