{"thread":{"id":"37964","subject":"--trust-exit-code not working","startedAt":"2014-11-14T16:12:35Z","lastAt":"2014-11-14T21:55:28Z","messageCount":4,"participants":["Adria Farres","Junio C Hamano","David Aguilar"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"251889","messageId":"20141114161235.GA30086@vimeitor","threadId":"37964","inReplyTo":null,"subject":"--trust-exit-code not working","fromName":"Adria Farres","fromEmail":"14farresa@gmail.com","sentAt":"2014-11-14T16:12:35Z","receivedAt":"2014-11-14T16:12:35Z","isPatch":false,"sender":{"key":"14farresa@gmail.com","avatar":null},"body":"Hello!,\n\nI sent an email last week, but I'm not sure if I sent it incorrectly, or the\nformatting was very bad, or it went unnoticed. A few days ago a great soul was\nkind enough to create the --trust-exit-code option that made git respect the\nexit code of the difftool. Unfortunately, I haven't been able to make it work.\nExiting vimdiff with :cq doesn't seem to make git quit, as it keeps pushing new\nfiles to be diffed. I tried meld and the exact same thing. I'm confident that\nexiting with :cq gives an error, as I have checked it, and I'm using git\n2.2.0.rc1.\n\nAm I missing something important? Has anyone managed to make it work with\nvimdiff and meld? Sorry for bringing that up so late and for being a\ndisturbance.\n\nThank you,\n\nAdria\n"},{"id":"251911","messageId":"xmqq389l347n.fsf@gitster.dls.corp.google.com","threadId":"37964","inReplyTo":"20141114161235.GA30086@vimeitor","subject":"Re: --trust-exit-code not working","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-11-14T20:41:16Z","receivedAt":"2014-11-14T20:41:16Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"David, I think this is about your 2b52123f (difftool: add support\nfor --trust-exit-code, 2014-10-26).  If you have time can you help\nAdria?\n\nThanks.\n\n\nAdria Farres <14farresa@gmail.com> writes:\n\n> Hello!,\n>\n> I sent an email last week, but I'm not sure if I sent it incorrectly, or the\n> formatting was very bad, or it went unnoticed. A few days ago a great soul was\n> kind enough to create the --trust-exit-code option that made git respect the\n> exit code of the difftool. Unfortunately, I haven't been able to make it work.\n> Exiting vimdiff with :cq doesn't seem to make git quit, as it keeps pushing new\n> files to be diffed. I tried meld and the exact same thing. I'm confident that\n> exiting with :cq gives an error, as I have checked it, and I'm using git\n> 2.2.0.rc1.\n>\n> Am I missing something important? Has anyone managed to make it work with\n> vimdiff and meld? Sorry for bringing that up so late and for being a\n> disturbance.\n>\n> Thank you,\n>\n> Adria\n"},{"id":"251913","messageId":"20141114210711.GA55473@gmail.com","threadId":"37964","inReplyTo":"xmqq389l347n.fsf@gitster.dls.corp.google.com","subject":"Re: --trust-exit-code not working","fromName":"David Aguilar","fromEmail":"davvid@gmail.com","sentAt":"2014-11-14T21:07:12Z","receivedAt":"2014-11-14T21:07:12Z","isPatch":false,"sender":{"key":"davvid@gmail.com","avatar":"https://avatars.githubusercontent.com/u/13196?v=4"},"body":"On Fri, Nov 14, 2014 at 12:41:16PM -0800, Junio C Hamano wrote:\n> David, I think this is about your 2b52123f (difftool: add support\n> for --trust-exit-code, 2014-10-26).  If you have time can you help\n> Adria?\n> \n> Thanks.\n\n\nYup, I'll take a look when I have a chance.\nMy first guess would be that the vim scriptlet is not passing\ndown the status, but I'll have to take a closer look.\n\nFWIW, I thought I had actually tested using vim,\nbut I'll re-test and verify.\n\n\n> Adria Farres <14farresa@gmail.com> writes:\n> \n> > Hello!,\n> >\n> > I sent an email last week, but I'm not sure if I sent it incorrectly, or the\n> > formatting was very bad, or it went unnoticed. A few days ago a great soul was\n> > kind enough to create the --trust-exit-code option that made git respect the\n> > exit code of the difftool. Unfortunately, I haven't been able to make it work.\n> > Exiting vimdiff with :cq doesn't seem to make git quit, as it keeps pushing new\n> > files to be diffed. I tried meld and the exact same thing. I'm confident that\n> > exiting with :cq gives an error, as I have checked it, and I'm using git\n> > 2.2.0.rc1.\n> >\n> > Am I missing something important? Has anyone managed to make it work with\n> > vimdiff and meld? Sorry for bringing that up so late and for being a\n> > disturbance.\n> >\n> > Thank you,\n> >\n> > Adria\n\n-- \nDavid\n"},{"id":"251917","messageId":"20141114215527.GA93845@gmail.com","threadId":"37964","inReplyTo":"20141114161235.GA30086@vimeitor","subject":"Re: --trust-exit-code not working","fromName":"David Aguilar","fromEmail":"davvid@gmail.com","sentAt":"2014-11-14T21:55:28Z","receivedAt":"2014-11-14T21:55:28Z","isPatch":false,"sender":{"key":"davvid@gmail.com","avatar":"https://avatars.githubusercontent.com/u/13196?v=4"},"body":"On Fri, Nov 14, 2014 at 05:12:35PM +0100, Adria Farres wrote:\n> Hello!,\n> \n> I sent an email last week, but I'm not sure if I sent it incorrectly, or the\n> formatting was very bad, or it went unnoticed. A few days ago a great soul was\n\nNah, I was just very busy and it slipped through the cracks.\nSorry 'bout that ~ I was meaning to get back to it.\n\n> kind enough to create the --trust-exit-code option that made git respect the\n> exit code of the difftool. Unfortunately, I haven't been able to make it work.\n> Exiting vimdiff with :cq doesn't seem to make git quit, as it keeps pushing new\n> files to be diffed. I tried meld and the exact same thing. I'm confident that\n> exiting with :cq gives an error, as I have checked it, and I'm using git\n> 2.2.0.rc1.\n> \n> Am I missing something important? Has anyone managed to make it work with\n> vimdiff and meld? Sorry for bringing that up so late and for being a\n> disturbance.\n> \n> Thank you,\n\nThanks for testing, Adria.\n\nIf you could test my new patch we would very much appreciate it;\nadding a Tested-by: attribution line to the commit with your\nname would be very nice.\n\ncheers,\n-- \nDavid\n"}]}