{"thread":{"id":"37957","subject":"[PATCH] allow TTY tests to run under recent Mac OS","startedAt":"2014-11-13T22:01:27Z","lastAt":"2014-11-14T05:24:44Z","messageCount":4,"participants":["Mike Blume","Junio C Hamano","Michael Blume","Torsten Bögershausen"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"251865","messageId":"1415916087-18953-1-git-send-email-blume.mike@gmail.com","threadId":"37957","inReplyTo":null,"subject":"[PATCH] allow TTY tests to run under recent Mac OS","fromName":"Mike Blume","fromEmail":"blume.mike@gmail.com","sentAt":"2014-11-13T22:01:27Z","receivedAt":"2014-11-13T22:01:27Z","isPatch":true,"sender":{"key":"blume.mike@gmail.com","avatar":"https://gravatar.com/avatar/1a7b440e1d942425ff4098ac7fc15b86b30cecaa56e1692a7ef8b5939ba25ea7?d=mp&s=160"},"body":"listed bug doesn't reproduce on Mac OS Yosemite. For now, just enable\nTTY on Yosemite and higher\n\nSigned-off-by: Mike Blume <blume.mike@gmail.com>\n---\n t/lib-terminal.sh | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)\n\ndiff --git a/t/lib-terminal.sh b/t/lib-terminal.sh\nindex 5184549..1311ce0 100644\n--- a/t/lib-terminal.sh\n+++ b/t/lib-terminal.sh\n@@ -29,7 +29,10 @@ test_lazy_prereq TTY '\n \t# After 2000 iterations or so it hangs.\n \t# https://rt.cpan.org/Ticket/Display.html?id=65692\n \t#\n-\ttest \"$(uname -s)\" != Darwin &&\n+\t# Under Mac OS X 10.10.1 and Perl 5.18.2, this problem\n+\t# appears to be gone.\n+\t#\n+\t[[ test \"$(uname -s)\" != Darwin || test \"$(uname -r | cut -d. -f1\") -ge 14 ]] &&\n \n \tperl \"$TEST_DIRECTORY\"/test-terminal.perl \\\n \t\tsh -c \"test -t 1 && test -t 2\"\n-- \n2.2.0.rc1.197.g60bf093\n"},{"id":"251866","messageId":"xmqq1tp6zqq1.fsf@gitster.dls.corp.google.com","threadId":"37957","inReplyTo":"1415916087-18953-1-git-send-email-blume.mike@gmail.com","subject":"Re: [PATCH] allow TTY tests to run under recent Mac OS","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-11-13T22:21:42Z","receivedAt":"2014-11-13T22:21:42Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Mike Blume <blume.mike@gmail.com> writes:\n\n> listed bug doesn't reproduce on Mac OS Yosemite. For now, just enable\n> TTY on Yosemite and higher\n>\n> Signed-off-by: Mike Blume <blume.mike@gmail.com>\n> ---\n>  t/lib-terminal.sh | 5 ++++-\n>  1 file changed, 4 insertions(+), 1 deletion(-)\n>\n> diff --git a/t/lib-terminal.sh b/t/lib-terminal.sh\n> index 5184549..1311ce0 100644\n> --- a/t/lib-terminal.sh\n> +++ b/t/lib-terminal.sh\n> @@ -29,7 +29,10 @@ test_lazy_prereq TTY '\n>  \t# After 2000 iterations or so it hangs.\n>  \t# https://rt.cpan.org/Ticket/Display.html?id=65692\n>  \t#\n> -\ttest \"$(uname -s)\" != Darwin &&\n> +\t# Under Mac OS X 10.10.1 and Perl 5.18.2, this problem\n> +\t# appears to be gone.\n> +\t#\n> +\t[[ test \"$(uname -s)\" != Darwin || test \"$(uname -r | cut -d. -f1\") -ge 14 ]] &&\n\nThis is designed to be a plain vanilla POSIX shell script.  Please\navoid these double brackets.\n\n>  \n>  \tperl \"$TEST_DIRECTORY\"/test-terminal.perl \\\n>  \t\tsh -c \"test -t 1 && test -t 2\"\n"},{"id":"251869","messageId":"CAO2U3QgbCVnF=TFWD5ZFjMSc=ez21KObSdF=v75DfDSJhH8A5Q@mail.gmail.com","threadId":"37957","inReplyTo":"xmqq1tp6zqq1.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH] allow TTY tests to run under recent Mac OS","fromName":"Michael Blume","fromEmail":"blume.mike@gmail.com","sentAt":"2014-11-13T22:40:50Z","receivedAt":"2014-11-13T22:40:50Z","isPatch":true,"sender":{"key":"blume.mike@gmail.com","avatar":"https://gravatar.com/avatar/1a7b440e1d942425ff4098ac7fc15b86b30cecaa56e1692a7ef8b5939ba25ea7?d=mp&s=160"},"body":"ah, sorry, didn't realize those were bash-only\n\nOn Thu, Nov 13, 2014 at 2:21 PM, Junio C Hamano <gitster@pobox.com> wrote:\n> Mike Blume <blume.mike@gmail.com> writes:\n>\n>> listed bug doesn't reproduce on Mac OS Yosemite. For now, just enable\n>> TTY on Yosemite and higher\n>>\n>> Signed-off-by: Mike Blume <blume.mike@gmail.com>\n>> ---\n>>  t/lib-terminal.sh | 5 ++++-\n>>  1 file changed, 4 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/t/lib-terminal.sh b/t/lib-terminal.sh\n>> index 5184549..1311ce0 100644\n>> --- a/t/lib-terminal.sh\n>> +++ b/t/lib-terminal.sh\n>> @@ -29,7 +29,10 @@ test_lazy_prereq TTY '\n>>       # After 2000 iterations or so it hangs.\n>>       # https://rt.cpan.org/Ticket/Display.html?id=65692\n>>       #\n>> -     test \"$(uname -s)\" != Darwin &&\n>> +     # Under Mac OS X 10.10.1 and Perl 5.18.2, this problem\n>> +     # appears to be gone.\n>> +     #\n>> +     [[ test \"$(uname -s)\" != Darwin || test \"$(uname -r | cut -d. -f1\") -ge 14 ]] &&\n>\n> This is designed to be a plain vanilla POSIX shell script.  Please\n> avoid these double brackets.\n>\n>>\n>>       perl \"$TEST_DIRECTORY\"/test-terminal.perl \\\n>>               sh -c \"test -t 1 && test -t 2\"\n"},{"id":"251873","messageId":"5465921C.7000904@web.de","threadId":"37957","inReplyTo":"1415916087-18953-1-git-send-email-blume.mike@gmail.com","subject":"Re: [PATCH] allow TTY tests to run under recent Mac OS","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2014-11-14T05:24:44Z","receivedAt":"2014-11-14T05:24:44Z","isPatch":true,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"On 11/13/2014 11:01 PM, Mike Blume wrote:\n> listed bug doesn't reproduce on Mac OS Yosemite. For now, just enable\n> TTY on Yosemite and higher\n>\n> Signed-off-by: Mike Blume <blume.mike@gmail.com>\n> ---\n>   t/lib-terminal.sh | 5 ++++-\n>   1 file changed, 4 insertions(+), 1 deletion(-)\n>\n> diff --git a/t/lib-terminal.sh b/t/lib-terminal.sh\n> index 5184549..1311ce0 100644\n> --- a/t/lib-terminal.sh\n> +++ b/t/lib-terminal.sh\n> @@ -29,7 +29,10 @@ test_lazy_prereq TTY '\n>   \t# After 2000 iterations or so it hangs.\n>   \t# https://rt.cpan.org/Ticket/Display.html?id=65692\n>   \t#\n> -\ttest \"$(uname -s)\" != Darwin &&\n> +\t# Under Mac OS X 10.10.1 and Perl 5.18.2, this problem\n> +\t# appears to be gone.\n> +\t#\n> +\t[[ test \"$(uname -s)\" != Darwin || test \"$(uname -r | cut -d. -f1\") -ge 14 ]] &&\nThis seems to be bash syntax (the \"[[\" can (and should) be easily avoided)\n\nAnother question:\nIs this related to perl or Mac OS ?\nThe commit message is indicating that the combination of Mac OS 10.10.1 \nand perl 5.18.2\nis working, but the code does not reflect this.\nDoes it make sense to test for the perl version in the code?\nOr is it OK to mention\n\n  Under Mac OS X 10.10.1 which ships with Perl 5.18.2, this problem....\n\n\n\n>   \n>   \tperl \"$TEST_DIRECTORY\"/test-terminal.perl \\\n>   \t\tsh -c \"test -t 1 && test -t 2\"\n"}]}