{"thread":{"id":"37956","subject":"appropriate mailing list for gitk patches","startedAt":"2014-11-13T21:10:00Z","lastAt":"2014-11-13T21:32:28Z","messageCount":2,"participants":["lennart spitzner","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"251853","messageId":"54651E28.9090100@informatik.uni-kiel.de","threadId":"37956","inReplyTo":null,"subject":"appropriate mailing list for gitk patches","fromName":"lennart spitzner","fromEmail":"lsp@informatik.uni-kiel.de","sentAt":"2014-11-13T21:10:00Z","receivedAt":"2014-11-13T21:10:00Z","isPatch":false,"sender":{"key":"lsp@informatik.uni-kiel.de","avatar":null},"body":"Hello folks,\n\nI have a patch for gitk. Should i send it to this list, or is there some\nother?  git/Documentation/SubmittingPatches mentions\ngit://ozlabs.org/~paulus/gitk (the master of which i based my commit\non), but never mentions any list(s) by name (only \"the Git mailing\nlist\", which i presume is this one).\n\nAlso, a minor question regarding patches: I wondered why patches do not\nmention the commit id that the patch(es) are based on. My current guess\nis that the diffs containing the sha1's is considered sufficient. Is\nthis the case? Are there more/other aspects?\n\nLennart\n"},{"id":"251856","messageId":"xmqqegt6zt03.fsf@gitster.dls.corp.google.com","threadId":"37956","inReplyTo":"54651E28.9090100@informatik.uni-kiel.de","subject":"Re: appropriate mailing list for gitk patches","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-11-13T21:32:28Z","receivedAt":"2014-11-13T21:32:28Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"lennart spitzner <lsp@informatik.uni-kiel.de> writes:\n\n> I have a patch for gitk. Should i send it to this list, or is there some\n> other?  git/Documentation/SubmittingPatches mentions\n> git://ozlabs.org/~paulus/gitk (the master of which i based my commit\n> on), but never mentions any list(s) by name (only \"the Git mailing\n> list\", which i presume is this one).\n\nYou are in the right place ;-)  Make sure you Cc: paulus as the area\nmaintainer on your patches, though.\n\n> Also, a minor question regarding patches: I wondered why patches do not\n> mention the commit id that the patch(es) are based on. My current guess\n> is that the diffs containing the sha1's is considered sufficient. Is\n> this the case? Are there more/other aspects?\n\nA new development is done based on the tip of 'master' by convention\naround here, so people know it is meant to apply there unless the\npatch submitter says otherwise explicitly.\n\nPeople send patches on a random commit of their own that is not\navailable to the public (e.g. you may be working on some big topic,\ndiscover a simple bug that is not related to the topic, and create a\nfix for that simple bug right there on top and send that out as a\npatch).  Base commit object name would be useless in such a case\nanyway.\n"}]}