{"thread":{"id":"37949","subject":"[PATCH] t5705: Use the correct file:// URL","startedAt":"2014-11-13T07:36:07Z","lastAt":"2014-11-13T16:37:48Z","messageCount":3,"participants":["Torsten Bögershausen","Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"251790","messageId":"54645F67.30008@web.de","threadId":"37949","inReplyTo":null,"subject":"[PATCH] t5705: Use the correct file:// URL","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2014-11-13T07:36:07Z","receivedAt":"2014-11-13T07:36:07Z","isPatch":true,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"A URL like file;//. is (no longer) supported by Git:\nTypically there is no host, and RFC1738 says that file:///<path>\nshould be used.\n\nUpdate t5705 to use a working URL.\n\nReported-by: Michael Blume <blume.mike@gmail.com>\nSigned-off-by: Torsten Bögershausen <tboegi@web.de>\n---\n t/t5705-clone-2gb.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t5705-clone-2gb.sh b/t/t5705-clone-2gb.sh\nindex e9783c3..191d6d3 100755\n--- a/t/t5705-clone-2gb.sh\n+++ b/t/t5705-clone-2gb.sh\n@@ -46,7 +46,7 @@ test_expect_success CLONE_2GB 'clone - bare' '\n \n test_expect_success CLONE_2GB 'clone - with worktree, file:// protocol' '\n \n-\tgit clone file://. clone-wt\n+\tgit clone \"file://$(pwd)\" clone-wt\n \n '\n \n-- \n1.9.1.dirty\n"},{"id":"251793","messageId":"20141113091724.GB8329@peff.net","threadId":"37949","inReplyTo":"54645F67.30008@web.de","subject":"Re: [PATCH] t5705: Use the correct file:// URL","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2014-11-13T09:17:24Z","receivedAt":"2014-11-13T09:17:24Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Nov 13, 2014 at 08:36:07AM +0100, Torsten Bögershausen wrote:\n\n> A URL like file;//. is (no longer) supported by Git:\n> Typically there is no host, and RFC1738 says that file:///<path>\n> should be used.\n> \n> Update t5705 to use a working URL.\n\nInteresting. This looks like it was unintentionally lost in c59ab2e\n(connect.c: refactor url parsing, 2013-11-28). Given RFC1738, and that\nthis is the first notice of it (and that it is not even a real use case,\nbut something questionable in the test script), it's probably OK to\ndeclare the syntax dead and not treat it like a regression.\n\n-Peff\n"},{"id":"251824","messageId":"xmqqtx232h0j.fsf@gitster.dls.corp.google.com","threadId":"37949","inReplyTo":"20141113091724.GB8329@peff.net","subject":"Re: [PATCH] t5705: Use the correct file:// URL","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-11-13T16:37:48Z","receivedAt":"2014-11-13T16:37:48Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King <peff@peff.net> writes:\n\n> On Thu, Nov 13, 2014 at 08:36:07AM +0100, Torsten Bögershausen wrote:\n>\n>> A URL like file;//. is (no longer) supported by Git:\n>> Typically there is no host, and RFC1738 says that file:///<path>\n>> should be used.\n>> \n>> Update t5705 to use a working URL.\n>\n> Interesting. This looks like it was unintentionally lost in c59ab2e\n> (connect.c: refactor url parsing, 2013-11-28). Given RFC1738, and that\n> this is the first notice of it (and that it is not even a real use case,\n> but something questionable in the test script), it's probably OK to\n> declare the syntax dead and not treat it like a regression.\n\nYeah, I tend to agree.  I do not think there is any <scheme>:// that\nlets you say things relative to something that is not \"root\" of the\nnamespace, and it was a bug the old test depended on that we did not\nnotice it as an error when \"file://.\" tried to refer to \"the current\ndirectory\".\n"}]}