{"thread":{"id":"37945","subject":"TTY tests are unnecessarily suppressed under Mac OS","startedAt":"2014-11-12T22:25:52Z","lastAt":"2014-11-13T21:10:26Z","messageCount":3,"participants":["Michael Blume","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"251781","messageId":"CAO2U3QhB6rSfJn5ODE8-n2XWuBw8BePqDpQbNdx6LyWy=OFbcg@mail.gmail.com","threadId":"37945","inReplyTo":null,"subject":"TTY tests are unnecessarily suppressed under Mac OS","fromName":"Michael Blume","fromEmail":"blume.mike@gmail.com","sentAt":"2014-11-12T22:25:52Z","receivedAt":"2014-11-12T22:25:52Z","isPatch":false,"sender":{"key":"blume.mike@gmail.com","avatar":"https://gravatar.com/avatar/1a7b440e1d942425ff4098ac7fc15b86b30cecaa56e1692a7ef8b5939ba25ea7?d=mp&s=160"},"body":">From lib_terminal.sh:\n\n# Reading from the pty master seems to get stuck _sometimes_\n# on Mac OS X 10.5.0, using Perl 5.10.0 or 5.8.9.\n#\n# Reproduction recipe: run\n#\n# i=0\n# while ./test-terminal.perl echo hi $i\n# do\n# : $((i = $i + 1))\n# done\n#\n# After 2000 iterations or so it hangs.\n# https://rt.cpan.org/Ticket/Display.html?id=65692\n#\ntest \"$(uname -s)\" != Darwin &&\n\nI tried the reproduction recipe on my mac and couldn't reproduce, so\nit may make sense to take this switch out? In any case, I've set my\nautomated mac build to include TTY tests\n"},{"id":"251848","messageId":"20141113201959.GD3869@peff.net","threadId":"37945","inReplyTo":"CAO2U3QhB6rSfJn5ODE8-n2XWuBw8BePqDpQbNdx6LyWy=OFbcg@mail.gmail.com","subject":"Re: TTY tests are unnecessarily suppressed under Mac OS","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2014-11-13T20:20:00Z","receivedAt":"2014-11-13T20:20:00Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Nov 12, 2014 at 02:25:52PM -0800, Michael Blume wrote:\n\n> From lib_terminal.sh:\n> \n> # Reading from the pty master seems to get stuck _sometimes_\n> # on Mac OS X 10.5.0, using Perl 5.10.0 or 5.8.9.\n> #\n> # Reproduction recipe: run\n> #\n> # i=0\n> # while ./test-terminal.perl echo hi $i\n> # do\n> # : $((i = $i + 1))\n> # done\n> #\n> # After 2000 iterations or so it hangs.\n> # https://rt.cpan.org/Ticket/Display.html?id=65692\n> #\n> test \"$(uname -s)\" != Darwin &&\n> \n> I tried the reproduction recipe on my mac and couldn't reproduce, so\n> it may make sense to take this switch out? In any case, I've set my\n> automated mac build to include TTY tests\n\n10.5.0 is pretty ancient at this point; I can well believe that the\nupstream problem has been fixed. It would be nice if we knew in which\nversion it was fixed, though. Just dropping the restriction risks people\ngetting spurious failures if they are on an old enough version.\n\nDo you want to roll a patch that checks $(uname) to see if we're on a\nrecent-enough version (where we can just be conservative, and assume\nwhatever version you have is the first one to fix it)?\n\n-Peff\n"},{"id":"251850","messageId":"20141113211025.GA7402@peff.net","threadId":"37945","inReplyTo":"CAO2U3QjGKYLRNWOWeoxqc_kmsdvhB5yfeRwQPuxTtf8n0XjBGA@mail.gmail.com","subject":"Re: TTY tests are unnecessarily suppressed under Mac OS","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2014-11-13T21:10:26Z","receivedAt":"2014-11-13T21:10:26Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Nov 13, 2014 at 09:06:51PM +0000, Michael Blume wrote:\n\n> Can do =)\n> \n> uname -r spits out \"14.0.0\". Is there anything in git's testing library for\n> comparing version strings or should I roll my own?\n\nNo, there's nothing standard for comparing version numbers. Probably\n\n    test \"$(uname -r | cut -d. -f1\") -ge 14\n\nsufficient.\n\n-Peff\n"}]}