{"thread":{"id":"3787","subject":"[PATCH] contrib/git-svn: handle array values correctly","startedAt":"2006-04-04T00:41:44Z","lastAt":"2006-04-04T00:41:44Z","messageCount":1,"participants":["Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"18315","messageId":"11441113044087-git-send-email-normalperson@yhbt.net","threadId":"3787","inReplyTo":null,"subject":"[PATCH] contrib/git-svn: handle array values correctly","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2006-04-04T00:41:44Z","receivedAt":"2006-04-04T00:41:44Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Signed-off-by: Eric Wong <normalperson@yhbt.net>\n\n---\n\n contrib/git-svn/git-svn.perl |    5 ++---\n 1 files changed, 2 insertions(+), 3 deletions(-)\n\n0511c05c013dc4e6d17832fad043847c35a30c6d\ndiff --git a/contrib/git-svn/git-svn.perl b/contrib/git-svn/git-svn.perl\nindex e7fff46..7c44450 100755\n--- a/contrib/git-svn/git-svn.perl\n+++ b/contrib/git-svn/git-svn.perl\n@@ -75,12 +75,11 @@ foreach my $o (keys %opts) {\n \tmy $arg = 'git-repo-config';\n \t$arg .= ' --int' if ($o =~ /=i$/);\n \t$arg .= ' --bool' if ($o !~ /=[sfi]$/);\n-\t$arg .= \" svn.$key\"; # $key only matches [a-z\\-], always shell-safe\n \tif (ref $v eq 'ARRAY') {\n-\t\tchomp(my @tmp = `$arg`);\n+\t\tchomp(my @tmp = `$arg --get-all svn.$key`);\n \t\t@$v = @tmp if @tmp;\n \t} else {\n-\t\tchomp(my $tmp = `$arg`);\n+\t\tchomp(my $tmp = `$arg --get svn.$key`);\n \t\tif ($tmp && !($arg =~ / --bool / && $tmp eq 'false')) {\n \t\t\t$$v = $tmp;\n \t\t}\n-- \n1.3.0.rc1.gd3ce-dirty\n"}]}