{"thread":{"id":"37857","subject":"[PATCH] configure.ac: quote AC_PREREQ in configure.ac","startedAt":"2014-10-31T14:17:26Z","lastAt":"2014-10-31T19:55:49Z","messageCount":2,"participants":["Elia Pinto","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"251266","messageId":"1414765046-15703-1-git-send-email-gitter.spiros@gmail.com","threadId":"37857","inReplyTo":null,"subject":"[PATCH] configure.ac: quote AC_PREREQ in configure.ac","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2014-10-31T14:17:26Z","receivedAt":"2014-10-31T14:17:26Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"For a old bug autoupdate don't do it before autoconf v2.66\n\nSigned-off-by: Elia Pinto <gitter.spiros@gmail.com>\n---\n configure.ac |    2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/configure.ac b/configure.ac\nindex 6af9647..9f01999 100644\n--- a/configure.ac\n+++ b/configure.ac\n@@ -141,7 +141,7 @@ fi\n \n ## Configure body starts here.\n \n-AC_PREREQ(2.59)\n+AC_PREREQ([2.59])\n AC_INIT([git], [@@GIT_VERSION@@], [git@vger.kernel.org])\n \n AC_CONFIG_SRCDIR([git.c])\n-- \n1.7.10.4\n"},{"id":"251271","messageId":"xmqqioj0t3ne.fsf@gitster.dls.corp.google.com","threadId":"37857","inReplyTo":"1414765046-15703-1-git-send-email-gitter.spiros@gmail.com","subject":"Re: [PATCH] configure.ac: quote AC_PREREQ in configure.ac","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-10-31T19:55:49Z","receivedAt":"2014-10-31T19:55:49Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Elia Pinto <gitter.spiros@gmail.com> writes:\n\n> For a old bug autoupdate don't do it before autoconf v2.66\n\nI am having a hard time parsing this.\n\nWhat is the practical issue that comes from the lack of quoting\nhere?  It won't be like somebody defines a macro to allow 2.59 to\nexpand to something else, confusing the machinery, so...?\n\n>\n> Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>\n> ---\n>  configure.ac |    2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/configure.ac b/configure.ac\n> index 6af9647..9f01999 100644\n> --- a/configure.ac\n> +++ b/configure.ac\n> @@ -141,7 +141,7 @@ fi\n>  \n>  ## Configure body starts here.\n>  \n> -AC_PREREQ(2.59)\n> +AC_PREREQ([2.59])\n>  AC_INIT([git], [@@GIT_VERSION@@], [git@vger.kernel.org])\n>  \n>  AC_CONFIG_SRCDIR([git.c])\n"}]}