{"thread":{"id":"378","subject":"[PATCH] diff-tree does not need -r in git-export.c","startedAt":"2005-04-28T19:13:16Z","lastAt":"2005-04-28T19:13:16Z","messageCount":1,"participants":["Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"2067","messageId":"7v3bta90kz.fsf@assigned-by-dhcp.cox.net","threadId":"378","inReplyTo":null,"subject":"[PATCH] diff-tree does not need -r in git-export.c","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-04-28T19:13:16Z","receivedAt":"2005-04-28T19:13:16Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"No need to pass -r anymore, since diff-tree -p implies recursive\nbehaviour these days.\n\nSigned-off-by: Junio C Hamano <junkio@cox.net>\n---\n\ngit-export.c |    2 +-\n1 files changed, 1 insertion(+), 1 deletion(-)\n\n# - [PATCH] diff-cache.c compilation warning fix.\n# + 04/28 11:20 No need to say diff-tree -p -r in git-export\nIndex: git-export.c\n--- k/git-export.c  (mode:100644)\n+++ l/git-export.c  (mode:100644)\n@@ -18,7 +18,7 @@ void show_commit(struct commit *commit)\n \t\tchar *against = sha1_to_hex(commit->parents->item->object.sha1);\n \t\tprintf(\"\\n\\n======== diff against %s ========\\n\", against);\n \t\tfflush(NULL);\n-\t\tsprintf(cmdline, \"diff-tree -p -r %s %s\", against, hex);\n+\t\tsprintf(cmdline, \"diff-tree -p %s %s\", against, hex);\n \t\tsystem(cmdline);\n \t}\n \tprintf(\"======== end ========\\n\\n\");\n\n"}]}