{"thread":{"id":"37797","subject":"[PATCH] Expand on impact of threads on memory consumption.","startedAt":"2014-10-24T07:43:27Z","lastAt":"2014-10-24T17:27:04Z","messageCount":2,"participants":["Robert de Bath","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"251008","messageId":"1414136607-24765-1-git-send-email-rdebath@tvisiontech.co.uk","threadId":"37797","inReplyTo":null,"subject":"[PATCH] Expand on impact of threads on memory consumption.","fromName":"Robert de Bath","fromEmail":"rdebath@tvisiontech.co.uk","sentAt":"2014-10-24T07:43:27Z","receivedAt":"2014-10-24T07:43:27Z","isPatch":true,"sender":{"key":"rdebath@tvisiontech.co.uk","avatar":null},"body":"It took me a long time to notice the rider on the pack.threads\nconfiguration option that it would multiple the memory consumption by\nthe number of CPUs in the machine. This patch puts the memory consumption\nwarning against the memory option that I was using to try to stop git-pack\nrunning out of RAM.\n\nSigned-off-by: Robert de Bath <rdebath@tvisiontech.co.uk>\n---\n Documentation/config.txt |    5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex c55c22a..6384038 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -1828,7 +1828,10 @@ pack.depth::\n \n pack.windowMemory::\n \tThe window memory size limit used by linkgit:git-pack-objects[1]\n-\twhen no limit is given on the command line.  The value can be\n+\twhen no limit is given on the command line.  This limit may be\n+\tallocated individually by each thread doing delta compression\n+\tso the total memory allocated by linkgit:git-pack-objects[1] can\n+\tbe this multiplied by the number of threads.  The value can be\n \tsuffixed with \"k\", \"m\", or \"g\".  Defaults to 0, meaning no\n \tlimit.\n \n-- \n1.7.10.4\n"},{"id":"251021","messageId":"xmqq7fzpgyzb.fsf@gitster.dls.corp.google.com","threadId":"37797","inReplyTo":"1414136607-24765-1-git-send-email-rdebath@tvisiontech.co.uk","subject":"Re: [PATCH] Expand on impact of threads on memory consumption.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-10-24T17:27:04Z","receivedAt":"2014-10-24T17:27:04Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Robert de Bath <rdebath@tvisiontech.co.uk> writes:\n\n> diff --git a/Documentation/config.txt b/Documentation/config.txt\n> index c55c22a..6384038 100644\n> --- a/Documentation/config.txt\n> +++ b/Documentation/config.txt\n> @@ -1828,7 +1828,10 @@ pack.depth::\n>  \n>  pack.windowMemory::\n>  \tThe window memory size limit used by linkgit:git-pack-objects[1]\n> -\twhen no limit is given on the command line.  The value can be\n> +\twhen no limit is given on the command line.  This limit may be\n> +\tallocated individually by each thread doing delta compression\n> +\tso the total memory allocated by linkgit:git-pack-objects[1] can\n> +\tbe this multiplied by the number of threads.  The value can be\n>  \tsuffixed with \"k\", \"m\", or \"g\".  Defaults to 0, meaning no\n>  \tlimit.\n\nI sense that this change makes the resulting text unnecessarily\nopaque by avoiding touching the first sentence.  Wouldn't something\nmore concise like this sufficient?\n\n    The default maximum size of memory that is consumed by each\n    thread in linkgit:git-pack-objects[1] for pack window memory.\n    The value can be suffixed with \"k\", \"m\", or \"g\".  When left\n    unconfigured, there will be no limit.\n"}]}