{"thread":{"id":"37769","subject":"[PATCH 1/2] transport: Free leaking head in transport_print_push_status","startedAt":"2014-10-21T01:50:44Z","lastAt":"2014-10-22T22:03:20Z","messageCount":4,"participants":["Stefan Beller","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"250882","messageId":"1413856245-5443-1-git-send-email-stefanbeller@gmail.com","threadId":"37769","inReplyTo":null,"subject":"[PATCH 1/2] transport: Free leaking head in transport_print_push_status","fromName":"Stefan Beller","fromEmail":"stefanbeller@gmail.com","sentAt":"2014-10-21T01:50:44Z","receivedAt":"2014-10-21T01:50:44Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"From: Stefan Beller \n\nFound by scan.coverity.com (ID: 1248110)\n\nSigned-off-by: Stefan Beller \n---\n transport.c | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/transport.c b/transport.c\nindex 055d2a2..fbab6ee 100644\n--- a/transport.c\n+++ b/transport.c\n@@ -774,6 +774,7 @@ void transport_print_push_status(const char *dest, struct ref *refs,\n \t\t\t*reject_reasons |= REJECT_NEEDS_FORCE;\n \t\t}\n \t}\n+\tfree(head);\n }\n \n void transport_verify_remote_names(int nr_heads, const char **heads)\n-- \n2.1.2.332.g8071e93\n"},{"id":"250883","messageId":"1413856245-5443-2-git-send-email-stefanbeller@gmail.com","threadId":"37769","inReplyTo":"1413856245-5443-1-git-send-email-stefanbeller@gmail.com","subject":"[PATCH 2/2] .mailmap: Add Stefan Bellers corporate mail address","fromName":"Stefan Beller","fromEmail":"stefanbeller@gmail.com","sentAt":"2014-10-21T01:50:45Z","receivedAt":"2014-10-21T01:50:45Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"From: Stefan Beller \n\nNote that despite the private address being first, Google owns the\ncopyright on this patch as any other patch I'll be sending signed off\nby the sbeller@google.com address.\n\nSigned-off-by: Stefan Beller \n---\n .mailmap | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/.mailmap b/.mailmap\nindex 8aefb5a..bb6f52e 100644\n--- a/.mailmap\n+++ b/.mailmap\n@@ -205,6 +205,7 @@ Shawn O. Pearce \n Simon Hausmann \n Simon Hausmann \n Stefan Beller \n+Stefan Beller \n Stefan Naewe \n Stefan Naewe \n Stefan Sperling \n-- \n2.1.2.332.g8071e93\n"},{"id":"250885","messageId":"xmqqppdm0y02.fsf@gitster.dls.corp.google.com","threadId":"37769","inReplyTo":"1413856245-5443-2-git-send-email-stefanbeller@gmail.com","subject":"Re: [PATCH 2/2] .mailmap: Add Stefan Bellers corporate mail address","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-10-21T05:53:33Z","receivedAt":"2014-10-21T05:53:33Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Stefan Beller writes:\n\n> From: Stefan Beller \n>\n> Note that despite the private address being first, Google owns the\n> copyright on this patch as any other patch I'll be sending signed off\n> by the sbeller@google.com address.\n\nWhile Googlers are encouraged to interact with external open source\nprojects using their corp address when working as new contributors,\nGooglers are also encouraged to keep using the same pre-corp address\nwhen working with projects they have been part of for continuity.\n\nAfter all, even if you send patches from your @gmail.com address\nwhile being employed by Google, the patches are copyright Google,\nnot yours, and DCO (a) \"I have the right to submit\" covers your\nsubmissions just fine (i.e. it does not say \"I own the copyright\"),\nas long as you are cleared to contribute your patches to us by\nGoogle's open source office (which I happen to know that you have\nalready done).\n\nThe mailmap is primarily to correct past mistakes and document the\nnew addresses of those who lost the old address to maintain their\nreachability. It is not about planning to send patches from two\ndifferent addresses chosen by the phase of the moon or something.\n\nI do not terribly mind, but is this patch really necessary?\n\n>\n> Signed-off-by: Stefan Beller \n> ---\n> .mailmap | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/.mailmap b/.mailmap\n> index 8aefb5a..bb6f52e 100644\n> --- a/.mailmap\n> +++ b/.mailmap\n> @@ -205,6 +205,7 @@ Shawn O. Pearce \n> Simon Hausmann \n> Simon Hausmann \n> Stefan Beller \n> +Stefan Beller \n> Stefan Naewe \n> Stefan Naewe \n> Stefan Sperling \n"},{"id":"250977","messageId":"xmqqbnp3u5hz.fsf@gitster.dls.corp.google.com","threadId":"37769","inReplyTo":"CAGZ79kYNvQOKLZ5qgCD1NyYG8X2q7UCr5rMbrxW6ajRAnFRz7A@mail.gmail.com","subject":"Re: [PATCH 2/2] .mailmap: Add Stefan Bellers corporate mail address","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-10-22T22:03:20Z","receivedAt":"2014-10-22T22:03:20Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Stefan Beller writes:\n\n> If you want me to continue using my gmail address, please check the\n> authorship\n> from the previous patch ([PATCH 1/2] transport: Free leaking head in\n> transport_print_push_status)\n> and remove the \"From: Stefan Beller \" line,\n> so we don't end up needing this patch.\n\nAs I said, I do not care too deeply either way. If you feel that\nswitching to a different e-mail address to sign off your patches\nfrom now on until your employment is terminated has merit to the\nproject, that's fine by me.\n\nThanks.\n"}]}