{"thread":{"id":"37700","subject":"DOCBOOK2X_TEXI in Documentation/Makefile invalid on some distributions","startedAt":"2014-10-09T17:53:33Z","lastAt":"2014-10-09T19:40:38Z","messageCount":3,"participants":["Derek Moore","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"250431","messageId":"CAMsgyKb-ffkfqRhG-dUkwpnKOcA=3CrZqT57qcqTr+9zm_v2Jw@mail.gmail.com","threadId":"37700","inReplyTo":null,"subject":"DOCBOOK2X_TEXI in Documentation/Makefile invalid on some distributions","fromName":"Derek Moore","fromEmail":"derek.p.moore@gmail.com","sentAt":"2014-10-09T17:53:33Z","receivedAt":"2014-10-09T17:53:33Z","isPatch":false,"sender":{"key":"derek.p.moore@gmail.com","avatar":"https://gravatar.com/avatar/4bf86633cdd04eb5d07180791de5ae0ece9f3d04b34f6e13fdb81d563fc62c23?d=mp&s=160"},"body":"Following the INSTALL doc, I was building git with:\n\nmake prefix=/usr/local all doc info\n\nEven after installing docbook2X, I couldn't get past the first DB2TEXI\nbuild step until I discovered that 'docbook2x-texi' is named\n'db2x_docbook2texi' in Fedora 21 using the latest upstream docbook2X\n0.8.8.\n\nTo the \"everything\" build to complete, I had to make this change:\n\n$ git diff\ndiff --git a/Documentation/Makefile b/Documentation/Makefile\nindex cea0e7a..0e6c70a 100644\n--- a/Documentation/Makefile\n+++ b/Documentation/Makefile\n@@ -107,7 +107,7 @@ HTML_REPO = ../../git-htmldocs\n\n MAKEINFO = makeinfo\n INSTALL_INFO = install-info\n-DOCBOOK2X_TEXI = docbook2x-texi\n+DOCBOOK2X_TEXI = db2x_docbook2texi\n DBLATEX = dblatex\n ASCIIDOC_DBLATEX_DIR = /etc/asciidoc/dblatex\n ifndef PERL_PATH\n\n\nI searched the mailing list, but don't see 'db2x_docbook2texi'\nmentioned since 2010, so I feel somewhat safe brining it up again.\n\nNot sure if the Makefile should somehow conditionally use one or the\nother of these commands. ... Or maybe I should have gone the 'make\nconfigure' route?\n\nThanks,\n\nDerek\n"},{"id":"250448","messageId":"20141009193504.GD415@peff.net","threadId":"37700","inReplyTo":"CAMsgyKb-ffkfqRhG-dUkwpnKOcA=3CrZqT57qcqTr+9zm_v2Jw@mail.gmail.com","subject":"Re: DOCBOOK2X_TEXI in Documentation/Makefile invalid on some distributions","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2014-10-09T19:35:05Z","receivedAt":"2014-10-09T19:35:05Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Oct 09, 2014 at 12:53:33PM -0500, Derek Moore wrote:\n\n> Following the INSTALL doc, I was building git with:\n> \n> make prefix=/usr/local all doc info\n\nI wonder if it is actually sane to recommend building \"info\" for\nnewcomers in INSTALL. I do not know if many of the list regulars do so\n(I certainly do not), or if it is part of anybody's testing regimen.\n\n> $ git diff\n> diff --git a/Documentation/Makefile b/Documentation/Makefile\n> index cea0e7a..0e6c70a 100644\n> --- a/Documentation/Makefile\n> +++ b/Documentation/Makefile\n> @@ -107,7 +107,7 @@ HTML_REPO = ../../git-htmldocs\n> \n>  MAKEINFO = makeinfo\n>  INSTALL_INFO = install-info\n> -DOCBOOK2X_TEXI = docbook2x-texi\n> +DOCBOOK2X_TEXI = db2x_docbook2texi\n>  DBLATEX = dblatex\n>  ASCIIDOC_DBLATEX_DIR = /etc/asciidoc/dblatex\n>  ifndef PERL_PATH\n\nI don't think we would want to take a patch like this, as it is still\ncalled docbook2x-texi at least on Debian.\n\nYou can override variables with:\n\n  make DOCBOOK2X_TEXI=db2x_docbook2texi ...\n\nor if you want to use it for multiple make invocations:\n\n  echo DOCBOOK2_TEXI=db2x_docbook2texi >config.mak\n\nIf we want a patch to make this Just Work out of the box on Fedora, I'd\nsuggest looking at config.mak.uname (though I am not sure if there is\nenough information there currently to determine Fedora versus another\ndistro), and/or a patch to configure.ac to detect which name we have.\n\n-Peff\n"},{"id":"250449","messageId":"CAMsgyKZfH8dphGOmGpYx2PWMARaRT13z0xZfoWSL6UspwHFzuw@mail.gmail.com","threadId":"37700","inReplyTo":"20141009193504.GD415@peff.net","subject":"Re: DOCBOOK2X_TEXI in Documentation/Makefile invalid on some distributions","fromName":"Derek Moore","fromEmail":"derek.p.moore@gmail.com","sentAt":"2014-10-09T19:40:38Z","receivedAt":"2014-10-09T19:40:38Z","isPatch":false,"sender":{"key":"derek.p.moore@gmail.com","avatar":"https://gravatar.com/avatar/4bf86633cdd04eb5d07180791de5ae0ece9f3d04b34f6e13fdb81d563fc62c23?d=mp&s=160"},"body":":) Wasn't proposing a patch, that's for sure, was just evincing the\nchange that worked for me.\n\nI agree INSTALL instructions should be fixed up and/or the\nDOCBOOK2X_TEXI should be conditionally assigned in a sane manner.\n\nI'd first want to inspect upstream docbook2X build process and Fedora\ndocbook2X RPM .spec, to see which name is canonical and how you guys\ncame up with \"docbook2x-texi\".\n\nSeems there are now plenty of opportunities for me get my name in\ngit's AUTHORS list. ;)\n\n\nOn Thu, Oct 9, 2014 at 2:35 PM, Jeff King <peff@peff.net> wrote:\n> On Thu, Oct 09, 2014 at 12:53:33PM -0500, Derek Moore wrote:\n>\n>> Following the INSTALL doc, I was building git with:\n>>\n>> make prefix=/usr/local all doc info\n>\n> I wonder if it is actually sane to recommend building \"info\" for\n> newcomers in INSTALL. I do not know if many of the list regulars do so\n> (I certainly do not), or if it is part of anybody's testing regimen.\n>\n>> $ git diff\n>> diff --git a/Documentation/Makefile b/Documentation/Makefile\n>> index cea0e7a..0e6c70a 100644\n>> --- a/Documentation/Makefile\n>> +++ b/Documentation/Makefile\n>> @@ -107,7 +107,7 @@ HTML_REPO = ../../git-htmldocs\n>>\n>>  MAKEINFO = makeinfo\n>>  INSTALL_INFO = install-info\n>> -DOCBOOK2X_TEXI = docbook2x-texi\n>> +DOCBOOK2X_TEXI = db2x_docbook2texi\n>>  DBLATEX = dblatex\n>>  ASCIIDOC_DBLATEX_DIR = /etc/asciidoc/dblatex\n>>  ifndef PERL_PATH\n>\n> I don't think we would want to take a patch like this, as it is still\n> called docbook2x-texi at least on Debian.\n>\n> You can override variables with:\n>\n>   make DOCBOOK2X_TEXI=db2x_docbook2texi ...\n>\n> or if you want to use it for multiple make invocations:\n>\n>   echo DOCBOOK2_TEXI=db2x_docbook2texi >config.mak\n>\n> If we want a patch to make this Just Work out of the box on Fedora, I'd\n> suggest looking at config.mak.uname (though I am not sure if there is\n> enough information there currently to determine Fedora versus another\n> distro), and/or a patch to configure.ac to detect which name we have.\n>\n> -Peff\n"}]}