{"thread":{"id":"37564","subject":"[PATCH v2 1/2] t1503: test rev-parse --verify --quiet with deleted reflogs","startedAt":"2014-09-14T19:03:01Z","lastAt":"2014-09-14T19:03:02Z","messageCount":2,"participants":["David Aguilar"],"isPatch":true,"patchVersion":2,"patchTotal":2},"messages":[{"id":"249404","messageId":"1410721382-97751-1-git-send-email-davvid@gmail.com","threadId":"37564","inReplyTo":null,"subject":"[PATCH v2 1/2] t1503: test rev-parse --verify --quiet with deleted reflogs","fromName":"David Aguilar","fromEmail":"davvid@gmail.com","sentAt":"2014-09-14T19:03:01Z","receivedAt":"2014-09-14T19:03:01Z","isPatch":true,"sender":{"key":"davvid@gmail.com","avatar":"https://avatars.githubusercontent.com/u/13196?v=4"},"body":"Ensure that rev-parse --verify --quiet is silent when asked\nabout deleted reflog entries.\n\nHelped-by: Fabian Ruch <bafain@gmail.com>\nSigned-off-by: David Aguilar <davvid@gmail.com>\n---\nChanges since last time:\n\nUse \"git branch test\" instead of low-level plumbing commands.\nCapture both stdout and stderr in the test.\n\n t/t1503-rev-parse-verify.sh | 7 +++++++\n 1 file changed, 7 insertions(+)\n\ndiff --git a/t/t1503-rev-parse-verify.sh b/t/t1503-rev-parse-verify.sh\nindex 813cc1b..ab9878d 100755\n--- a/t/t1503-rev-parse-verify.sh\n+++ b/t/t1503-rev-parse-verify.sh\n@@ -83,6 +83,13 @@ test_expect_success 'fails silently when using -q' '\n \ttest -z \"$(cat error)\"\n '\n \n+test_expect_success 'fails silently when using -q with deleted reflogs' '\n+\tgit branch test &&\n+\tgit reflog delete --updateref --rewrite test@{0} &&\n+\ttest_must_fail git rev-parse -q --verify test@{0} >error 2>&1 &&\n+\ttest -z \"$(cat error)\"\n+'\n+\n test_expect_success 'no stdout output on error' '\n \ttest -z \"$(git rev-parse --verify)\" &&\n \ttest -z \"$(git rev-parse --verify foo)\" &&\n-- \n2.1.0.30.g05c535b.dirty\n"},{"id":"249405","messageId":"1410721382-97751-2-git-send-email-davvid@gmail.com","threadId":"37564","inReplyTo":"1410721382-97751-1-git-send-email-davvid@gmail.com","subject":"[PATCH v2 2/2] t1503: use test_must_be_empty","fromName":"David Aguilar","fromEmail":"davvid@gmail.com","sentAt":"2014-09-14T19:03:02Z","receivedAt":"2014-09-14T19:03:02Z","isPatch":true,"sender":{"key":"davvid@gmail.com","avatar":"https://avatars.githubusercontent.com/u/13196?v=4"},"body":"Use `test_must_be_be_empty <file>` instead of `test -z \"$(cat <file>)\"`.\n\nSuggested-by: Fabian Ruch <bafain@gmail.com>\nSigned-off-by: David Aguilar <davvid@gmail.com>\n---\n t/t1503-rev-parse-verify.sh | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/t/t1503-rev-parse-verify.sh b/t/t1503-rev-parse-verify.sh\nindex ab9878d..9ac4627 100755\n--- a/t/t1503-rev-parse-verify.sh\n+++ b/t/t1503-rev-parse-verify.sh\n@@ -72,22 +72,22 @@ test_expect_success 'fails with any bad rev or many good revs' '\n \n test_expect_success 'fails silently when using -q' '\n \ttest_must_fail git rev-parse --verify --quiet 2>error &&\n-\ttest -z \"$(cat error)\" &&\n+\ttest_must_be_empty error &&\n \ttest_must_fail git rev-parse -q --verify foo 2>error &&\n-\ttest -z \"$(cat error)\" &&\n+\ttest_must_be_empty error &&\n \ttest_must_fail git rev-parse --verify -q HEAD bar 2>error &&\n-\ttest -z \"$(cat error)\" &&\n+\ttest_must_be_empty error &&\n \ttest_must_fail git rev-parse --quiet --verify baz HEAD 2>error &&\n-\ttest -z \"$(cat error)\" &&\n+\ttest_must_be_empty error &&\n \ttest_must_fail git rev-parse -q --verify $HASH2 HEAD 2>error &&\n-\ttest -z \"$(cat error)\"\n+\ttest_must_be_empty error\n '\n \n test_expect_success 'fails silently when using -q with deleted reflogs' '\n \tgit branch test &&\n \tgit reflog delete --updateref --rewrite test@{0} &&\n \ttest_must_fail git rev-parse -q --verify test@{0} >error 2>&1 &&\n-\ttest -z \"$(cat error)\"\n+\ttest_must_be_empty error\n '\n \n test_expect_success 'no stdout output on error' '\n-- \n2.1.0.30.g05c535b.dirty\n"}]}