{"thread":{"id":"37429","subject":"[PATCH] Document LF appearing in shallow command during send-pack/receive-pack","startedAt":"2014-08-27T20:46:56Z","lastAt":"2014-08-27T22:10:17Z","messageCount":2,"participants":["Shawn Pearce","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"248441","messageId":"1409172416-10750-1-git-send-email-spearce@spearce.org","threadId":"37429","inReplyTo":null,"subject":"[PATCH] Document LF appearing in shallow command during send-pack/receive-pack","fromName":"Shawn Pearce","fromEmail":"spearce@spearce.org","sentAt":"2014-08-27T20:46:56Z","receivedAt":"2014-08-27T20:46:56Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"The implementation sends an LF, but the protocol documentation was\nmissing this detail.\n\nSigned-off-by: Shawn Pearce <spearce@spearce.org>\n---\n Documentation/technical/pack-protocol.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/technical/pack-protocol.txt b/Documentation/technical/pack-protocol.txt\nindex 18dea8d..569c48a 100644\n--- a/Documentation/technical/pack-protocol.txt\n+++ b/Documentation/technical/pack-protocol.txt\n@@ -467,7 +467,7 @@ references.\n ----\n   update-request    =  *shallow command-list [pack-file]\n \n-  shallow           =  PKT-LINE(\"shallow\" SP obj-id)\n+  shallow           =  PKT-LINE(\"shallow\" SP obj-id LF)\n \n   command-list      =  PKT-LINE(command NUL capability-list LF)\n \t\t       *PKT-LINE(command LF)\n-- \n2.1.0.rc2.206.gedb03e5\n"},{"id":"248452","messageId":"20140827221017.GY20185@google.com","threadId":"37429","inReplyTo":"1409172416-10750-1-git-send-email-spearce@spearce.org","subject":"Re: [PATCH] Document LF appearing in shallow command during send-pack/receive-pack","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2014-08-27T22:10:17Z","receivedAt":"2014-08-27T22:10:17Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Shawn Pearce wrote:\n\n> The implementation sends an LF, but the protocol documentation was\n> missing this detail.\n>\n> Signed-off-by: Shawn Pearce <spearce@spearce.org>\n> ---\n>  Documentation/technical/pack-protocol.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/technical/pack-protocol.txt b/Documentation/technical/pack-protocol.txt\n> index 18dea8d..569c48a 100644\n> --- a/Documentation/technical/pack-protocol.txt\n> +++ b/Documentation/technical/pack-protocol.txt\n> @@ -467,7 +467,7 @@ references.\n>  ----\n>    update-request    =  *shallow command-list [pack-file]\n>  \n> -  shallow           =  PKT-LINE(\"shallow\" SP obj-id)\n> +  shallow           =  PKT-LINE(\"shallow\" SP obj-id LF)\n\nIn git, the client sends LF and the server is happy with or\nwithout LF.  JGit and libgit2 don't send 'shallow' lines.\n\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n\n>  \n>    command-list      =  PKT-LINE(command NUL capability-list LF)\n>  \t\t       *PKT-LINE(command LF)\n> -- \n"}]}