{"thread":{"id":"37408","subject":"[PATCH] Undefine strlcpy if needed.","startedAt":"2014-08-24T04:32:21Z","lastAt":"2014-08-25T11:16:04Z","messageCount":10,"participants":["Benoit Sigoure","Ramsay Jones","tsuna","Torsten Bögershausen"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"248194","messageId":"1408854741-13956-1-git-send-email-tsunanet@gmail.com","threadId":"37408","inReplyTo":null,"subject":"[PATCH] Undefine strlcpy if needed.","fromName":"Benoit Sigoure","fromEmail":"tsunanet@gmail.com","sentAt":"2014-08-24T04:32:21Z","receivedAt":"2014-08-24T04:32:21Z","isPatch":true,"sender":{"key":"tsunanet@gmail.com","avatar":"https://avatars.githubusercontent.com/u/128281?v=4"},"body":"On OS X, strlcpy is already #define'd, which causes warnings\nin all the files that include `git-compat-util.h'.  Note that\nthis only occurs when building without running ./configure.\n---\n git-compat-util.h | 3 +++\n 1 file changed, 3 insertions(+)\n\ndiff --git a/git-compat-util.h b/git-compat-util.h\nindex f587749..8c001e2 100644\n--- a/git-compat-util.h\n+++ b/git-compat-util.h\n@@ -495,6 +495,9 @@ extern char *gitstrcasestr(const char *haystack, const char *needle);\n #endif\n \n #ifdef NO_STRLCPY\n+#ifdef strlcpy\n+#undef strlcpy\n+#endif\n #define strlcpy gitstrlcpy\n extern size_t gitstrlcpy(char *, const char *, size_t);\n #endif\n-- \n1.9.2.460.gfb82504\n"},{"id":"248195","messageId":"1408854930-14322-1-git-send-email-tsunanet@gmail.com","threadId":"37408","inReplyTo":"1408854741-13956-1-git-send-email-tsunanet@gmail.com","subject":"[PATCH] Undefine strlcpy if needed.","fromName":"Benoit Sigoure","fromEmail":"tsunanet@gmail.com","sentAt":"2014-08-24T04:35:30Z","receivedAt":"2014-08-24T04:35:30Z","isPatch":true,"sender":{"key":"tsunanet@gmail.com","avatar":"https://avatars.githubusercontent.com/u/128281?v=4"},"body":"On OS X, strlcpy is already #define'd, which causes warnings\nin all the files that include `git-compat-util.h'.  Note that\nthis only occurs when building without running ./configure.\n\nSigned-off-by: Benoit Sigoure <tsunanet@gmail.com>\n---\n\nResending with the SOB line I forgot.\n\n git-compat-util.h | 3 +++\n 1 file changed, 3 insertions(+)\n\ndiff --git a/git-compat-util.h b/git-compat-util.h\nindex f587749..8c001e2 100644\n--- a/git-compat-util.h\n+++ b/git-compat-util.h\n@@ -495,6 +495,9 @@ extern char *gitstrcasestr(const char *haystack, const char *needle);\n #endif\n \n #ifdef NO_STRLCPY\n+#ifdef strlcpy\n+#undef strlcpy\n+#endif\n #define strlcpy gitstrlcpy\n extern size_t gitstrlcpy(char *, const char *, size_t);\n #endif\n-- \n1.9.2.460.gfb82504\n"},{"id":"248197","messageId":"53F9C818.8020607@ramsay1.demon.co.uk","threadId":"37408","inReplyTo":"1408854930-14322-1-git-send-email-tsunanet@gmail.com","subject":"Re: [PATCH] Undefine strlcpy if needed.","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2014-08-24T11:10:16Z","receivedAt":"2014-08-24T11:10:16Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"On 24/08/14 05:35, Benoit Sigoure wrote:\n> On OS X, strlcpy is already #define'd, which causes warnings\n> in all the files that include `git-compat-util.h'.  Note that\n> this only occurs when building without running ./configure.\n> \n> Signed-off-by: Benoit Sigoure <tsunanet@gmail.com>\n> ---\n> \n> Resending with the SOB line I forgot.\n> \n>  git-compat-util.h | 3 +++\n>  1 file changed, 3 insertions(+)\n> \n> diff --git a/git-compat-util.h b/git-compat-util.h\n> index f587749..8c001e2 100644\n> --- a/git-compat-util.h\n> +++ b/git-compat-util.h\n> @@ -495,6 +495,9 @@ extern char *gitstrcasestr(const char *haystack, const char *needle);\n>  #endif\n>  \n>  #ifdef NO_STRLCPY\n> +#ifdef strlcpy\n> +#undef strlcpy\n> +#endif\n\nIf strlcpy is #defined, then presumably NO_STRLCPY should not be set, no?\n\n>  #define strlcpy gitstrlcpy\n>  extern size_t gitstrlcpy(char *, const char *, size_t);\n>  #endif\n> \n\nHmm, which version of OS X are we talking about?\n\nconfig.mak.uname contains this:\n\n        ifeq ($(shell expr \"$(uname_R)\" : '[15]\\.'),2)\n                NO_STRLCPY = YesPlease\n\nWhat does ./configure put in config.mak.autogen for NO_STRLCPY?\n\n(sorry, I don't have access to any version of OS X, so I can't\noffer much help on this).\n\nATB,\nRamsay Jones\n"},{"id":"248198","messageId":"CAFKYj4dQhGgpS9Vf=5qoku49jEkR0ko7TuBNu4sQAJyiD7y+cg@mail.gmail.com","threadId":"37408","inReplyTo":"53F9C818.8020607@ramsay1.demon.co.uk","subject":"Re: [PATCH] Undefine strlcpy if needed.","fromName":"tsuna","fromEmail":"tsunanet@gmail.com","sentAt":"2014-08-24T11:13:42Z","receivedAt":"2014-08-24T11:13:42Z","isPatch":true,"sender":{"key":"tsunanet@gmail.com","avatar":"https://avatars.githubusercontent.com/u/128281?v=4"},"body":"On Sun, Aug 24, 2014 at 4:10 AM, Ramsay Jones\n<ramsay@ramsay1.demon.co.uk> wrote:\n> Hmm, which version of OS X are we talking about?\n\nOS X 10.9.4:\n\n$ uname -a\nDarwin damogran.local 13.3.0 Darwin Kernel Version 13.3.0: Tue Jun  3\n21:27:35 PDT 2014; root:xnu-2422.110.17~1/RELEASE_X86_64 x86_64\n\n> config.mak.uname contains this:\n>\n>         ifeq ($(shell expr \"$(uname_R)\" : '[15]\\.'),2)\n>                 NO_STRLCPY = YesPlease\n>\n> What does ./configure put in config.mak.autogen for NO_STRLCPY?\n\nNO_STRLCPY=\n\nI guess I saw all the warnings because I did just a “git pull —rebase\n&& make -j8” without running “make configure && ./configure”.\n\n-- \nBenoit \"tsuna\" Sigoure\n"},{"id":"248211","messageId":"53FA1050.2060309@ramsay1.demon.co.uk","threadId":"37408","inReplyTo":"CAFKYj4dQhGgpS9Vf=5qoku49jEkR0ko7TuBNu4sQAJyiD7y+cg@mail.gmail.com","subject":"Re: [PATCH] Undefine strlcpy if needed.","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2014-08-24T16:18:24Z","receivedAt":"2014-08-24T16:18:24Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"On 24/08/14 12:13, tsuna wrote:\n> On Sun, Aug 24, 2014 at 4:10 AM, Ramsay Jones\n> <ramsay@ramsay1.demon.co.uk> wrote:\n>> Hmm, which version of OS X are we talking about?\n> \n> OS X 10.9.4:\n> \n> $ uname -a\n> Darwin damogran.local 13.3.0 Darwin Kernel Version 13.3.0: Tue Jun  3\n> 21:27:35 PDT 2014; root:xnu-2422.110.17~1/RELEASE_X86_64 x86_64\n\nHmm, does 'uname -r' return 13.3.0 or 13.4.0? (or something else!)\n\n>> config.mak.uname contains this:\n>>\n>>         ifeq ($(shell expr \"$(uname_R)\" : '[15]\\.'),2)\n>>                 NO_STRLCPY = YesPlease\n>>\n>> What does ./configure put in config.mak.autogen for NO_STRLCPY?\n> \n> NO_STRLCPY=\n\nOK, so I've got to my limit here! ;-) The conditional shown above\n(from config.mak.uname) should not have set NO_STRLCPY (assuming\nthat 'uname -r' is returning 13.3.0 or 13.4.0). So, unless NO_STRLCPY\nis being set somewhere else (command-line, environment), this should\njust work. puzzled. :(\n\n> \n> I guess I saw all the warnings because I did just a “git pull —rebase\n> && make -j8” without running “make configure && ./configure”.\n> \n\nYes, but use of configure is supposed to be optional ...\n\nHopefully, someone who actually knows OS X can solve the mystery.\n\nATB,\nRamsay Jones\n"},{"id":"248215","messageId":"53FA41E2.9060907@web.de","threadId":"37408","inReplyTo":"53FA1050.2060309@ramsay1.demon.co.uk","subject":"Re: [PATCH] Undefine strlcpy if needed.","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2014-08-24T19:49:54Z","receivedAt":"2014-08-24T19:49:54Z","isPatch":true,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"On 2014-08-24 18.18, Ramsay Jones wrote:\n> On 24/08/14 12:13, tsuna wrote:\n>> On Sun, Aug 24, 2014 at 4:10 AM, Ramsay Jones\n>> <ramsay@ramsay1.demon.co.uk> wrote:\n>>> Hmm, which version of OS X are we talking about?\n>>\n>> OS X 10.9.4:\n>>\n>> $ uname -a\n>> Darwin damogran.local 13.3.0 Darwin Kernel Version 13.3.0: Tue Jun  3\n>> 21:27:35 PDT 2014; root:xnu-2422.110.17~1/RELEASE_X86_64 x86_64\n> \n> Hmm, does 'uname -r' return 13.3.0 or 13.4.0? (or something else!)\n> \n>>> config.mak.uname contains this:\n>>>\n>>>         ifeq ($(shell expr \"$(uname_R)\" : '[15]\\.'),2)\n>>>                 NO_STRLCPY = YesPlease\n>>>\n>>> What does ./configure put in config.mak.autogen for NO_STRLCPY?\n>>\n>> NO_STRLCPY=\n> \n> OK, so I've got to my limit here! ;-) The conditional shown above\n> (from config.mak.uname) should not have set NO_STRLCPY (assuming\n> that 'uname -r' is returning 13.3.0 or 13.4.0). So, unless NO_STRLCPY\n> is being set somewhere else (command-line, environment), this should\n> just work. puzzled. :(\n> \n>>\n>> I guess I saw all the warnings because I did just a “git pull —rebase\n>> && make -j8” without running “make configure && ./configure”.\n>>\n> \n> Yes, but use of configure is supposed to be optional ...\n> \n> Hopefully, someone who actually knows OS X can solve the mystery.\n> \n> ATB,\n> Ramsay Jones\n\nI need to admit that I can not reproduce the warning here,\nuname -r gives \"13.3.0\"\n\nCould it be that something is special on your machine ?\nSomething in the environment  ?\nDoes a fresh clone help ?\n"},{"id":"248216","messageId":"CAFKYj4eD8CXzafSC5LWpmaen=d6uw7yn0gZXFLG7VGLQwZdUWA@mail.gmail.com","threadId":"37408","inReplyTo":"53FA41E2.9060907@web.de","subject":"Re: [PATCH] Undefine strlcpy if needed.","fromName":"tsuna","fromEmail":"tsunanet@gmail.com","sentAt":"2014-08-24T21:09:47Z","receivedAt":"2014-08-24T21:09:47Z","isPatch":true,"sender":{"key":"tsunanet@gmail.com","avatar":"https://avatars.githubusercontent.com/u/128281?v=4"},"body":"On Sun, Aug 24, 2014 at 12:49 PM, Torsten Bögershausen <tboegi@web.de> wrote:\n> On 2014-08-24 18.18, Ramsay Jones wrote:\n>> On 24/08/14 12:13, tsuna wrote:\n>>> On Sun, Aug 24, 2014 at 4:10 AM, Ramsay Jones\n>>> <ramsay@ramsay1.demon.co.uk> wrote:\n>>>> Hmm, which version of OS X are we talking about?\n>>>\n>>> OS X 10.9.4:\n>>>\n>>> $ uname -a\n>>> Darwin damogran.local 13.3.0 Darwin Kernel Version 13.3.0: Tue Jun  3\n>>> 21:27:35 PDT 2014; root:xnu-2422.110.17~1/RELEASE_X86_64 x86_64\n>>\n>> Hmm, does 'uname -r' return 13.3.0 or 13.4.0? (or something else!)\n\n$ uname -r\n13.3.0\n\n>>>> config.mak.uname contains this:\n>>>>\n>>>>         ifeq ($(shell expr \"$(uname_R)\" : '[15]\\.'),2)\n>>>>                 NO_STRLCPY = YesPlease\n>>>>\n>>>> What does ./configure put in config.mak.autogen for NO_STRLCPY?\n>>>\n>>> NO_STRLCPY=\n>>\n>> OK, so I've got to my limit here! ;-) The conditional shown above\n>> (from config.mak.uname) should not have set NO_STRLCPY (assuming\n>> that 'uname -r' is returning 13.3.0 or 13.4.0). So, unless NO_STRLCPY\n>> is being set somewhere else (command-line, environment), this should\n>> just work. puzzled. :(\n>>\n>>>\n>>> I guess I saw all the warnings because I did just a “git pull —rebase\n>>> && make -j8” without running “make configure && ./configure”.\n>>>\n>>\n>> Yes, but use of configure is supposed to be optional ...\n>>\n>> Hopefully, someone who actually knows OS X can solve the mystery.\n>>\n>> ATB,\n>> Ramsay Jones\n>\n> I need to admit that I can not reproduce the warning here,\n> uname -r gives \"13.3.0\"\n>\n> Could it be that something is special on your machine ?\n> Something in the environment  ?\n\nNot that I can think of, the only \"non-standard” thing I have\ninstalled is Homebrew (http://brew.sh/), but otherwise it’s all the\nstandard OS X stuff and Developer tools.  I write code on this machine\non a daily basis.\n\n> Does a fresh clone help ?\n\nA fresh clone doesn’t even build :-/\n\n$ git clone git://github.com/git/git.git\nCloning into 'git'...\nremote: Counting objects: 176423, done.\nremote: Compressing objects: 100% (47201/47201), done.\nremote: Total 176423 (delta 127349), reused 176233 (delta 127209)\nReceiving objects: 100% (176423/176423), 64.05 MiB | 6.13 MiB/s, done.\nResolving deltas: 100% (127349/127349), done.\nChecking connectivity... done.\n$ cd git\n\n                                                                   $\nmake\nGIT_VERSION = 2.1.0\n    * new build flags\n    CC credential-store.o\nIn file included from credential-store.c:1:\nIn file included from ./cache.h:8:\n./gettext.h:17:11: fatal error: 'libintl.h' file not found\n#       include <libintl.h>\n                ^\n1 error generated.\nmake: *** [credential-store.o] Error 1\n\n\nI need to run configure first:\n\n$ make configure\n    GEN configure\n$ ./configure\nconfigure: Setting lib to 'lib' (the default)\n[…]\n$ make\ntsuna@damogran /tmp/git $ make\n    * new build flags\n    CC credential-store.o\n    * new link flags\n    CC abspath.o\n[…]\n\nThen the build succeeds.\n\n$ grep NO_STRLCPY config.mak.autogen\nNO_STRLCPY=\n\n$ which cc\n/usr/bin/cc\n\n$ cc --version\nApple LLVM version 5.1 (clang-503.0.40) (based on LLVM 3.4svn)\nTarget: x86_64-apple-darwin13.3.0\nThread model: posix\n\n-- \nBenoit \"tsuna” Sigoure\n"},{"id":"248219","messageId":"53FA8438.5070107@ramsay1.demon.co.uk","threadId":"37408","inReplyTo":"CAFKYj4eD8CXzafSC5LWpmaen=d6uw7yn0gZXFLG7VGLQwZdUWA@mail.gmail.com","subject":"Re: [PATCH] Undefine strlcpy if needed.","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2014-08-25T00:32:56Z","receivedAt":"2014-08-25T00:32:56Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"On 24/08/14 22:09, tsuna wrote:\n> On Sun, Aug 24, 2014 at 12:49 PM, Torsten Bögershausen <tboegi@web.de> wrote:\n>> On 2014-08-24 18.18, Ramsay Jones wrote:\n>>> On 24/08/14 12:13, tsuna wrote:\n>>>> On Sun, Aug 24, 2014 at 4:10 AM, Ramsay Jones\n>>>> <ramsay@ramsay1.demon.co.uk> wrote:\n>>>>> Hmm, which version of OS X are we talking about?\n>>>>\n>>>> OS X 10.9.4:\n>>>>\n>>>> $ uname -a\n>>>> Darwin damogran.local 13.3.0 Darwin Kernel Version 13.3.0: Tue Jun  3\n>>>> 21:27:35 PDT 2014; root:xnu-2422.110.17~1/RELEASE_X86_64 x86_64\n>>>\n>>> Hmm, does 'uname -r' return 13.3.0 or 13.4.0? (or something else!)\n> \n> $ uname -r\n> 13.3.0\n> \n>>>>> config.mak.uname contains this:\n>>>>>\n>>>>>         ifeq ($(shell expr \"$(uname_R)\" : '[15]\\.'),2)\n>>>>>                 NO_STRLCPY = YesPlease\n>>>>>\n>>>>> What does ./configure put in config.mak.autogen for NO_STRLCPY?\n>>>>\n>>>> NO_STRLCPY=\n>>>\n>>> OK, so I've got to my limit here! ;-) The conditional shown above\n>>> (from config.mak.uname) should not have set NO_STRLCPY (assuming\n>>> that 'uname -r' is returning 13.3.0 or 13.4.0). So, unless NO_STRLCPY\n>>> is being set somewhere else (command-line, environment), this should\n>>> just work. puzzled. :(\n>>>\n>>>>\n>>>> I guess I saw all the warnings because I did just a “git pull —rebase\n>>>> && make -j8” without running “make configure && ./configure”.\n>>>>\n>>>\n>>> Yes, but use of configure is supposed to be optional ...\n>>>\n>>> Hopefully, someone who actually knows OS X can solve the mystery.\n>>>\n>>> ATB,\n>>> Ramsay Jones\n>>\n>> I need to admit that I can not reproduce the warning here,\n>> uname -r gives \"13.3.0\"\n>>\n>> Could it be that something is special on your machine ?\n>> Something in the environment  ?\n> \n> Not that I can think of, the only \"non-standard” thing I have\n> installed is Homebrew (http://brew.sh/), but otherwise it’s all the\n> standard OS X stuff and Developer tools.  I write code on this machine\n> on a daily basis.\n> \n>> Does a fresh clone help ?\n> \n> A fresh clone doesn’t even build :-/\n> \n> $ git clone git://github.com/git/git.git\n> Cloning into 'git'...\n> remote: Counting objects: 176423, done.\n> remote: Compressing objects: 100% (47201/47201), done.\n> remote: Total 176423 (delta 127349), reused 176233 (delta 127209)\n> Receiving objects: 100% (176423/176423), 64.05 MiB | 6.13 MiB/s, done.\n> Resolving deltas: 100% (127349/127349), done.\n> Checking connectivity... done.\n> $ cd git\n> \n>                                                                    $\n> make\n> GIT_VERSION = 2.1.0\n>     * new build flags\n>     CC credential-store.o\n> In file included from credential-store.c:1:\n> In file included from ./cache.h:8:\n> ./gettext.h:17:11: fatal error: 'libintl.h' file not found\n> #       include <libintl.h>\n>                 ^\n> 1 error generated.\n> make: *** [credential-store.o] Error 1\n\nAgain, I don't have access to an OS X system, so I don't know\nwhich package provides libintl/gettext, but it seems to be missing\non your system.\n\nYou can avoid the build failure, without running configure, by\nsetting NO_GETTEXT=YesPlease in your config.mak file.\n\n> \n> \n> I need to run configure first:\n> \n> $ make configure\n>     GEN configure\n> $ ./configure\n> configure: Setting lib to 'lib' (the default)\n> […]\n\nSo, presumably, configure has set NO_GETEXT=YesPlease in your\nconfig.mak.autogen file.\n\nATB,\nRamsay Jones\n"},{"id":"248220","messageId":"CAFKYj4cDJhiVfdmzZ5KnNASBEp9bkj0asxANPv43QcMQP06z9A@mail.gmail.com","threadId":"37408","inReplyTo":"53FA8438.5070107@ramsay1.demon.co.uk","subject":"Re: [PATCH] Undefine strlcpy if needed.","fromName":"tsuna","fromEmail":"tsunanet@gmail.com","sentAt":"2014-08-25T01:54:11Z","receivedAt":"2014-08-25T01:54:11Z","isPatch":true,"sender":{"key":"tsunanet@gmail.com","avatar":"https://avatars.githubusercontent.com/u/128281?v=4"},"body":"On Sun, Aug 24, 2014 at 5:32 PM, Ramsay Jones\n<ramsay@ramsay1.demon.co.uk> wrote:\n> Again, I don't have access to an OS X system, so I don't know\n> which package provides libintl/gettext, but it seems to be missing\n> on your system.\n\nProbably yeah, those libraries don’t seem to be provided in standard\nwith OS X or OS X’s development tools, so maybe the Makefile should\nalso default to having NO_GETTEXT=YesPlease when on OS X.\n\n> You can avoid the build failure, without running configure, by\n> setting NO_GETTEXT=YesPlease in your config.mak file.\n>\n>>\n>>\n>> I need to run configure first:\n>>\n>> $ make configure\n>>     GEN configure\n>> $ ./configure\n>> configure: Setting lib to 'lib' (the default)\n>> […]\n>\n> So, presumably, configure has set NO_GETEXT=YesPlease in your\n> config.mak.autogen file.\n\nYes it did.\n\nI don’t mind running configure, but so far Git has compiled fine\nwithout doing it.  Should we fix the default values of NO_STRLCPY /\nNO_GETEXT on OS X?\n\n-- \nBenoit \"tsuna\" Sigoure\n"},{"id":"248221","messageId":"53FB1AF4.1000201@ramsay1.demon.co.uk","threadId":"37408","inReplyTo":"CAFKYj4cDJhiVfdmzZ5KnNASBEp9bkj0asxANPv43QcMQP06z9A@mail.gmail.com","subject":"Re: [PATCH] Undefine strlcpy if needed.","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2014-08-25T11:16:04Z","receivedAt":"2014-08-25T11:16:04Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"On 25/08/14 02:54, tsuna wrote:\n> On Sun, Aug 24, 2014 at 5:32 PM, Ramsay Jones\n> <ramsay@ramsay1.demon.co.uk> wrote:\n>> Again, I don't have access to an OS X system, so I don't know\n>> which package provides libintl/gettext, but it seems to be missing\n>> on your system.\n> \n> Probably yeah, those libraries don’t seem to be provided in standard\n> with OS X or OS X’s development tools, so maybe the Makefile should\n> also default to having NO_GETTEXT=YesPlease when on OS X.\n> \n>> You can avoid the build failure, without running configure, by\n>> setting NO_GETTEXT=YesPlease in your config.mak file.\n>>\n>>>\n>>>\n>>> I need to run configure first:\n>>>\n>>> $ make configure\n>>>     GEN configure\n>>> $ ./configure\n>>> configure: Setting lib to 'lib' (the default)\n>>> […]\n>>\n>> So, presumably, configure has set NO_GETEXT=YesPlease in your\n>> config.mak.autogen file.\n> \n> Yes it did.\n> \n> I don’t mind running configure, but so far Git has compiled fine\n> without doing it.  Should we fix the default values of NO_STRLCPY /\n> NO_GETEXT on OS X?\n> \n\nIs NO_STRLCPY still a problem with a fresh clone (and putting\nNO_GETEXT=YesPlease in your config.mak)? I still do not understand\nwhy you were getting those warnings; AFAICT it should not be happening!\nAlso, Torsten could not reproduce.\n\nAs far as NO_GETTEXT is concerned, I have to defer to someone who has\nexperience on that platform (I have _zero_ experience on OS X).\n\nATB,\nRamsay Jones\n"}]}