{"thread":{"id":"37348","subject":"Git on Mac OS X 10.4.10","startedAt":"2014-08-14T12:13:15Z","lastAt":"2014-08-15T18:51:11Z","messageCount":14,"participants":["Markus Hitter","Torsten Bögershausen","Jonathan Nieder","Junio C Hamano","Kyle J. McKay","Eric Sunshine"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"247718","messageId":"53ECA7DB.7060407@jump-ing.de","threadId":"37348","inReplyTo":null,"subject":"Git on Mac OS X 10.4.10","fromName":"Markus Hitter","fromEmail":"mah@jump-ing.de","sentAt":"2014-08-14T12:13:15Z","receivedAt":"2014-08-14T12:13:15Z","isPatch":false,"sender":{"key":"mah@jump-ing.de","avatar":"https://avatars.githubusercontent.com/u/318581?v=4"},"body":"I'm new to this list, so: Hello everybody!\n\nMy backup servers run Mac OS X 10.4.10. Yes, these are old, but very\nreliable and easily up to the task. And Mac OS X 10.4 is the latest OS\nsupported there (PowerPC G3).\n\nRecently I tried to upgrade to v2.0.4 (from 1.7.11.4).\n\nIssue 1: I get many of these warnings:\n\n    LINK [many cases]\n/usr/bin/ld: warning multiple definitions of symbol _regcomp\nlibgit.a(regex.o) definition of _regcomp in section (__TEXT,__text)\n/usr/lib/gcc/powerpc-apple-darwin8/4.0.1/../../../libSystem.dylib(regcomp.So)\ndefinition of _regcomp\n/usr/bin/ld: warning multiple definitions of symbol _regexec\nlibgit.a(regex.o) definition of _regexec in section (__TEXT,__text)\n/usr/lib/gcc/powerpc-apple-darwin8/4.0.1/../../../libSystem.dylib(regexec.So)\ndefinition of _regexec\n/usr/bin/ld: warning multiple definitions of symbol _regfree\nlibgit.a(regex.o) definition of _regfree in section (__TEXT,__text)\n/usr/lib/gcc/powerpc-apple-darwin8/4.0.1/../../../libSystem.dylib(regfree.So)\ndefinition of _regfree\n\nIs this expected?\n\n\nIssue 2: I need this simple patch ...\n\n--- compat/apple-common-crypto.h.org\t2014-07-30 23:19:53.000000000 +0200\n+++ compat/apple-common-crypto.h\t2014-08-14 12:57:37.000000000 +0200\n@@ -2,7 +2,7 @@\n #define OPENSSL_NO_MD5\n #define HEADER_HMAC_H\n #define HEADER_SHA_H\n-#include <CommonCrypto/CommonHMAC.h>\n+//#include <CommonCrypto/CommonHMAC.h>\n #define HMAC_CTX CCHmacContext\n #define HMAC_Init(hmac, key, len, algo) CCHmacInit(hmac, algo, key, len)\n #define HMAC_Update CCHmacUpdate\n\n... and this command sequence ...\n\nmake all\ntouch imap-send.o\ntouch git-imap-send\nmake all\n\n... to get it compiling. All, except git-imap-send, obviously, which is\nno loss for my purposes.\n\nI tried many releases, the patch requirement started with about v1.9.1,\nthe git-imap-send failure somewhere between 1.8.1.6 and 1.8.4.3.\n\nTrying to be a good Open Source citizen, how would I proceed?\n\n\nThanks,\nMarkus\n\n\nP.S.1: error without the patch is:\n\nIn file included from git-compat-util.h:330,\n                 from cache.h:4,\n                 from advice.c:1:\ncompat/apple-common-crypto.h:5:37: error: CommonCrypto/CommonHMAC.h: No\nsuch file or directory\n\n\nP.S.2: error without faking git-imap-send is:\n\n    CC imap-send.o\nimap-send.c: In function ‘cram’:\nimap-send.c:881: error: ‘CCHmacContext’ undeclared (first use in this\nfunction)\nimap-send.c:881: error: (Each undeclared identifier is reported only once\nimap-send.c:881: error: for each function it appears in.)\nimap-send.c:881: error: parse error before ‘hmac’\nimap-send.c:896: error: ‘hmac’ undeclared (first use in this function)\nimap-send.c:896: error: ‘kCCHmacAlgMD5’ undeclared (first use in this\nfunction)\nmake: *** [imap-send.o] Error 1\n\n\n-- \n- - - - - - - - - - - - - - - - - - -\nDipl. Ing. (FH) Markus Hitter\nhttp://www.jump-ing.de/\n"},{"id":"247719","messageId":"53ECCA14.40900@web.de","threadId":"37348","inReplyTo":"53ECA7DB.7060407@jump-ing.de","subject":"Re: Git on Mac OS X 10.4.10","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2014-08-14T14:39:16Z","receivedAt":"2014-08-14T14:39:16Z","isPatch":false,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"On 08/14/2014 02:13 PM, Markus Hitter wrote:\n> I'm new to this list, so: Hello everybody!\n>\n> My backup servers run Mac OS X 10.4.10. Yes, these are old, but very\n> reliable and easily up to the task. And Mac OS X 10.4 is the latest OS\n> supported there (PowerPC G3).\n>\n> Recently I tried to upgrade to v2.0.4 (from 1.7.11.4).\n>\n> Issue 1: I get many of these warnings:\n>\n>      LINK [many cases]\n> /usr/bin/ld: warning multiple definitions of symbol _regcomp\n> libgit.a(regex.o) definition of _regcomp in section (__TEXT,__text)\n> /usr/lib/gcc/powerpc-apple-darwin8/4.0.1/../../../libSystem.dylib(regcomp.So)\n> definition of _regcomp\n> /usr/bin/ld: warning multiple definitions of symbol _regexec\n> libgit.a(regex.o) definition of _regexec in section (__TEXT,__text)\n> /usr/lib/gcc/powerpc-apple-darwin8/4.0.1/../../../libSystem.dylib(regexec.So)\n> definition of _regexec\n> /usr/bin/ld: warning multiple definitions of symbol _regfree\n> libgit.a(regex.o) definition of _regfree in section (__TEXT,__text)\n> /usr/lib/gcc/powerpc-apple-darwin8/4.0.1/../../../libSystem.dylib(regfree.So)\n> definition of _regfree\n>\n> Is this expected?\nNo.\nGit has its own regcomp() (and the regXXX() ) in ./compat/regex/*, and \nfor some reasons the linker\npicks them both from libgit.a (which is a static library) and the \ndynamic library in libSystem.dylib\n\nEither the linker needs to be convinced not to do that (by changing the \ncommand line to the linker,\nchanging the order of libraries may help, I don't know)\nOr each regcomp in the .h and .c files is changed into git_regcomp.\nThis change shouldn't break anything.\n\n>\n>\n> Issue 2: I need this simple patch ...\n>\n> --- compat/apple-common-crypto.h.org\t2014-07-30 23:19:53.000000000 +0200\n> +++ compat/apple-common-crypto.h\t2014-08-14 12:57:37.000000000 +0200\n> @@ -2,7 +2,7 @@\n>   #define OPENSSL_NO_MD5\n>   #define HEADER_HMAC_H\n>   #define HEADER_SHA_H\n> -#include <CommonCrypto/CommonHMAC.h>\n> +//#include <CommonCrypto/CommonHMAC.h>\n>   #define HMAC_CTX CCHmacContext\n>   #define HMAC_Init(hmac, key, len, algo) CCHmacInit(hmac, algo, key, len)\n>   #define HMAC_Update CCHmacUpdate\nThe  <CommonCrypto/CommonHMAC.h> is in Mac OS X 10.6 .. 10.9,\nbut not in 10.4 (I don't know about 10.5).\nYou can try to tweak the \"makefiles\",  search for NO_APPLE_COMMON_CRYPTO,\nand set NO_APPLE_COMMON_CRYPTO, but only  for Darwin 10.3 (or below)\n\n> ... and this command sequence ...\n>\n> make all\n> touch imap-send.o\n> touch git-imap-send\n> make all\n>\n> ... to get it compiling. All, except git-imap-send, obviously, which is\n> no loss for my purposes.\n>\n> I tried many releases, the patch requirement started with about v1.9.1,\n> the git-imap-send failure somewhere between 1.8.1.6 and 1.8.4.3.\n>\n> Trying to be a good Open Source citizen, how would I proceed?\nIf you want to share your changes, please send a patch to this list.\n> Thanks,\n> Markus\n"},{"id":"247725","messageId":"53ED0257.3070505@jump-ing.de","threadId":"37348","inReplyTo":"53ECCA14.40900@web.de","subject":"Re: Git on Mac OS X 10.4.10","fromName":"Markus Hitter","fromEmail":"mah@jump-ing.de","sentAt":"2014-08-14T18:39:19Z","receivedAt":"2014-08-14T18:39:19Z","isPatch":false,"sender":{"key":"mah@jump-ing.de","avatar":"https://avatars.githubusercontent.com/u/318581?v=4"},"body":"Am 14.08.2014 um 16:39 schrieb Torsten Bögershausen:\n> On 08/14/2014 02:13 PM, Markus Hitter wrote:\n>> Issue 2: I need this simple patch ...\n>>\n>> --- compat/apple-common-crypto.h.org    2014-07-30 23:19:53.000000000\n>> +0200\n>> +++ compat/apple-common-crypto.h    2014-08-14 12:57:37.000000000 +0200\n>> @@ -2,7 +2,7 @@\n>>   #define OPENSSL_NO_MD5\n>>   #define HEADER_HMAC_H\n>>   #define HEADER_SHA_H\n>> -#include <CommonCrypto/CommonHMAC.h>\n>> +//#include <CommonCrypto/CommonHMAC.h>\n>>   #define HMAC_CTX CCHmacContext\n>>   #define HMAC_Init(hmac, key, len, algo) CCHmacInit(hmac, algo, key,\n>> len)\n>>   #define HMAC_Update CCHmacUpdate\n> The  <CommonCrypto/CommonHMAC.h> is in Mac OS X 10.6 .. 10.9,\n> but not in 10.4 (I don't know about 10.5).\n> You can try to tweak the \"makefiles\",  search for NO_APPLE_COMMON_CRYPTO,\n> and set NO_APPLE_COMMON_CRYPTO, but only  for Darwin 10.3 (or below)\n\nThanks. This:\n\nexport NO_APPLE_COMMON_CRYPTO=yes\nmake configure\nCFLAGS=-O2 ./configure --without-tcltk --prefix=/usr/global\nmake all\n\ncompiles fine on 10.4.10. Would a configure patch checking for the\nexistence of CommonHMAC.h and, if not found, defining this variable, be\nacceptable? Googling around, it's a bit unclear to me on how to\ncontribute something to Git.\n\n\nMarkus\n\n-- \n- - - - - - - - - - - - - - - - - - -\nDipl. Ing. (FH) Markus Hitter\nhttp://www.jump-ing.de/\n"},{"id":"247730","messageId":"20140814222939.GA32124@google.com","threadId":"37348","inReplyTo":"53ED0257.3070505@jump-ing.de","subject":"Re: Git on Mac OS X 10.4.10","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2014-08-14T22:29:39Z","receivedAt":"2014-08-14T22:29:39Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi Markus,\n\n> export NO_APPLE_COMMON_CRYPTO=yes\n> make configure\n> CFLAGS=-O2 ./configure --without-tcltk --prefix=/usr/global\n> make all\n>\n> compiles fine on 10.4.10. Would a configure patch checking for the\n> existence of CommonHMAC.h and, if not found, defining this variable, be\n> acceptable?\n\nYes, that sounds useful.\n\nOrthogonal to that: a patch to the Darwin section of config.mak.uname\nso you can build without the 'make configure' would be even more\nwelcome. :)\n\nSee Documentation/SubmittingPatches for details about how to\ncontribute to git.  (Or if you're short on time, see section 5 of that\nfile, \"Sign your work\", and then push your code somewhere and tell us\nabout it.)\n\nThanks,\nJonathan\n"},{"id":"247732","messageId":"xmqqppg21wyk.fsf@gitster.dls.corp.google.com","threadId":"37348","inReplyTo":"53ED0257.3070505@jump-ing.de","subject":"Re: Git on Mac OS X 10.4.10","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-08-14T23:18:59Z","receivedAt":"2014-08-14T23:18:59Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Markus Hitter <mah@jump-ing.de> writes:\n\n>> The  <CommonCrypto/CommonHMAC.h> is in Mac OS X 10.6 .. 10.9,\n>> but not in 10.4 (I don't know about 10.5).\n\nIs this about platform dependency, or what the end user happens to\nchoose to install (in other words, is there an add-on users of 10.4\ncan choose to add, which allows them to use that header)?\n"},{"id":"247736","messageId":"273241271546c07e692ae93774993f5@74d39fa044aa309eaea14b9f57fe79c","threadId":"37348","inReplyTo":"xmqqppg21wyk.fsf@gitster.dls.corp.google.com","subject":"Re: Git on Mac OS X 10.4.10","fromName":"Kyle J. McKay","fromEmail":"mackyle@gmail.com","sentAt":"2014-08-15T07:46:11Z","receivedAt":"2014-08-15T07:46:11Z","isPatch":false,"sender":{"key":"mackyle@gmail.com","avatar":"https://avatars.githubusercontent.com/u/813346?v=4"},"body":"On Aug 14, 2014, at 16:18, Junio C Hamano wrote:\n\n> Markus Hitter <mah@jump-ing.de> writes:\n>\n>>> The  <CommonCrypto/CommonHMAC.h> is in Mac OS X 10.6 .. 10.9,\n>>> but not in 10.4 (I don't know about 10.5).\n\nThat header is new with 10.5\n\n> Is this about platform dependency, or what the end user happens to\n> choose to install (in other words, is there an add-on users of 10.4\n> can choose to add, which allows them to use that header)?\n\nNope, it's a platform dependency.  Not available prior to 10.5.\n\nThe below patch does the right thing.  Conveniently there's already\na test for 10.4 and earlier so only a single line need be added.\n\n--Kyle\n\n---- 8< ----\nSubject: [PATCH] config.mak.uname: set NO_APPLE_COMMON_CRYPTO on older systems\n\nOlder MacOS systems prior to 10.5 do not have the CommonCrypto\nsupport Git uses so set NO_APPLE_COMMON_CRYPTO on those systems.\n\nSigned-off-by: Kyle J. McKay <mackyle@gmail.com>\n---\n config.mak.uname | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex 7846bd76..f8e12c96 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -88,6 +88,7 @@ ifeq ($(uname_S),Darwin)\n \tNEEDS_LIBICONV = YesPlease\n \tifeq ($(shell expr \"$(uname_R)\" : '[15678]\\.'),2)\n \t\tOLD_ICONV = UnfortunatelyYes\n+\t\tNO_APPLE_COMMON_CRYPTO = YesPlease\n \tendif\n \tifeq ($(shell expr \"$(uname_R)\" : '[15]\\.'),2)\n \t\tNO_STRLCPY = YesPlease\n-- \n1.8.5\n"},{"id":"247737","messageId":"CAPig+cSGs-MzG=nG7ONRvcMhnrJx4vUri2d5nHovQiQ9w+ckDQ@mail.gmail.com","threadId":"37348","inReplyTo":"273241271546c07e692ae93774993f5@74d39fa044aa309eaea14b9f57fe79c","subject":"Re: Git on Mac OS X 10.4.10","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2014-08-15T09:39:20Z","receivedAt":"2014-08-15T09:39:20Z","isPatch":false,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Fri, Aug 15, 2014 at 3:46 AM, Kyle J. McKay <mackyle@gmail.com> wrote:\n> On Aug 14, 2014, at 16:18, Junio C Hamano wrote:\n>\n>> Markus Hitter <mah@jump-ing.de> writes:\n>>\n>>>> The  <CommonCrypto/CommonHMAC.h> is in Mac OS X 10.6 .. 10.9,\n>>>> but not in 10.4 (I don't know about 10.5).\n>\n> That header is new with 10.5\n>\n>> Is this about platform dependency, or what the end user happens to\n>> choose to install (in other words, is there an add-on users of 10.4\n>> can choose to add, which allows them to use that header)?\n>\n> Nope, it's a platform dependency.  Not available prior to 10.5.\n>\n> The below patch does the right thing.  Conveniently there's already\n> a test for 10.4 and earlier so only a single line need be added.\n\nI tested with Mac OS X 10.5 (and 10.9) to verify that there is no\nregression. Works fine.\n\n> --Kyle\n>\n> ---- 8< ----\n> Subject: [PATCH] config.mak.uname: set NO_APPLE_COMMON_CRYPTO on older systems\n>\n> Older MacOS systems prior to 10.5 do not have the CommonCrypto\n> support Git uses so set NO_APPLE_COMMON_CRYPTO on those systems.\n>\n> Signed-off-by: Kyle J. McKay <mackyle@gmail.com>\n> ---\n>  config.mak.uname | 1 +\n>  1 file changed, 1 insertion(+)\n>\n> diff --git a/config.mak.uname b/config.mak.uname\n> index 7846bd76..f8e12c96 100644\n> --- a/config.mak.uname\n> +++ b/config.mak.uname\n> @@ -88,6 +88,7 @@ ifeq ($(uname_S),Darwin)\n>         NEEDS_LIBICONV = YesPlease\n>         ifeq ($(shell expr \"$(uname_R)\" : '[15678]\\.'),2)\n>                 OLD_ICONV = UnfortunatelyYes\n> +               NO_APPLE_COMMON_CRYPTO = YesPlease\n>         endif\n>         ifeq ($(shell expr \"$(uname_R)\" : '[15]\\.'),2)\n>                 NO_STRLCPY = YesPlease\n> --\n> 1.8.5\n"},{"id":"247741","messageId":"53EDFE44.6000800@jump-ing.de","threadId":"37348","inReplyTo":"273241271546c07e692ae93774993f5@74d39fa044aa309eaea14b9f57fe79c","subject":"Re: Git on Mac OS X 10.4.10","fromName":"Markus Hitter","fromEmail":"mah@jump-ing.de","sentAt":"2014-08-15T12:34:12Z","receivedAt":"2014-08-15T12:34:12Z","isPatch":false,"sender":{"key":"mah@jump-ing.de","avatar":"https://avatars.githubusercontent.com/u/318581?v=4"},"body":"Am 15.08.2014 um 09:46 schrieb Kyle J. McKay:\n> The below patch does the right thing.  Conveniently there's already\n> a test for 10.4 and earlier so only a single line need be added.\n\nI can confirm this patch works. Thank you very much.\n\n\n> ---- 8< ----\n> Subject: [PATCH] config.mak.uname: set NO_APPLE_COMMON_CRYPTO on older systems\n> \n> Older MacOS systems prior to 10.5 do not have the CommonCrypto\n> support Git uses so set NO_APPLE_COMMON_CRYPTO on those systems.\n> \n> Signed-off-by: Kyle J. McKay <mackyle@gmail.com>\n> ---\n>  config.mak.uname | 1 +\n>  1 file changed, 1 insertion(+)\n> \n> diff --git a/config.mak.uname b/config.mak.uname\n> index 7846bd76..f8e12c96 100644\n> --- a/config.mak.uname\n> +++ b/config.mak.uname\n> @@ -88,6 +88,7 @@ ifeq ($(uname_S),Darwin)\n>  \tNEEDS_LIBICONV = YesPlease\n>  \tifeq ($(shell expr \"$(uname_R)\" : '[15678]\\.'),2)\n>  \t\tOLD_ICONV = UnfortunatelyYes\n> +\t\tNO_APPLE_COMMON_CRYPTO = YesPlease\n>  \tendif\n>  \tifeq ($(shell expr \"$(uname_R)\" : '[15]\\.'),2)\n>  \t\tNO_STRLCPY = YesPlease\n> \n\n\n-- \n- - - - - - - - - - - - - - - - - - -\nDipl. Ing. (FH) Markus Hitter\nhttp://www.jump-ing.de/\n"},{"id":"247742","messageId":"53EE01B4.3040905@jump-ing.de","threadId":"37348","inReplyTo":"20140814222939.GA32124@google.com","subject":"Re: Git on Mac OS X 10.4.10","fromName":"Markus Hitter","fromEmail":"mah@jump-ing.de","sentAt":"2014-08-15T12:48:52Z","receivedAt":"2014-08-15T12:48:52Z","isPatch":false,"sender":{"key":"mah@jump-ing.de","avatar":"https://avatars.githubusercontent.com/u/318581?v=4"},"body":"Am 15.08.2014 um 00:29 schrieb Jonathan Nieder:\n> Orthogonal to that: a patch to the Darwin section of config.mak.uname\n> so you can build without the 'make configure' would be even more\n> welcome. :)\n\nOn this one. You need at least NO_GETTEXT and NO_EXPAT. I've attached a config.mak.autogen to show what's needed.\n\nHowever, if somebody chooses to install gettext or expat after OS installation, how is the build process expected to detect this? IMHO, checking for OS version number instead of actually available features is the wrong thing to do.\n\n\nMarkus\n\n-- \n- - - - - - - - - - - - - - - - - - -\nDipl. Ing. (FH) Markus Hitter\nhttp://www.jump-ing.de/\n\n\n# git Makefile configuration, included in main Makefile\n# config.mak.autogen.  Generated from config.mak.in by configure.\n\nCC = cc\nCFLAGS = -g -O2\nCPPFLAGS = \nLDFLAGS = \nAR = ar\nTAR = tar\nDIFF = diff\nPACKAGE_TARNAME = git\n#INSTALL = @INSTALL@\t\t# needs install-sh or install.sh in sources\n\nprefix = /usr/local\nexec_prefix = ${prefix}\nbindir = ${exec_prefix}/bin\ngitexecdir = ${exec_prefix}/libexec/git-core\ndatarootdir = @datarootdir@\ntemplate_dir = ${prefix}/share/git-core/templates\nsysconfdir = ${prefix}/etc\ndocdir = @docdir@\n\nmandir = ${prefix}/man\nhtmldir = @htmldir@\n\nAUTOCONFIGURED=YesPlease\nINLINE=\nCC_LD_DYNPATH=\nTCLTK_PATH=wish\nNEEDS_SSL_WITH_CRYPTO=\nNO_OPENSSL=\nNO_CURL=\nNO_EXPAT=YesPlease\nNEEDS_LIBICONV=YesPlease\nNO_ICONV=\nNO_DEFLATE_BOUND=\nNEEDS_SOCKET=\nNO_INET_NTOP=\nNO_INET_PTON=\nNO_HSTRERROR=\nNEEDS_RESOLV=\nNEEDS_LIBGEN=\nLIBC_CONTAINS_LIBINTL=\nNO_GETTEXT=YesPlease\nNO_SYS_SELECT_H=\nNO_SYS_POLL_H=\nNO_INTTYPES_H=\nOLD_ICONV=UnfortunatelyYes\nSOCKLEN_T=\nNO_D_INO_IN_DIRENT=\nNO_D_TYPE_IN_DIRENT=\nNO_GECOS_IN_PWENT=\nNO_SOCKADDR_STORAGE=\nNO_IPV6=\nNO_REGEX=\nFREAD_READS_DIRECTORIES=\nSNPRINTF_RETURNS_BOGUS=\nNO_LIBGEN_H=\nHAVE_PATHS_H=YesPlease\nHAVE_LIBCHARSET_H=YesPlease\nHAVE_STRINGS_H=YesPlease\nCHARSET_LIB=-liconv\nNO_STRCASESTR=\nNO_MEMMEM=YesPlease\nNO_STRLCPY=\nNO_UINTMAX_T=\nNO_STRTOUMAX=\nNO_SETENV=\nNO_UNSETENV=\nNO_MKDTEMP=\nNO_MKSTEMPS=\nNO_INITGROUPS=\nPTHREAD_CFLAGS=\nPTHREAD_LIBS=\nNO_PTHREADS=\n"},{"id":"247745","messageId":"xmqqlhqp1zt1.fsf@gitster.dls.corp.google.com","threadId":"37348","inReplyTo":"273241271546c07e692ae93774993f5@74d39fa044aa309eaea14b9f57fe79c","subject":"Re: Git on Mac OS X 10.4.10","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-08-15T16:29:46Z","receivedAt":"2014-08-15T16:29:46Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Kyle J. McKay\" <mackyle@gmail.com> writes:\n\n> On Aug 14, 2014, at 16:18, Junio C Hamano wrote:\n>\n>> Markus Hitter <mah@jump-ing.de> writes:\n>>\n>>>> The  <CommonCrypto/CommonHMAC.h> is in Mac OS X 10.6 .. 10.9,\n>>>> but not in 10.4 (I don't know about 10.5).\n>\n> That header is new with 10.5\n>\n>> Is this about platform dependency, or what the end user happens to\n>> choose to install (in other words, is there an add-on users of 10.4\n>> can choose to add, which allows them to use that header)?\n>\n> Nope, it's a platform dependency.  Not available prior to 10.5.\n>\n> The below patch does the right thing.  Conveniently there's already\n> a test for 10.4 and earlier so only a single line need be added.\n>\n> --Kyle\n\nNice.  Use of APPLE_COMMON_CRYPTO thing is not new to the upcoming\nrelease, so let me queue it for the next development cycle, not\napplying directly before curring 2.1 release today.\n\nThanks.\n\n\n>\n> ---- 8< ----\n> Subject: [PATCH] config.mak.uname: set NO_APPLE_COMMON_CRYPTO on older systems\n>\n> Older MacOS systems prior to 10.5 do not have the CommonCrypto\n> support Git uses so set NO_APPLE_COMMON_CRYPTO on those systems.\n>\n> Signed-off-by: Kyle J. McKay <mackyle@gmail.com>\n> ---\n>  config.mak.uname | 1 +\n>  1 file changed, 1 insertion(+)\n>\n> diff --git a/config.mak.uname b/config.mak.uname\n> index 7846bd76..f8e12c96 100644\n> --- a/config.mak.uname\n> +++ b/config.mak.uname\n> @@ -88,6 +88,7 @@ ifeq ($(uname_S),Darwin)\n>  \tNEEDS_LIBICONV = YesPlease\n>  \tifeq ($(shell expr \"$(uname_R)\" : '[15678]\\.'),2)\n>  \t\tOLD_ICONV = UnfortunatelyYes\n> +\t\tNO_APPLE_COMMON_CRYPTO = YesPlease\n>  \tendif\n>  \tifeq ($(shell expr \"$(uname_R)\" : '[15]\\.'),2)\n>  \t\tNO_STRLCPY = YesPlease\n"},{"id":"247746","messageId":"xmqqbnrl1ya1.fsf@gitster.dls.corp.google.com","threadId":"37348","inReplyTo":"273241271546c07e692ae93774993f5@74d39fa044aa309eaea14b9f57fe79c","subject":"Re: Git on Mac OS X 10.4.10","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-08-15T17:02:46Z","receivedAt":"2014-08-15T17:02:46Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Kyle J. McKay\" <mackyle@gmail.com> writes:\n\n> The below patch does the right thing.  Conveniently there's already\n> a test for 10.4 and earlier so only a single line need be added.\n>\n> --Kyle\n>\n> ---- 8< ----\n> Subject: [PATCH] config.mak.uname: set NO_APPLE_COMMON_CRYPTO on older systems\n>\n> Older MacOS systems prior to 10.5 do not have the CommonCrypto\n> support Git uses so set NO_APPLE_COMMON_CRYPTO on those systems.\n>\n> Signed-off-by: Kyle J. McKay <mackyle@gmail.com>\n> ---\n>  config.mak.uname | 1 +\n>  1 file changed, 1 insertion(+)\n>\n> diff --git a/config.mak.uname b/config.mak.uname\n> index 7846bd76..f8e12c96 100644\n> --- a/config.mak.uname\n> +++ b/config.mak.uname\n> @@ -88,6 +88,7 @@ ifeq ($(uname_S),Darwin)\n>  \tNEEDS_LIBICONV = YesPlease\n>  \tifeq ($(shell expr \"$(uname_R)\" : '[15678]\\.'),2)\n>  \t\tOLD_ICONV = UnfortunatelyYes\n> +\t\tNO_APPLE_COMMON_CRYPTO = YesPlease\n>  \tendif\n>  \tifeq ($(shell expr \"$(uname_R)\" : '[15]\\.'),2)\n>  \t\tNO_STRLCPY = YesPlease\n\nBy the way, can we document this \"uname_R on MacOS X\" business\nnearby, perhaps like this?\n\n-- >8 --\nSubject: config.mak.uname: add hint on uname_R for MacOS X\n\nI always have to scratch my head every time I see this cryptic\npattern \"[15678]\\.\"; leave a short note to remind the maintainer\nand the reviewers.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n config.mak.uname | 4 ++++\n 1 file changed, 4 insertions(+)\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex f8e12c9..7e49aca 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -86,6 +86,10 @@ ifeq ($(uname_S),Darwin)\n \tNEEDS_CRYPTO_WITH_SSL = YesPlease\n \tNEEDS_SSL_WITH_CRYPTO = YesPlease\n \tNEEDS_LIBICONV = YesPlease\n+\t# Note: $(uname_R) gives us the underlying Darwin version.\n+\t# - MacOS 10.0 = Darwin 1.*\n+\t# - MacOS 10.x.? = Darwin (x+4).* for (1 <= x)\n+\t# i.e. \"begins with [15678] and the a dot\" means \"10.4.* or older\".\n \tifeq ($(shell expr \"$(uname_R)\" : '[15678]\\.'),2)\n \t\tOLD_ICONV = UnfortunatelyYes\n \t\tNO_APPLE_COMMON_CRYPTO = YesPlease\n"},{"id":"247750","messageId":"FF233C51-7AEA-4A10-8446-D8233F55E89B@gmail.com","threadId":"37348","inReplyTo":"xmqqbnrl1ya1.fsf@gitster.dls.corp.google.com","subject":"Re: Git on Mac OS X 10.4.10","fromName":"Kyle J. McKay","fromEmail":"mackyle@gmail.com","sentAt":"2014-08-15T17:56:41Z","receivedAt":"2014-08-15T17:56:41Z","isPatch":false,"sender":{"key":"mackyle@gmail.com","avatar":"https://avatars.githubusercontent.com/u/813346?v=4"},"body":"On Aug 15, 2014, at 10:02, Junio C Hamano wrote:\n\n> By the way, can we document this \"uname_R on MacOS X\" business\n> nearby, perhaps like this?\n>\n> -- >8 --\n> Subject: config.mak.uname: add hint on uname_R for MacOS X\n>\n> I always have to scratch my head every time I see this cryptic\n> pattern \"[15678]\\.\"; leave a short note to remind the maintainer\n> and the reviewers.\n>\n> Signed-off-by: Junio C Hamano <gitster@pobox.com>\n> ---\n> config.mak.uname | 4 ++++\n> 1 file changed, 4 insertions(+)\n>\n> diff --git a/config.mak.uname b/config.mak.uname\n> index f8e12c9..7e49aca 100644\n> --- a/config.mak.uname\n> +++ b/config.mak.uname\n> @@ -86,6 +86,10 @@ ifeq ($(uname_S),Darwin)\n> \tNEEDS_CRYPTO_WITH_SSL = YesPlease\n> \tNEEDS_SSL_WITH_CRYPTO = YesPlease\n> \tNEEDS_LIBICONV = YesPlease\n> +\t# Note: $(uname_R) gives us the underlying Darwin version.\n> +\t# - MacOS 10.0 = Darwin 1.*\n> +\t# - MacOS 10.x.? = Darwin (x+4).* for (1 <= x)\n> +\t# i.e. \"begins with [15678] and the a dot\" means \"10.4.* or older\".\n\ns/the a dot/a dot/\n\n> \tifeq ($(shell expr \"$(uname_R)\" : '[15678]\\.'),2)\n> \t\tOLD_ICONV = UnfortunatelyYes\n> \t\tNO_APPLE_COMMON_CRYPTO = YesPlease\n\nOtherwise looks good.  Mac OS X 10.1.0 doesn't actually fit the  \npattern (it's still Darwin 1.*), but it's so old and it doesn't affect  \nthe 10.4.* or older test (or the later 10.1.* or older test), so let's  \njust ignore that anomaly.  :)\n"},{"id":"247751","messageId":"xmqqy4upzl1s.fsf@gitster.dls.corp.google.com","threadId":"37348","inReplyTo":"FF233C51-7AEA-4A10-8446-D8233F55E89B@gmail.com","subject":"Re: Git on Mac OS X 10.4.10","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-08-15T18:04:31Z","receivedAt":"2014-08-15T18:04:31Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Kyle J. McKay\" <mackyle@gmail.com> writes:\n\n>> +\t# i.e. \"begins with [15678] and the a dot\" means \"10.4.* or older\".\n>\n> s/the a dot/a dot/\n>\n>> \tifeq ($(shell expr \"$(uname_R)\" : '[15678]\\.'),2)\n>> \t\tOLD_ICONV = UnfortunatelyYes\n>> \t\tNO_APPLE_COMMON_CRYPTO = YesPlease\n>\n> Otherwise looks good.  Mac OS X 10.1.0 doesn't actually fit the\n> pattern (it's still Darwin 1.*), but it's so old and it doesn't affect\n> the 10.4.* or older test (or the later 10.1.* or older test), so let's\n> just ignore that anomaly.  :)\n\nThanks.  The 10.1.0 anomaly actually was bothering me, too.  How\nabout doing it this way?\n\n-- >8 --\nSubject: [PATCH v2] config.mak.uname: add hint on uname_R for MacOS X\n\nI always have to scratch my head every time I see this cryptic\npattern \"[15678]\\.\"; leave a short note to remind the maintainer\nand the reviewers.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n config.mak.uname | 4 ++++\n 1 file changed, 4 insertions(+)\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex f8e12c9..414760f 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -86,6 +86,10 @@ ifeq ($(uname_S),Darwin)\n \tNEEDS_CRYPTO_WITH_SSL = YesPlease\n \tNEEDS_SSL_WITH_CRYPTO = YesPlease\n \tNEEDS_LIBICONV = YesPlease\n+\t# Note: $(uname_R) gives us the underlying Darwin version.\n+\t# - MacOS 10.0.* and MacOS 10.1.0 = Darwin 1.*\n+\t# - MacOS 10.x.* = Darwin (x+4).* for (1 <= x)\n+\t# i.e. \"begins with [15678] and a dot\" means \"10.4.* or older\".\n \tifeq ($(shell expr \"$(uname_R)\" : '[15678]\\.'),2)\n \t\tOLD_ICONV = UnfortunatelyYes\n \t\tNO_APPLE_COMMON_CRYPTO = YesPlease\n-- \n2.1.0-rc2-283-g1433d67\n"},{"id":"247752","messageId":"3463C0CF-5E65-4934-A6C2-D466AB7B1144@gmail.com","threadId":"37348","inReplyTo":"xmqqy4upzl1s.fsf@gitster.dls.corp.google.com","subject":"Re: Git on Mac OS X 10.4.10","fromName":"Kyle J. McKay","fromEmail":"mackyle@gmail.com","sentAt":"2014-08-15T18:51:11Z","receivedAt":"2014-08-15T18:51:11Z","isPatch":false,"sender":{"key":"mackyle@gmail.com","avatar":"https://avatars.githubusercontent.com/u/813346?v=4"},"body":"On Aug 15, 2014, at 11:04, Junio C Hamano wrote:\n\n> The 10.1.0 anomaly actually was bothering me, too.  How\n> about doing it this way?\n>\n> -- >8 --\n> Subject: [PATCH v2] config.mak.uname: add hint on uname_R for MacOS X\n>\n> I always have to scratch my head every time I see this cryptic\n> pattern \"[15678]\\.\"; leave a short note to remind the maintainer\n> and the reviewers.\n>\n> Signed-off-by: Junio C Hamano <gitster@pobox.com>\n> ---\n> config.mak.uname | 4 ++++\n> 1 file changed, 4 insertions(+)\n>\n> diff --git a/config.mak.uname b/config.mak.uname\n> index f8e12c9..414760f 100644\n> --- a/config.mak.uname\n> +++ b/config.mak.uname\n> @@ -86,6 +86,10 @@ ifeq ($(uname_S),Darwin)\n> \tNEEDS_CRYPTO_WITH_SSL = YesPlease\n> \tNEEDS_SSL_WITH_CRYPTO = YesPlease\n> \tNEEDS_LIBICONV = YesPlease\n> +\t# Note: $(uname_R) gives us the underlying Darwin version.\n> +\t# - MacOS 10.0.* and MacOS 10.1.0 = Darwin 1.*\n> +\t# - MacOS 10.x.* = Darwin (x+4).* for (1 <= x)\n> +\t# i.e. \"begins with [15678] and a dot\" means \"10.4.* or older\".\n> \tifeq ($(shell expr \"$(uname_R)\" : '[15678]\\.'),2)\n> \t\tOLD_ICONV = UnfortunatelyYes\n> \t\tNO_APPLE_COMMON_CRYPTO = YesPlease\n> -- \n> 2.1.0-rc2-283-g1433d67\n>\n\nVery nice.\n"}]}