{"thread":{"id":"37279","subject":"[PATCH] Documentation: avoid dangling modifier for imap-send","startedAt":"2014-08-02T23:57:01Z","lastAt":"2014-08-05T20:48:21Z","messageCount":11,"participants":["brian m. carlson","Junio C Hamano","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"247186","messageId":"1407023821-103681-1-git-send-email-sandals@crustytoothpaste.net","threadId":"37279","inReplyTo":null,"subject":"[PATCH] Documentation: avoid dangling modifier for imap-send","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2014-08-02T23:57:01Z","receivedAt":"2014-08-02T23:57:01Z","isPatch":true,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"Avoid a nonsensical misreading by moving the modifier closer to the\nverb.\n\nSigned-off-by: brian m. carlson \n---\n Documentation/git-imap-send.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-imap-send.txt b/Documentation/git-imap-send.txt\nindex 875d283..23231e1 100644\n--- a/Documentation/git-imap-send.txt\n+++ b/Documentation/git-imap-send.txt\n@@ -43,7 +43,7 @@ imap.folder::\n imap.tunnel::\n \tCommand used to setup a tunnel to the IMAP server through which\n \tcommands will be piped instead of using a direct network connection\n-\tto the server. Required when imap.host is not set to use imap-send.\n+\tto the server. Required to use imap-send when imap.host is not set.\n \n imap.host::\n \tA URL identifying the server. Use a `imap://` prefix for non-secure\n-- \n2.0.1\n"},{"id":"247187","messageId":"1407024847-104449-1-git-send-email-sandals@crustytoothpaste.net","threadId":"37279","inReplyTo":"1407023821-103681-1-git-send-email-sandals@crustytoothpaste.net","subject":"[PATCH v2] Documentation: avoid dangling modifier for imap-send","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2014-08-03T00:14:07Z","receivedAt":"2014-08-03T00:14:07Z","isPatch":true,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"Avoid a nonsensical misreading by moving the modifier closer to the\nword it modifies.\n\nSigned-off-by: brian m. carlson \n---\n Documentation/git-imap-send.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-imap-send.txt b/Documentation/git-imap-send.txt\nindex 875d283..23231e1 100644\n--- a/Documentation/git-imap-send.txt\n+++ b/Documentation/git-imap-send.txt\n@@ -43,7 +43,7 @@ imap.folder::\n imap.tunnel::\n \tCommand used to setup a tunnel to the IMAP server through which\n \tcommands will be piped instead of using a direct network connection\n-\tto the server. Required when imap.host is not set to use imap-send.\n+\tto the server. Required to use imap-send when imap.host is not set.\n \n imap.host::\n \tA URL identifying the server. Use a `imap://` prefix for non-secure\n-- \n2.0.1\n"},{"id":"247221","messageId":"xmqq8un4rtv6.fsf@gitster.dls.corp.google.com","threadId":"37279","inReplyTo":"1407024847-104449-1-git-send-email-sandals@crustytoothpaste.net","subject":"Re: [PATCH v2] Documentation: avoid dangling modifier for imap-send","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-08-04T18:29:33Z","receivedAt":"2014-08-04T18:29:33Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"brian m. carlson\" writes:\n\n> Avoid a nonsensical misreading by moving the modifier closer to the\n> word it modifies.\n>\n> Signed-off-by: brian m. carlson \n> ---\n> Documentation/git-imap-send.txt | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/git-imap-send.txt b/Documentation/git-imap-send.txt\n> index 875d283..23231e1 100644\n> --- a/Documentation/git-imap-send.txt\n> +++ b/Documentation/git-imap-send.txt\n> @@ -43,7 +43,7 @@ imap.folder::\n> imap.tunnel::\n> \tCommand used to setup a tunnel to the IMAP server through which\n> \tcommands will be piped instead of using a direct network connection\n> -\tto the server. Required when imap.host is not set to use imap-send.\n> +\tto the server. Required to use imap-send when imap.host is not set.\n\nTo be honest, I find both versions are equally confusing.\n\nHow about dropping the three words \"to use imap-send\"?\n"},{"id":"247264","messageId":"20140805005451.GA10435@vauxhall.crustytoothpaste.net","threadId":"37279","inReplyTo":"xmqq8un4rtv6.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH v2] Documentation: avoid dangling modifier for imap-send","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2014-08-05T00:54:51Z","receivedAt":"2014-08-05T00:54:51Z","isPatch":true,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"On Mon, Aug 04, 2014 at 11:29:33AM -0700, Junio C Hamano wrote:\n> \"brian m. carlson\" writes:\n> \n> > Avoid a nonsensical misreading by moving the modifier closer to the\n> > word it modifies.\n> >\n> > Signed-off-by: brian m. carlson \n> > ---\n> > Documentation/git-imap-send.txt | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/Documentation/git-imap-send.txt b/Documentation/git-imap-send.txt\n> > index 875d283..23231e1 100644\n> > --- a/Documentation/git-imap-send.txt\n> > +++ b/Documentation/git-imap-send.txt\n> > @@ -43,7 +43,7 @@ imap.folder::\n> > imap.tunnel::\n> > \tCommand used to setup a tunnel to the IMAP server through which\n> > \tcommands will be piped instead of using a direct network connection\n> > -\tto the server. Required when imap.host is not set to use imap-send.\n> > +\tto the server. Required to use imap-send when imap.host is not set.\n> \n> To be honest, I find both versions are equally confusing.\n> \n> How about dropping the three words \"to use imap-send\"?\n\nFine by me.\n\n-- \nbrian m. carlson / brian with sandals: Houston, Texas, US\n+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only\nOpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187\n"},{"id":"247265","messageId":"1407201189-12787-1-git-send-email-sandals@crustytoothpaste.net","threadId":"37279","inReplyTo":"xmqq8un4rtv6.fsf@gitster.dls.corp.google.com","subject":"[PATCH v2] Documentation: avoid dangling modifier for imap-send","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2014-08-05T01:13:09Z","receivedAt":"2014-08-05T01:13:09Z","isPatch":true,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"Avoid a nonsensical misreading by removing needless text.\n\nSigned-off-by: brian m. carlson \n---\n Documentation/git-imap-send.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-imap-send.txt b/Documentation/git-imap-send.txt\nindex 875d283..e50b1c4 100644\n--- a/Documentation/git-imap-send.txt\n+++ b/Documentation/git-imap-send.txt\n@@ -43,7 +43,7 @@ imap.folder::\n imap.tunnel::\n \tCommand used to setup a tunnel to the IMAP server through which\n \tcommands will be piped instead of using a direct network connection\n-\tto the server. Required when imap.host is not set to use imap-send.\n+\tto the server. Required when imap.host is not set.\n \n imap.host::\n \tA URL identifying the server. Use a `imap://` prefix for non-secure\n-- \n2.0.1\n"},{"id":"247266","messageId":"20140805024535.GV12427@google.com","threadId":"37279","inReplyTo":"1407201189-12787-1-git-send-email-sandals@crustytoothpaste.net","subject":"Re: [PATCH v2] Documentation: avoid dangling modifier for imap-send","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2014-08-05T02:45:35Z","receivedAt":"2014-08-05T02:45:35Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"brian m. carlson wrote:\n\n> --- a/Documentation/git-imap-send.txt\n> +++ b/Documentation/git-imap-send.txt\n> @@ -43,7 +43,7 @@ imap.folder::\n> imap.tunnel::\n> \tCommand used to setup a tunnel to the IMAP server through which\n> \tcommands will be piped instead of using a direct network connection\n> -\tto the server. Required when imap.host is not set to use imap-send.\n> +\tto the server. Required when imap.host is not set.\n\nShould the neighboring instances of '[Rr]equired to use imap-send\nbe changed to plain \"Required\", too? (I suspect yes.)\n\nThanks,\nJonathan\n"},{"id":"247267","messageId":"20140805025108.GW12427@google.com","threadId":"37279","inReplyTo":"20140805024535.GV12427@google.com","subject":"Re: [PATCH v2] Documentation: avoid dangling modifier for imap-send","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2014-08-05T02:51:08Z","receivedAt":"2014-08-05T02:51:08Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Jonathan Nieder wrote:\n\n> Should the neighboring instances of '[Rr]equired to use imap-send\n> be changed to plain \"Required\", too? (I suspect yes.)\n\nHere's what that would look like.\n\n-- >8 --\nFrom: brian m. carlson \nSubject: imap-send doc: omit confusing \"to use imap-send\" modifier\n\nIt wouldn't make sense for these configuration variables to be\nrequired for Git in general to function. 'Required' in this context\nmeans required for git imap-send to work.\n\nNoticed while trying to figure out what the sentence describing\nimap.tunnel meant.\n\n[jn: expanded to also simplify explanation of imap.folder and\n imap.host in the same way]\n\nSigned-off-by: brian m. carlson \nSigned-off-by: Jonathan Nieder \n---\n Documentation/git-imap-send.txt | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/git-imap-send.txt b/Documentation/git-imap-send.txt\nindex 875d283..d3b465d 100644\n--- a/Documentation/git-imap-send.txt\n+++ b/Documentation/git-imap-send.txt\n@@ -38,17 +38,17 @@ Variables\n imap.folder::\n \tThe folder to drop the mails into, which is typically the Drafts\n \tfolder. For example: \"INBOX.Drafts\", \"INBOX/Drafts\" or\n-\t\"[Gmail]/Drafts\". Required to use imap-send.\n+\t\"[Gmail]/Drafts\". Required.\n \n imap.tunnel::\n \tCommand used to setup a tunnel to the IMAP server through which\n \tcommands will be piped instead of using a direct network connection\n-\tto the server. Required when imap.host is not set to use imap-send.\n+\tto the server. Required when imap.host is not set.\n \n imap.host::\n \tA URL identifying the server. Use a `imap://` prefix for non-secure\n \tconnections and a `imaps://` prefix for secure connections.\n-\tIgnored when imap.tunnel is set, but required to use imap-send\n+\tIgnored when imap.tunnel is set, but required.\n \totherwise.\n \n imap.user::\n-- \n"},{"id":"247268","messageId":"20140805025229.GB10435@vauxhall.crustytoothpaste.net","threadId":"37279","inReplyTo":"20140805025108.GW12427@google.com","subject":"Re: [PATCH v2] Documentation: avoid dangling modifier for imap-send","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2014-08-05T02:52:29Z","receivedAt":"2014-08-05T02:52:29Z","isPatch":true,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"On Mon, Aug 04, 2014 at 07:51:08PM -0700, Jonathan Nieder wrote:\n> Jonathan Nieder wrote:\n> \n> > Should the neighboring instances of '[Rr]equired to use imap-send\n> > be changed to plain \"Required\", too? (I suspect yes.)\n> \n> Here's what that would look like.\n> \n> -- >8 --\n> From: brian m. carlson \n> Subject: imap-send doc: omit confusing \"to use imap-send\" modifier\n> \n> It wouldn't make sense for these configuration variables to be\n> required for Git in general to function. 'Required' in this context\n> means required for git imap-send to work.\n> \n> Noticed while trying to figure out what the sentence describing\n> imap.tunnel meant.\n> \n> [jn: expanded to also simplify explanation of imap.folder and\n> imap.host in the same way]\n> \n> Signed-off-by: brian m. carlson \n> Signed-off-by: Jonathan Nieder \n> ---\n> Documentation/git-imap-send.txt | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/Documentation/git-imap-send.txt b/Documentation/git-imap-send.txt\n> index 875d283..d3b465d 100644\n> --- a/Documentation/git-imap-send.txt\n> +++ b/Documentation/git-imap-send.txt\n> @@ -38,17 +38,17 @@ Variables\n> imap.folder::\n> \tThe folder to drop the mails into, which is typically the Drafts\n> \tfolder. For example: \"INBOX.Drafts\", \"INBOX/Drafts\" or\n> -\t\"[Gmail]/Drafts\". Required to use imap-send.\n> +\t\"[Gmail]/Drafts\". Required.\n> \n> imap.tunnel::\n> \tCommand used to setup a tunnel to the IMAP server through which\n> \tcommands will be piped instead of using a direct network connection\n> -\tto the server. Required when imap.host is not set to use imap-send.\n> +\tto the server. Required when imap.host is not set.\n> \n> imap.host::\n> \tA URL identifying the server. Use a `imap://` prefix for non-secure\n> \tconnections and a `imaps://` prefix for secure connections.\n> -\tIgnored when imap.tunnel is set, but required to use imap-send\n> +\tIgnored when imap.tunnel is set, but required.\n\nThis has an extra period at the end of the line.\n\n> \totherwise.\n> \n> imap.user::\n> -- \n> \n\n-- \nbrian m. carlson / brian with sandals: Houston, Texas, US\n+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only\nOpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187\n"},{"id":"247269","messageId":"1407207410-26443-1-git-send-email-sandals@crustytoothpaste.net","threadId":"37279","inReplyTo":"20140805025108.GW12427@google.com","subject":"[PATCH v3] imap-send doc: omit confusing \"to use imap-send\" modifier","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2014-08-05T02:56:50Z","receivedAt":"2014-08-05T02:56:50Z","isPatch":true,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"It wouldn't make sense for these configuration variables to be\nrequired for Git in general to function. 'Required' in this context\nmeans required for git imap-send to work.\n\nNoticed while trying to figure out what the sentence describing\nimap.tunnel meant.\n\n[jn: expanded to also simplify explanation of imap.folder and\n imap.host in the same way]\n\nSigned-off-by: brian m. carlson \nSigned-off-by: Jonathan Nieder \n---\n Documentation/git-imap-send.txt | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/git-imap-send.txt b/Documentation/git-imap-send.txt\nindex 875d283..d3b465d 100644\n--- a/Documentation/git-imap-send.txt\n+++ b/Documentation/git-imap-send.txt\n@@ -38,17 +38,17 @@ Variables\n imap.folder::\n \tThe folder to drop the mails into, which is typically the Drafts\n \tfolder. For example: \"INBOX.Drafts\", \"INBOX/Drafts\" or\n-\t\"[Gmail]/Drafts\". Required to use imap-send.\n+\t\"[Gmail]/Drafts\". Required.\n \n imap.tunnel::\n \tCommand used to setup a tunnel to the IMAP server through which\n \tcommands will be piped instead of using a direct network connection\n-\tto the server. Required when imap.host is not set to use imap-send.\n+\tto the server. Required when imap.host is not set.\n \n imap.host::\n \tA URL identifying the server. Use a `imap://` prefix for non-secure\n \tconnections and a `imaps://` prefix for secure connections.\n-\tIgnored when imap.tunnel is set, but required to use imap-send\n+\tIgnored when imap.tunnel is set, but required.\n \totherwise.\n \n imap.user::\n-- \n2.0.1\n"},{"id":"247270","messageId":"20140805025721.GX12427@google.com","threadId":"37279","inReplyTo":"20140805025229.GB10435@vauxhall.crustytoothpaste.net","subject":"Re: [PATCH v2] Documentation: avoid dangling modifier for imap-send","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2014-08-05T02:57:21Z","receivedAt":"2014-08-05T02:57:21Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"brian m. carlson wrote:\n\n> This has an extra period at the end of the line.\n\nGood catch.\n\n-- >8 --\nSubject: fixup! imap-send doc: omit confusing \"to use imap-send\" modifier\n---\nThanks,\nJonathan\n\n Documentation/git-imap-send.txt | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-imap-send.txt b/Documentation/git-imap-send.txt\nindex d3b465d..eabcaf0 100644\n--- a/Documentation/git-imap-send.txt\n+++ b/Documentation/git-imap-send.txt\n@@ -48,8 +48,7 @@ imap.tunnel::\n imap.host::\n \tA URL identifying the server. Use a `imap://` prefix for non-secure\n \tconnections and a `imaps://` prefix for secure connections.\n-\tIgnored when imap.tunnel is set, but required.\n-\totherwise.\n+\tIgnored when imap.tunnel is set, but required otherwise.\n \n imap.user::\n \tThe username to use when logging in to the server.\n-- \n"},{"id":"247291","messageId":"xmqqvbq6oe7e.fsf@gitster.dls.corp.google.com","threadId":"37279","inReplyTo":"1407207410-26443-1-git-send-email-sandals@crustytoothpaste.net","subject":"Re: [PATCH v3] imap-send doc: omit confusing \"to use imap-send\" modifier","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2014-08-05T20:48:21Z","receivedAt":"2014-08-05T20:48:21Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"brian m. carlson\" writes:\n\n> It wouldn't make sense for these configuration variables to be\n> required for Git in general to function. 'Required' in this context\n> means required for git imap-send to work.\n>\n> Noticed while trying to figure out what the sentence describing\n> imap.tunnel meant.\n>\n> [jn: expanded to also simplify explanation of imap.folder and\n> imap.host in the same way]\n>\n> Signed-off-by: brian m. carlson \n> Signed-off-by: Jonathan Nieder \n> ---\n\nThanks, both. Will queue and squash the \"required. otherwise.\" fix in.\n\n> Documentation/git-imap-send.txt | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/Documentation/git-imap-send.txt b/Documentation/git-imap-send.txt\n> index 875d283..d3b465d 100644\n> --- a/Documentation/git-imap-send.txt\n> +++ b/Documentation/git-imap-send.txt\n> @@ -38,17 +38,17 @@ Variables\n> imap.folder::\n> \tThe folder to drop the mails into, which is typically the Drafts\n> \tfolder. For example: \"INBOX.Drafts\", \"INBOX/Drafts\" or\n> -\t\"[Gmail]/Drafts\". Required to use imap-send.\n> +\t\"[Gmail]/Drafts\". Required.\n> \n> imap.tunnel::\n> \tCommand used to setup a tunnel to the IMAP server through which\n> \tcommands will be piped instead of using a direct network connection\n> -\tto the server. Required when imap.host is not set to use imap-send.\n> +\tto the server. Required when imap.host is not set.\n> \n> imap.host::\n> \tA URL identifying the server. Use a `imap://` prefix for non-secure\n> \tconnections and a `imaps://` prefix for secure connections.\n> -\tIgnored when imap.tunnel is set, but required to use imap-send\n> +\tIgnored when imap.tunnel is set, but required.\n> \totherwise.\n> \n> imap.user::\n"}]}