{"thread":{"id":"37134","subject":"[PATCH] remove duplicate of is_branch","startedAt":"2014-07-15T23:02:37Z","lastAt":"2014-07-15T23:20:51Z","messageCount":3,"participants":["Ronnie Sahlberg","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"246110","messageId":"1405465358-27054-1-git-send-email-sahlberg@google.com","threadId":"37134","inReplyTo":null,"subject":"[PATCH] remove duplicate of is_branch","fromName":"Ronnie Sahlberg","fromEmail":"sahlberg@google.com","sentAt":"2014-07-15T23:02:37Z","receivedAt":"2014-07-15T23:02:37Z","isPatch":true,"sender":{"key":"sahlberg@google.com","avatar":"https://avatars.githubusercontent.com/u/7320636?v=4"},"body":"Jun, List\n\nPlease find a trivial patch that makes refs.c:is_branch public.\nThis allows us to delete the identical copy of is_branch in fsck.c\n\n\nRonnie Sahlberg (1):\n  refs.c: add a public is_branch function\n\n builtin/fsck.c | 5 -----\n refs.c         | 2 +-\n refs.h         | 2 ++\n 3 files changed, 3 insertions(+), 6 deletions(-)\n\n-- \n2.0.1.442.g7fe6834.dirty\n"},{"id":"246111","messageId":"1405465358-27054-2-git-send-email-sahlberg@google.com","threadId":"37134","inReplyTo":"1405465358-27054-1-git-send-email-sahlberg@google.com","subject":"[PATCH] refs.c: add a public is_branch function","fromName":"Ronnie Sahlberg","fromEmail":"sahlberg@google.com","sentAt":"2014-07-15T23:02:38Z","receivedAt":"2014-07-15T23:02:38Z","isPatch":true,"sender":{"key":"sahlberg@google.com","avatar":"https://avatars.githubusercontent.com/u/7320636?v=4"},"body":"Both refs.c and fsck.c have their own private copies of the is_branch function.\nDelete the is_branch function from fsck.c and make the version in refs.c\npublic.\n\nSigned-off-by: Ronnie Sahlberg <sahlberg@google.com>\n---\n builtin/fsck.c | 5 -----\n refs.c         | 2 +-\n refs.h         | 2 ++\n 3 files changed, 3 insertions(+), 6 deletions(-)\n\ndiff --git a/builtin/fsck.c b/builtin/fsck.c\nindex fc150c8..a473622 100644\n--- a/builtin/fsck.c\n+++ b/builtin/fsck.c\n@@ -482,11 +482,6 @@ static int fsck_handle_reflog(const char *logname, const unsigned char *sha1, in\n \treturn 0;\n }\n \n-static int is_branch(const char *refname)\n-{\n-\treturn !strcmp(refname, \"HEAD\") || starts_with(refname, \"refs/heads/\");\n-}\n-\n static int fsck_handle_ref(const char *refname, const unsigned char *sha1, int flag, void *cb_data)\n {\n \tstruct object *obj;\ndiff --git a/refs.c b/refs.c\nindex dc45774..dc44802 100644\n--- a/refs.c\n+++ b/refs.c\n@@ -2817,7 +2817,7 @@ static int log_ref_write(const char *refname, const unsigned char *old_sha1,\n \treturn 0;\n }\n \n-static int is_branch(const char *refname)\n+int is_branch(const char *refname)\n {\n \treturn !strcmp(refname, \"HEAD\") || starts_with(refname, \"refs/heads/\");\n }\ndiff --git a/refs.h b/refs.h\nindex 4e3050d..8b4a3f2 100644\n--- a/refs.h\n+++ b/refs.h\n@@ -125,6 +125,8 @@ extern int repack_without_refs(const char **refnames, int n);\n \n extern int ref_exists(const char *);\n \n+extern int is_branch(const char *refname);\n+\n /*\n  * If refname is a non-symbolic reference that refers to a tag object,\n  * and the tag can be (recursively) dereferenced to a non-tag object,\n-- \n2.0.1.442.g7fe6834.dirty\n"},{"id":"246112","messageId":"20140715232051.GL12427@google.com","threadId":"37134","inReplyTo":"1405465358-27054-2-git-send-email-sahlberg@google.com","subject":"Re: [PATCH] refs.c: add a public is_branch function","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2014-07-15T23:20:51Z","receivedAt":"2014-07-15T23:20:51Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Ronnie Sahlberg wrote:\n\n> Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>\n> ---\n>  builtin/fsck.c | 5 -----\n>  refs.c         | 2 +-\n>  refs.h         | 2 ++\n>  3 files changed, 3 insertions(+), 6 deletions(-)\n\nMakes sense -- thanks.  (This is an old one: v1.5.4-rc4~27\n(2008-01-15), v1.5.4-rc4~30 (2008-01-15).  Most of the running time of\nfsck is per-object, not per-ref, so maintainability here seems worth\nthe performance cost.)\n\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n"}]}