{"thread":{"id":"37090","subject":"Align git push stderr output to the same as git pull","startedAt":"2014-07-10T05:33:47Z","lastAt":"2014-07-10T20:50:26Z","messageCount":2,"participants":["Sam McLeod","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"245679","messageId":"CAEc--nsLqVP1TfWgjcrmb=-AmURw3aOV7Na_wX0SWr9isjRVfQ@mail.gmail.com","threadId":"37090","inReplyTo":null,"subject":"Align git push stderr output to the same as git pull","fromName":"Sam McLeod","fromEmail":"sammcj@gmail.com","sentAt":"2014-07-10T05:33:47Z","receivedAt":"2014-07-10T05:33:47Z","isPatch":false,"sender":{"key":"sammcj@gmail.com","avatar":null},"body":"As per: https://github.com/git/git/pull/100\n\n'For already up-to-date repos return \"Already up-to-date\" which is the\nsame message git pull returns.'\n\nDeveloper's Certificate of Origin 1.1\n\nBy making a contribution to this project, I certify that:\n\n(a) The contribution was created in whole or in part by me and I\n  have the right to submit it under the open source license\n  indicated in the file; or\n\n(b) The contribution is based upon previous work that, to the best\n  of my knowledge, is covered under an appropriate open source\n  license and I have the right under that license to submit that\n  work with modifications, whether created in whole or in part\n  by me, under the same open source license (unless I am\n  permitted to submit under a different license), as indicated\n  in the file; or\n\n(c) The contribution was provided directly to me by some other\n  person who certified (a), (b) or (c) and I have not modified\n  it.\n\n(d) I understand and agree that this project and the contribution\n  are public and that a record of the contribution (including all\n  personal information I submit with it, including my sign-off) is\n  maintained indefinitely and may be redistributed consistent with\n  this project or the open source license(s) involved.\n\n  Signed-off-by: Sam McLeod <sammcj@gmail.com>\n\n\ndiff --git a/builtin/send-pack.c b/builtin/send-pack.c\nindex f420b74..6fb2642 100644\n--- a/builtin/send-pack.c\n+++ b/builtin/send-pack.c\n@@ -274,7 +274,7 @@ int cmd_send_pack(int argc, const char **argv, const char *prefix)\n \t}\n \n \tif (!ret && !transport_refs_pushed(remote_refs))\n-\t\tfprintf(stderr, \"Everything up-to-date\\n\");\n+\t\tfprintf(stderr, \"Already up-to-date\\n\");\n \n \treturn ret;\n }\ndiff --git a/transport.c b/transport.c\nindex 59c9727..4dd9f74 100644\n--- a/transport.c\n+++ b/transport.c\n@@ -1220,7 +1220,7 @@ int transport_push(struct transport *transport,\n \t\tif (porcelain && !push_ret)\n \t\t\tputs(\"Done\");\n \t\telse if (!quiet && !ret && !transport_refs_pushed(remote_refs))\n-\t\t\tfprintf(stderr, \"Everything up-to-date\\n\");\n+\t\t\tfprintf(stderr, \"Already up-to-date\\n\");\n \n \t\treturn ret;\n \t}\n"},{"id":"245720","messageId":"20140710205026.GC4459@sigill.intra.peff.net","threadId":"37090","inReplyTo":"CAEc--nsLqVP1TfWgjcrmb=-AmURw3aOV7Na_wX0SWr9isjRVfQ@mail.gmail.com","subject":"Re: Align git push stderr output to the same as git pull","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2014-07-10T20:50:26Z","receivedAt":"2014-07-10T20:50:26Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Jul 10, 2014 at 03:33:47PM +1000, Sam McLeod wrote:\n\n> 'For already up-to-date repos return \"Already up-to-date\" which is the\n> same message git pull returns.'\n\nPlease send your patches inline as a single body part, as generated by\n\"git format-patch\" (you can use git-send-email to send).\n\n> Developer's Certificate of Origin 1.1\n\nYou can drop the DCO here. Your Signed-off-by line is enough.\n\n> diff --git a/builtin/send-pack.c b/builtin/send-pack.c\n> index f420b74..6fb2642 100644\n> --- a/builtin/send-pack.c\n> +++ b/builtin/send-pack.c\n> @@ -274,7 +274,7 @@ int cmd_send_pack(int argc, const char **argv, const char *prefix)\n>  \t}\n>  \n>  \tif (!ret && !transport_refs_pushed(remote_refs))\n> -\t\tfprintf(stderr, \"Everything up-to-date\\n\");\n> +\t\tfprintf(stderr, \"Already up-to-date\\n\");\n\nHrm. So this makes things consistent with git-pull, but despite the\nnames, push and pull are not actually opposites. Push and fetch are\nopposites. And fetch does not say anything in the up-to-date case.\n\nSo I'd somewhat wonder whether we should just be making \"push\" less\nchatty here. Still, that is a much bigger change that some people might\ndisagree with, and I confess I don't care overly (but nor did the\nEverything/Already ever bother me either :) ).\n\n-Peff\n"}]}