{"thread":{"id":"37086","subject":"t3200-branch.sh number 102 fails when run under make test","startedAt":"2014-07-09T20:37:51Z","lastAt":"2014-07-09T21:17:32Z","messageCount":4,"participants":["Keller, Jacob E","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"245652","messageId":"1404938270.23510.13.camel@jekeller-desk1.amr.corp.intel.com","threadId":"37086","inReplyTo":null,"subject":"t3200-branch.sh number 102 fails when run under make test","fromName":"Keller, Jacob E","fromEmail":"jacob.e.keller@intel.com","sentAt":"2014-07-09T20:37:51Z","receivedAt":"2014-07-09T20:37:51Z","isPatch":false,"sender":{"key":"jacob.e.keller@intel.com","avatar":"https://avatars.githubusercontent.com/u/874719?v=4"},"body":"Hello,\n\nI recently cloned the master branch of the git repo, and when I ran make\ntest, it fails on test 102 of the t3200-branch.sh test cases.\n\nnot ok 102 - tracking with unexpected .fetch refspec\n#\n#               rm -rf a b c d &&\n#               git init a &&\n#               (\n#                       cd a &&\n#                       test_commit a\n#               ) &&\n#               git init b &&\n#               (\n#                       cd b &&\n#                       test_commit b\n#               ) &&\n#               git init c &&\n#               (\n#                       cd c &&\n#                       test_commit c &&\n#                       git remote add a ../a &&\n#                       git remote add b ../b &&\n#                       git fetch --all\n#               ) &&\n#               git init d &&\n#               (\n#                       cd d &&\n#                       git remote add c ../c &&\n#                       git config remote.c.fetch \"+refs/remotes/*:refs/remotes/*\" &&\n#                       git fetch c &&\n#                       git branch --track local/a/master remotes/a/master &&\n#                       test \"$(git config branch.local/a/master.remote)\" = \"c\" &&\n#                       test \"$(git config branch.local/a/master.merge)\" = \"refs/remotes/a/master\" &&\n#                       git rev-parse --verify a >expect &&\n#                       git rev-parse --verify local/a/master >actual &&\n#                       test_cmp expect actual\n#               )\n#\n# failed 1 among 102 test(s)\n1..102\n\nHowever, when I run the test file manually it passes. I am currently\nrunning through a verbose output test run to see if I can find more\nuseful output..\n\nFor reference, the commit I am testing against is:\n\n72c779457cd7 (\"line-log: use commit_list_append() instead of duplicating its code\")\n\nThanks,\nJake\n"},{"id":"245653","messageId":"20140709205407.GA25854@sigill.intra.peff.net","threadId":"37086","inReplyTo":"1404938270.23510.13.camel@jekeller-desk1.amr.corp.intel.com","subject":"Re: t3200-branch.sh number 102 fails when run under make test","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2014-07-09T20:54:07Z","receivedAt":"2014-07-09T20:54:07Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Jul 09, 2014 at 08:37:51PM +0000, Keller, Jacob E wrote:\n\n> I recently cloned the master branch of the git repo, and when I ran make\n> test, it fails on test 102 of the t3200-branch.sh test cases.\n\nJust a guess, but try reverting 745224e (refs.c: SSE2 optimizations for\ncheck_refname_component, 2014-06-18).\n\nThat commit causes some weird memory accesses that only show up under\ncertain conditions[1]. There's a possible fix that is not yet applied,\nbut reverting should be an easy way to test.\n\n-Peff\n\n[1] http://thread.gmane.org/gmane.comp.version-control.git/252881\n"},{"id":"245654","messageId":"1404939405.23510.28.camel@jekeller-desk1.amr.corp.intel.com","threadId":"37086","inReplyTo":"1404938270.23510.13.camel@jekeller-desk1.amr.corp.intel.com","subject":"Re: t3200-branch.sh number 102 fails when run under make test","fromName":"Keller, Jacob E","fromEmail":"jacob.e.keller@intel.com","sentAt":"2014-07-09T20:56:46Z","receivedAt":"2014-07-09T20:56:46Z","isPatch":false,"sender":{"key":"jacob.e.keller@intel.com","avatar":"https://avatars.githubusercontent.com/u/874719?v=4"},"body":"On Wed, 2014-07-09 at 13:37 -0700, Jacob E Keller wrote:\n> Hello,\n> \n> I recently cloned the master branch of the git repo, and when I ran make\n> test, it fails on test 102 of the t3200-branch.sh test cases.\n> \n> not ok 102 - tracking with unexpected .fetch refspec\n> #\n> #               rm -rf a b c d &&\n> #               git init a &&\n> #               (\n> #                       cd a &&\n> #                       test_commit a\n> #               ) &&\n> #               git init b &&\n> #               (\n> #                       cd b &&\n> #                       test_commit b\n> #               ) &&\n> #               git init c &&\n> #               (\n> #                       cd c &&\n> #                       test_commit c &&\n> #                       git remote add a ../a &&\n> #                       git remote add b ../b &&\n> #                       git fetch --all\n> #               ) &&\n> #               git init d &&\n> #               (\n> #                       cd d &&\n> #                       git remote add c ../c &&\n> #                       git config remote.c.fetch \"+refs/remotes/*:refs/remotes/*\" &&\n> #                       git fetch c &&\n> #                       git branch --track local/a/master remotes/a/master &&\n> #                       test \"$(git config branch.local/a/master.remote)\" = \"c\" &&\n> #                       test \"$(git config branch.local/a/master.merge)\" = \"refs/remotes/a/master\" &&\n> #                       git rev-parse --verify a >expect &&\n> #                       git rev-parse --verify local/a/master >actual &&\n> #                       test_cmp expect actual\n> #               )\n> #\n> # failed 1 among 102 test(s)\n> 1..102\n> \n> However, when I run the test file manually it passes. I am currently\n> running through a verbose output test run to see if I can find more\n> useful output..\n> \n> For reference, the commit I am testing against is:\n> \n> 72c779457cd7 (\"line-log: use commit_list_append() instead of duplicating its code\")\n> \n> Thanks,\n> Jake\n\nI ran the test wit the GIT_TEST_OPS set to --verbose, and the output I got is:\nexpecting success: \n\trm -rf a b c d &&\n\tgit init a &&\n\t(\n\t\tcd a &&\n\t\ttest_commit a\n\t) &&\n\tgit init b &&\n\t(\n\t\tcd b &&\n\t\ttest_commit b\n\t) &&\n\tgit init c &&\n\t(\n\t\tcd c &&\n\t\ttest_commit c &&\n\t\tgit remote add a ../a &&\n\t\tgit remote add b ../b &&\n\t\tgit fetch --all\n\t) &&\n\tgit init d &&\n\t(\n\t\tcd d &&\n\t\tgit remote add c ../c &&\n\t\tgit config remote.c.fetch \"+refs/remotes/*:refs/remotes/*\" &&\n\t\tgit fetch c &&\n\t\tgit branch --track local/a/master remotes/a/master &&\n\t\ttest \"$(git config branch.local/a/master.remote)\" = \"c\" &&\n\t\ttest \"$(git config branch.local/a/master.merge)\" = \"refs/remotes/a/master\" &&\n\t\tgit rev-parse --verify a >expect &&\n\t\tgit rev-parse --verify local/a/master >actual &&\n\t\ttest_cmp expect actual\n\t)\n\nInitialized empty Git repository in /home/jekeller/git/git/t/trash directory.t3200-branch/a/.git/\n[master (root-commit) ce450c7] a\n Author: A U Thor <author@example.com>\n 1 file changed, 1 insertion(+)\n create mode 100644 a.t\nInitialized empty Git repository in /home/jekeller/git/git/t/trash directory.t3200-branch/b/.git/\n[master (root-commit) 19acec0] b\n Author: A U Thor <author@example.com>\n 1 file changed, 1 insertion(+)\n create mode 100644 b.t\nInitialized empty Git repository in /home/jekeller/git/git/t/trash directory.t3200-branch/c/.git/\n[master (root-commit) ea1ac38] c\n Author: A U Thor <author@example.com>\n 1 file changed, 1 insertion(+)\n create mode 100644 c.t\nfatal: Invalid refspec '+refs/heads/*:refs/remotes/b/*'\nnot ok 102 - tracking with unexpected .fetch refspec\n#\t\n#\t\trm -rf a b c d &&\n#\t\tgit init a &&\n#\t\t(\n#\t\t\tcd a &&\n#\t\t\ttest_commit a\n#\t\t) &&\n#\t\tgit init b &&\n#\t\t(\n#\t\t\tcd b &&\n#\t\t\ttest_commit b\n#\t\t) &&\n#\t\tgit init c &&\n#\t\t(\n#\t\t\tcd c &&\n#\t\t\ttest_commit c &&\n#\t\t\tgit remote add a ../a &&\n#\t\t\tgit remote add b ../b &&\n#\t\t\tgit fetch --all\n#\t\t) &&\n#\t\tgit init d &&\n#\t\t(\n#\t\t\tcd d &&\n#\t\t\tgit remote add c ../c &&\n#\t\t\tgit config remote.c.fetch \"+refs/remotes/*:refs/remotes/*\" &&\n#\t\t\tgit fetch c &&\n#\t\t\tgit branch --track local/a/master remotes/a/master &&\n#\t\t\ttest \"$(git config branch.local/a/master.remote)\" = \"c\" &&\n#\t\t\ttest \"$(git config branch.local/a/master.merge)\" = \"refs/remotes/a/master\" &&\n#\t\t\tgit rev-parse --verify a >expect &&\n#\t\t\tgit rev-parse --verify local/a/master >actual &&\n#\t\t\ttest_cmp expect actual\n#\t\t)\n#\t\n\n# failed 1 among 102 test(s)\n1..102\nmake[2]: *** [t3200-branch.sh] Error 1\nmake[2]: Leaving directory `/home/jekeller/git/git/t'\nmake[1]: *** [test] Error 2\nmake[1]: Leaving directory `/home/jekeller/git/git/t'\nmake: *** [test] Error 2\n\nI have to run this as part of the \"make test\" setup. Is there a way to\nrun a single test script instead of the entire test suite? If so, then I\nmay be able to perform a bisect against the test to find the commit\nwhere this breaks.\n\nThanks,\nJake\n"},{"id":"245656","messageId":"1404940652.23510.32.camel@jekeller-desk1.amr.corp.intel.com","threadId":"37086","inReplyTo":"20140709205407.GA25854@sigill.intra.peff.net","subject":"Re: t3200-branch.sh number 102 fails when run under make test","fromName":"Keller, Jacob E","fromEmail":"jacob.e.keller@intel.com","sentAt":"2014-07-09T21:17:32Z","receivedAt":"2014-07-09T21:17:32Z","isPatch":false,"sender":{"key":"jacob.e.keller@intel.com","avatar":"https://avatars.githubusercontent.com/u/874719?v=4"},"body":"On Wed, 2014-07-09 at 16:54 -0400, Jeff King wrote:\n> On Wed, Jul 09, 2014 at 08:37:51PM +0000, Keller, Jacob E wrote:\n> \n> > I recently cloned the master branch of the git repo, and when I ran make\n> > test, it fails on test 102 of the t3200-branch.sh test cases.\n> \n> Just a guess, but try reverting 745224e (refs.c: SSE2 optimizations for\n> check_refname_component, 2014-06-18).\n> \n> That commit causes some weird memory accesses that only show up under\n> certain conditions[1]. There's a possible fix that is not yet applied,\n> but reverting should be an easy way to test.\n> \n> -Peff\n> \n> [1] http://thread.gmane.org/gmane.comp.version-control.git/252881\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n\nYes, performing the revert appears to fix the issue. Hopefully the\nproposed fix also works.\n\nThanks,\nJake\n"}]}