{"thread":{"id":"3680","subject":"[PATCH] Add missing semicolon to sed command.","startedAt":"2006-03-20T00:18:08Z","lastAt":"2006-03-20T02:15:56Z","messageCount":2,"participants":["Shawn Pearce","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"17690","messageId":"20060320001808.GB20765@spearce.org","threadId":"3680","inReplyTo":null,"subject":"[PATCH] Add missing semicolon to sed command.","fromName":"Shawn Pearce","fromEmail":"spearce@spearce.org","sentAt":"2006-03-20T00:18:08Z","receivedAt":"2006-03-20T00:18:08Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"generate-cmdlist.sh is giving errors messages from sed on Mac OS\n10.4 due to a missing semicolon.\n\n---\n\n generate-cmdlist.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\nbase f81e7c626f34658289594386b0273755f47912a2\nlast 09913c10d93adbfa61138b7ac7ae6a8a210aa29f\ndiff --git a/generate-cmdlist.sh b/generate-cmdlist.sh\nindex 6ee85d5..76ba49c 100755\n--- a/generate-cmdlist.sh\n+++ b/generate-cmdlist.sh\n@@ -42,7 +42,7 @@ EOF\n while read cmd\n do\n     sed -n \"/NAME/,/git-$cmd/H;\n-\t    \\$ {x; s/.*git-$cmd - \\\\(.*\\\\)/  {\\\"$cmd\\\", \\\"\\1\\\"},/; p}\" \\\n+\t    \\$ {x; s/.*git-$cmd - \\\\(.*\\\\)/  {\\\"$cmd\\\", \\\"\\1\\\"},/; p;}\" \\\n \t\"Documentation/git-$cmd.txt\"\n done\n echo \"};\"\n-- \n1.2.4.g41f6\n"},{"id":"17693","messageId":"7v1wwxn9nn.fsf@assigned-by-dhcp.cox.net","threadId":"3680","inReplyTo":"20060320001808.GB20765@spearce.org","subject":"Re: [PATCH] Add missing semicolon to sed command.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-03-20T02:15:56Z","receivedAt":"2006-03-20T02:15:56Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Shawn Pearce <spearce@spearce.org> writes:\n\n> generate-cmdlist.sh is giving errors messages from sed on Mac OS\n> 10.4 due to a missing semicolon.\n\nI'll take this patch for now, but I've heard a horror story that\nsome other vintage of sed apparently does not like multiple\ncommands separated by semicolons at all, and I've been training\nmyself to do this kind of thing always as multi-line sed script,\nlike this:\n\n     sed -n '\n     /NAME/,/git-'\"$cmd\"'/H\n     ${\n            x\n            s/.*git-'\"$cmd\"' - \\(.*\\)/  {\"'\"$cmd\"'\", \"\\1\"},/\n\t    p\n     }' \"Documentation/git-$cmd.txt\"\n"}]}